spiegel_podman/cmd/podman
Brent Baude 40b2a585f9 Autocomplete machine fixes
Fixups for autocomplete for machine commands.  This was authored by Paul
Holzinger.

Thank you very much!

Signed-off-by: Brent Baude <bbaude@redhat.com>
2026-02-02 15:19:37 -06:00
..
artifact Vendor common test for artifact digest lookup 2026-01-26 15:45:56 -06:00
common Autocomplete machine fixes 2026-02-02 15:19:37 -06:00
completion Bump Go version to v6 2025-10-23 11:00:15 -04:00
containers Merge pull request #26445 from aaron-ang/update-ulimit 2026-01-16 08:38:00 -05:00
diff Bump Go version to v6 2025-10-23 11:00:15 -04:00
farm enable gofumpt formatter 2025-11-11 12:32:46 +01:00
generate enable gofumpt formatter 2025-11-11 12:32:46 +01:00
healthcheck enable gofumpt formatter 2025-11-11 12:32:46 +01:00
images Add Repository and Tag fields to image list --format JSON output 2025-12-03 17:53:26 -05:00
inspect Bump Go version to v6 2025-10-23 11:00:15 -04:00
kube Bump Go version to v6 2025-10-23 11:00:15 -04:00
machine Autocomplete machine fixes 2026-02-02 15:19:37 -06:00
manifest enable gofumpt formatter 2025-11-11 12:32:46 +01:00
networks Remove deprecated --macvlan flag from network create 2025-11-26 02:26:24 +05:30
parse enable gofumpt formatter 2025-11-11 12:32:46 +01:00
pods enable gofumpt formatter 2025-11-11 12:32:46 +01:00
quadlet Bump Go version to v6 2025-10-23 11:00:15 -04:00
registry Bump Go version to v6 2025-10-23 11:00:15 -04:00
secrets secrets/create: remove pipe check and allow interactive stdin 2026-01-14 17:00:25 +05:30
system Remove CNI backend from CLI options and completions 2026-01-27 16:32:38 +05:30
utils enable gofumpt formatter 2025-11-11 12:32:46 +01:00
validate Bump Go version to v6 2025-10-23 11:00:15 -04:00
volumes enable gofumpt formatter 2025-11-11 12:32:46 +01:00
auto-update.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
client.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
client_supported.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
client_unsupported.go Show client info even if remote connection fails 2023-10-13 08:53:56 -05:00
compose.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
compose_machine.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
compose_machine_unix.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
compose_machine_unsupported.go podman compose: correctly accept --connection/--url 2024-02-27 13:40:41 +01:00
compose_machine_windows.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
diff.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
early_init_darwin.go set RLIMIT_NOFILE soft limit to match the hard limit on mac 2023-11-10 15:35:57 -06:00
early_init_linux.go fileperms: newer Go 1.13+ octal literal format 2025-10-16 14:11:29 -04:00
early_init_unsupported.go chore: delete obsolete // +build lines 2024-01-04 11:53:38 +02:00
inspect.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
login.go enable gofumpt formatter 2025-11-11 12:32:46 +01:00
logout.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
main.go enable gofumpt formatter 2025-11-11 12:32:46 +01:00
README.md chore: remove repetitive word in cmd/podman/README.md 2025-10-16 15:25:34 +08:00
root.go Remove CNI backend from CLI options and completions 2026-01-27 16:32:38 +05:30
root_cgroups_linux.go cmd/podman.persistentRunE(): Fatal linux check if no Cgroups v2 2025-11-12 15:15:32 -05:00
root_cgroups_unsupported.go cmd/podman.persistentRunE(): Fatal linux check if no Cgroups v2 2025-11-12 15:15:32 -05:00
root_test.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
shell_completion_test.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
syslog_common.go Bump Go version to v6 2025-10-23 11:00:15 -04:00
syslog_unsupported.go Fix missing newlines in stderr error messages 2025-12-17 07:36:04 -05:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podman/manifest

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/manifest.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podman/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifest"

Adding a new sub command podman manifest list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podman/manifest/inspect.go

package manifest

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())
    

Adding CLI flags

When adding a new cli option that accepts a string array, there are two options to choose from: StringSlice() and StringArray(). They differ slightly in their behavior: StringSlice() allows the values to be comma separated so --opt v1,v2 --opt v3 results in []string{"v1", "v2", "v3"}, while StringArray() would result in []string{"v1,v2", "v3"}. Thus it is impossible to use values with comma in StringSlice(), which makes it unsuitable for flags that accept arbitrary values such as file paths as example. Also, because StringSlice() uses the csv lib to parse the values, it has special escaping rules for things like quotes, see https://github.com/containers/podman/issues/20064 for an example of how complicated things can get because of this. Thus use StringSlice() only when the option accepts predefined values that do not contain special characters, for example --cap-add and --cap-drop are a good example for this. Using --cap-add NET_ADMIN,NET_RAW is equal to --cap-add NET_ADMIN --cap-add NET_RAW so it is better suited to save some typing for users. When in doubt always choose StringArray() over StringSlice().