mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-11 03:15:44 +00:00
20eccfc9d0
Currently the podman command --format output code uses a mix of report.Formatter and report.Template. I patched report.Formatter to correctly handle newlines[1]. Since we cannot fix this with report.Template we have to migrate all users to report.Formatter. This ensures consistent behavior for all commands. This change does not change the output, we can add a new test for the newline bug when the common PR is vendored in. Also fix a bug where a invlaid template would not cause a exit code > 0, see the added test case. [1] https://github.com/containers/common/pull/1146 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
97 lines
2.4 KiB
Go
97 lines
2.4 KiB
Go
//go:build amd64 || arm64
|
|
// +build amd64 arm64
|
|
|
|
package machine
|
|
|
|
import (
|
|
"os"
|
|
|
|
"github.com/containers/common/pkg/report"
|
|
"github.com/containers/podman/v4/cmd/podman/common"
|
|
"github.com/containers/podman/v4/cmd/podman/registry"
|
|
"github.com/containers/podman/v4/cmd/podman/utils"
|
|
"github.com/containers/podman/v4/pkg/machine"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
var (
|
|
inspectCmd = &cobra.Command{
|
|
Use: "inspect [options] [MACHINE...]",
|
|
Short: "Inspect an existing machine",
|
|
Long: "Provide details on a managed virtual machine",
|
|
PersistentPreRunE: rootlessOnly,
|
|
RunE: inspect,
|
|
Example: `podman machine inspect myvm`,
|
|
ValidArgsFunction: autocompleteMachine,
|
|
}
|
|
inspectFlag = inspectFlagType{}
|
|
)
|
|
|
|
type inspectFlagType struct {
|
|
format string
|
|
}
|
|
|
|
func init() {
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Command: inspectCmd,
|
|
Parent: machineCmd,
|
|
})
|
|
|
|
flags := inspectCmd.Flags()
|
|
formatFlagName := "format"
|
|
flags.StringVar(&inspectFlag.format, formatFlagName, "", "Format volume output using JSON or a Go template")
|
|
_ = inspectCmd.RegisterFlagCompletionFunc(formatFlagName, common.AutocompleteFormat(&machine.InspectInfo{}))
|
|
}
|
|
|
|
func inspect(cmd *cobra.Command, args []string) error {
|
|
var (
|
|
errs utils.OutputErrors
|
|
)
|
|
if len(args) < 1 {
|
|
args = append(args, defaultMachineName)
|
|
}
|
|
vms := make([]machine.InspectInfo, 0, len(args))
|
|
provider := GetSystemDefaultProvider()
|
|
for _, vmName := range args {
|
|
vm, err := provider.LoadVMByName(vmName)
|
|
if err != nil {
|
|
errs = append(errs, err)
|
|
continue
|
|
}
|
|
ii, err := vm.Inspect()
|
|
if err != nil {
|
|
errs = append(errs, err)
|
|
continue
|
|
}
|
|
vms = append(vms, *ii)
|
|
}
|
|
|
|
switch {
|
|
case cmd.Flag("format").Changed:
|
|
rpt := report.New(os.Stdout, cmd.Name())
|
|
defer rpt.Flush()
|
|
|
|
rpt, err := rpt.Parse(report.OriginUser, inspectFlag.format)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
if err := rpt.Execute(vms); err != nil {
|
|
errs = append(errs, err)
|
|
}
|
|
default:
|
|
if err := printJSON(vms); err != nil {
|
|
errs = append(errs, err)
|
|
}
|
|
}
|
|
return errs.PrintErrors()
|
|
}
|
|
|
|
func printJSON(data []machine.InspectInfo) error {
|
|
enc := json.NewEncoder(os.Stdout)
|
|
// by default, json marshallers will force utf=8 from
|
|
// a string. this breaks healthchecks that use <,>, &&.
|
|
enc.SetEscapeHTML(false)
|
|
enc.SetIndent("", " ")
|
|
return enc.Encode(data)
|
|
}
|