spiegel_podman/cmd/podman
Jhon Honce 5dabff27db Scrub podman commands to use report package
Refactor podman commands that have drifted from using
c/common report pkg. Report pkg is needed to implement
go template functions.

Removed obsolete code from podman which exists in c/common.

Latest template library added default newlines and method to
remove them. Incorporated needed changes in c/common PR below.

Depends on https://github.com/containers/common/pull/624
Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1855983

Signed-off-by: Jhon Honce <jhonce@redhat.com>

<MH: Fixed cherry-pick conflicts>

Signed-off-by: Matthew Heon <mheon@redhat.com>
2021-06-25 09:33:06 -04:00
..
common Several shell completion fixes 2021-06-11 13:06:06 -04:00
completion Add powershell completions 2021-03-29 15:00:09 +02:00
containers Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
generate Add podman run --timeout option 2021-04-23 11:18:05 -04:00
healthcheck bump go module to v3 2021-02-22 09:03:51 +01:00
images Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
inspect Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
machine Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
manifest migrate Podman to containers/common/libimage 2021-05-05 11:30:12 +02:00
networks Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
parse Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
play add --mac-address to podman play kube 2021-05-04 20:14:13 +02:00
pods Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
registry bump go module to v3 2021-02-22 09:03:51 +01:00
secrets Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
system Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
utils Add podman run --timeout option 2021-04-23 11:18:05 -04:00
validate bump go module to v3 2021-02-22 09:03:51 +01:00
volumes Scrub podman commands to use report package 2021-06-25 09:33:06 -04:00
auto-update.go bump go module to v3 2021-02-22 09:03:51 +01:00
diff.go Add go template shell completion for --format 2021-04-22 00:31:08 +02:00
early_init_linux.go bump go module to v3 2021-02-22 09:03:51 +01:00
early_init_unsupported.go abi: set default umask and rlimits 2020-07-17 20:53:38 +02:00
inspect.go bump go module to v3 2021-02-22 09:03:51 +01:00
login.go bump go module to v3 2021-02-22 09:03:51 +01:00
logout.go bump go module to v3 2021-02-22 09:03:51 +01:00
main.go Podman machine CLI and interface stub 2021-03-25 08:41:11 -05:00
README.md Switch all references to github.com/containers/libpod -> podman 2020-07-28 08:23:45 -04:00
root.go At trace log level, print error text using %+v instead of %v 2021-04-14 13:45:36 -04:00
root_test.go bump go module to v3 2021-02-22 09:03:51 +01:00
shell_completion_test.go bump go module to v3 2021-02-22 09:03:51 +01:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/cmd/podman/validate"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/podman/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/podman/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/podman/cmd/podman/registry"
    "github.com/containers/podman/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())