Paul Holzinger a360b29626 pkg/bindings/containers: do not ignore ErrUnexpectedEOF ... Do not ignore ErrUnexpectedEOF from DemuxHeader(), if we fail to parse the header there must have been a clear protocal error between client and server which should be reported and not silently ignored. I wonder ig this might explain why we have missing remote exec/attach output without any error, it is possible we are eating some internal errors due this. Commit ba8eba83ef added the ErrUnexpectedEOF check but without any explanation why that would be needed. The tests from that commit pass without it locally but not in CI. With some debugging best I found the issue is actually a test bug. The channel is not consumed until it is closed which means the main test exists before the log reading goroutine is done. And if the main test exists the first step it does is to kill the podman service which then can trigger the ErrUnexpectedEOF server on the still open http connection and thus the test case failed there. Signed-off-by: Paul Holzinger <pholzing@redhat.com>		2025-07-10 19:57:16 +02:00
..
archive.go
attach.go	pkg/bindings/containers: do not ignore ErrUnexpectedEOF	2025-07-10 19:57:16 +02:00
checkpoint.go
commit.go
containers.go	remove unused ShouldRestart() code	2025-06-26 19:37:13 +02:00
create.go
diff.go
exec.go
healthcheck.go
logs.go	pkg/bindings/containers: do not ignore ErrUnexpectedEOF	2025-07-10 19:57:16 +02:00
mount.go
rename.go
term_unix.go
term_windows.go	pkg/bindings/containers: rm unused break	2025-04-15 14:55:53 -07:00
types.go
types_attach_options.go
types_checkpoint_options.go
types_commit_options.go
types_copy_options.go
types_create_options.go
types_diff_options.go
types_execinspect_options.go
types_execremove_options.go
types_execstart_options.go
types_execstartandattach_options.go
types_exists_options.go
types_export_options.go
types_healthcheck_options.go
types_init_options.go
types_inspect_options.go
types_kill_options.go
types_list_options.go
types_log_options.go
types_mount_options.go
types_mountedcontainerpaths_options.go
types_pause_options.go
types_prune_options.go
types_remove_options.go
types_rename_options.go
types_resizeexectty_options.go
types_resizetty_options.go
types_restart_options.go
types_restore_options.go
types_shouldrestart_options.go
types_start_options.go
types_stats_options.go
types_stop_options.go
types_top_options.go
types_unmount_options.go
types_unpause_options.go
types_wait_options.go
update.go