mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-10 10:55:46 +00:00
ab6c43f3e0
In commit d81021ed26 I introduced shell completion for the `--format`
flag. This is a very nice way to complete go template field names.
However it did not work correct for anonymous fields. In this case the
child fields can be accessed directly from the parent.
For example:
```
type Anonymous struct {
Field1 string
Field2 string
...
}
type MyType struct {
Anonymous
}
var s = MyType{}
```
Now if you want to access a field from the Anonymous struct you can just
do `s.Field1`. The same is allowed for go templates, using `{{.Field1}}`
should work. This commit adds this functionality, if the field is anonymous
read the child field names recursively and add them to the suggestions.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
149 lines
2.8 KiB
Go
149 lines
2.8 KiB
Go
package common_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/containers/podman/v3/cmd/podman/common"
|
|
"github.com/spf13/cobra"
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type Car struct {
|
|
Brand string
|
|
Stats struct {
|
|
HP *int
|
|
Displacement int
|
|
}
|
|
Extras map[string]string
|
|
}
|
|
|
|
type Anonymous struct {
|
|
Hello string
|
|
}
|
|
|
|
func (c Car) Type() string {
|
|
return ""
|
|
}
|
|
|
|
func (c Car) Color() string {
|
|
return ""
|
|
}
|
|
|
|
func TestAutocompleteFormat(t *testing.T) {
|
|
testStruct := struct {
|
|
Name string
|
|
Age int
|
|
Car *Car
|
|
*Anonymous
|
|
}{
|
|
Anonymous: &Anonymous{},
|
|
}
|
|
|
|
testStruct.Car = &Car{}
|
|
testStruct.Car.Extras = map[string]string{"test": "1"}
|
|
|
|
tests := []struct {
|
|
name string
|
|
toComplete string
|
|
expected []string
|
|
}{
|
|
{
|
|
"empty completion",
|
|
"",
|
|
[]string{"json"},
|
|
},
|
|
{
|
|
"json completion",
|
|
"json",
|
|
[]string{"json"},
|
|
},
|
|
{
|
|
"invalid completion",
|
|
"blahblah",
|
|
nil,
|
|
},
|
|
{
|
|
"invalid completion",
|
|
"{{",
|
|
nil,
|
|
},
|
|
{
|
|
"invalid completion",
|
|
"{{ ",
|
|
nil,
|
|
},
|
|
{
|
|
"invalid completion",
|
|
"{{ ..",
|
|
nil,
|
|
},
|
|
{
|
|
"fist level struct field name",
|
|
"{{.",
|
|
[]string{"{{.Name}}", "{{.Age}}", "{{.Car.", "{{.Anonymous.", "{{.Hello}}"},
|
|
},
|
|
{
|
|
"fist level struct field name",
|
|
"{{ .",
|
|
[]string{"{{ .Name}}", "{{ .Age}}", "{{ .Car.", "{{ .Anonymous.", "{{ .Hello}}"},
|
|
},
|
|
{
|
|
"fist level struct field name",
|
|
"{{ .N",
|
|
[]string{"{{ .Name}}"},
|
|
},
|
|
{
|
|
"second level struct field name",
|
|
"{{ .Car.",
|
|
[]string{"{{ .Car.Brand}}", "{{ .Car.Stats.", "{{ .Car.Extras}}", "{{ .Car.Color}}", "{{ .Car.Type}}"},
|
|
},
|
|
{
|
|
"second level struct field name",
|
|
"{{ .Car.B",
|
|
[]string{"{{ .Car.Brand}}"},
|
|
},
|
|
{
|
|
"three level struct field name",
|
|
"{{ .Car.Stats.",
|
|
[]string{"{{ .Car.Stats.HP}}", "{{ .Car.Stats.Displacement}}"},
|
|
},
|
|
{
|
|
"three level struct field name",
|
|
"{{ .Car.Stats.D",
|
|
[]string{"{{ .Car.Stats.Displacement}}"},
|
|
},
|
|
{
|
|
"second level struct field name",
|
|
"{{ .Car.B",
|
|
[]string{"{{ .Car.Brand}}"},
|
|
},
|
|
{
|
|
"invalid field name",
|
|
"{{ .Ca.B",
|
|
nil,
|
|
},
|
|
{
|
|
"map key names don't work",
|
|
"{{ .Car.Extras.",
|
|
nil,
|
|
},
|
|
{
|
|
"two variables struct field name",
|
|
"{{ .Car.Brand }} {{ .Car.",
|
|
[]string{"{{ .Car.Brand }} {{ .Car.Brand}}", "{{ .Car.Brand }} {{ .Car.Stats.", "{{ .Car.Brand }} {{ .Car.Extras}}",
|
|
"{{ .Car.Brand }} {{ .Car.Color}}", "{{ .Car.Brand }} {{ .Car.Type}}"},
|
|
},
|
|
{
|
|
"only dot without variable",
|
|
".",
|
|
nil,
|
|
},
|
|
}
|
|
|
|
for _, test := range tests {
|
|
completion, directive := common.AutocompleteFormat(testStruct)(nil, nil, test.toComplete)
|
|
// directive should always be greater than ShellCompDirectiveNoFileComp
|
|
assert.GreaterOrEqual(t, directive, cobra.ShellCompDirectiveNoFileComp, "unexpected ShellCompDirective")
|
|
assert.Equal(t, test.expected, completion, test.name)
|
|
}
|
|
}
|