mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-10-18 11:57:32 +00:00
f5efef5043
The exec API accepts a ConsoleSize but it is dropped: the exec pseudo-terminal is created at its default size and only corrected afterwards by an asynchronous resize. A short-lived exec that reads its window size at startup (e.g. `stty size`) can therefore observe the wrong size, because the resize may arrive after the process has already read it. docker applies the size at creation. Carry the requested ConsoleSize through ExecConfig and into the exec OCI process spec (process.consoleSize) so the runtime sizes the terminal before the process starts, removing the race. The local and remote CLIs capture the caller's terminal size when -t is given and pass it through ExecOptions, matching the behavior of `podman run`. Re-enable the previously flaky `podman exec` case in the interactive system test, which this change makes deterministic. Signed-off-by: Shuai Yuan <shuaiyuanzju@gmail.com> |
||
|---|---|---|
| .. | ||
| auth.go | ||
| changes.go | ||
| containers.go | ||
| containers_archive.go | ||
| containers_attach.go | ||
| containers_create.go | ||
| containers_export.go | ||
| containers_logs.go | ||
| containers_pause.go | ||
| containers_prune.go | ||
| containers_restart.go | ||
| containers_start.go | ||
| containers_stats.go | ||
| containers_stats_freebsd.go | ||
| containers_stats_linux.go | ||
| containers_stop.go | ||
| containers_top.go | ||
| containers_unpause.go | ||
| events.go | ||
| exec.go | ||
| images.go | ||
| images_build.go | ||
| images_history.go | ||
| images_prune.go | ||
| images_push.go | ||
| images_remove.go | ||
| images_save.go | ||
| images_search.go | ||
| images_tag.go | ||
| info.go | ||
| networks.go | ||
| ping.go | ||
| resize.go | ||
| secrets.go | ||
| system.go | ||
| types.go | ||
| unsupported.go | ||
| version.go | ||
| volumes.go | ||