spiegel_podman/cmd/podman
Matthew Heon 4e2a0b5b9c Enable IPv6 port binding
Two areas needed tweaking to accomplish this: port parsing and
binding ports on the host.

Parsing is an obvious problem - we have to accomodate an IPv6
address enclosed by [] as well as a normal IPv4 address. It was
slightly complicated by the fact that we previously just counted
the number of colons in the whole port definition (a thousand
curses on whoever in the IPv6 standard body decided to reuse
colons for address separators), but did not end up being that
bad.

Libpod also (optionally) binds ports on the host to prevent their
reuse by host processes. This code was IPv4 only for TCP, and
bound to both for UDP (which I'm fairly certain is not correct,
and has been adjusted). This just needed protocols adjusted to
read "tcp4"/"tcp6" and "udp4"/"udp6" based on what we wanted to
bind to.

Fixes #5715

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-06-10 13:28:09 -04:00
..
common Enable IPv6 port binding 2020-06-10 13:28:09 -04:00
containers Fix Id->ID where possible for lint 2020-06-10 05:49:41 -04:00
generate Added new flags to 'podman generate systemd' to change the unit name prefix 2020-05-22 18:38:39 +02:00
healthcheck Fix errors found when comparing podman v1 --help versus V2 2020-05-04 14:16:34 -04:00
images Fixup issues found by golint 2020-06-10 05:49:41 -04:00
inspect enable inspect tests 2020-04-29 07:25:31 +02:00
manifest compat handlers: add X-Registry-Auth header support 2020-05-29 15:39:37 +02:00
networks Fixup issues found by golint 2020-06-10 05:49:41 -04:00
parse Enables port test 2020-05-06 16:06:41 -04:00
play compat handlers: add X-Registry-Auth header support 2020-05-29 15:39:37 +02:00
pods Fix Id->ID where possible for lint 2020-06-10 05:49:41 -04:00
registry Fixup issues found by golint 2020-06-10 05:49:41 -04:00
report Fixup issues found by golint 2020-06-10 05:49:41 -04:00
system Merge pull request #6537 from vrothberg/events-docs 2020-06-10 09:32:56 -04:00
utils And system prune feature for v2. 2020-05-01 13:57:16 -04:00
validate Fix Id->ID where possible for lint 2020-06-10 05:49:41 -04:00
volumes Fix Id->ID where possible for lint 2020-06-10 05:49:41 -04:00
auto-update.go auto-update: support authfiles 2020-05-12 10:20:48 +02:00
diff.go Fix Id->ID where possible for lint 2020-06-10 05:49:41 -04:00
inspect.go enable inspect tests 2020-04-29 07:25:31 +02:00
login.go Fix handling of overridden paths from database 2020-05-08 09:27:39 -04:00
logout.go Fix handling of overridden paths from database 2020-05-08 09:27:39 -04:00
main.go add {generate,play} kube 2020-05-06 17:08:22 +02:00
README.md [CI:DOCS] Bring README.md up to date 2020-05-01 11:22:39 -07:00
root.go Fixup issues found by golint 2020-06-10 05:49:41 -04:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/cmd/podman/validate"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/libpod/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())