mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-18 22:37:52 +00:00
51fbf3da9e
The linter ensures a common code style. - use switch/case instead of else if - use if instead of switch/case for single case statement - add space between comment and text - detect the use of defer with os.Exit() - use short form var += "..." instead of var = var + "..." - detect problems with append() ``` newSlice := append(orgSlice, val) ``` This could lead to nasty bugs because the orgSlice will be changed in place if it has enough capacity too hold the new elements. Thus we newSlice might not be a copy. Of course most of the changes are just cosmetic and do not cause any logic errors but I think it is a good idea to enforce a common style. This should help maintainability. Signed-off-by: Paul Holzinger <pholzing@redhat.com>
65 lines
1.8 KiB
Go
65 lines
1.8 KiB
Go
//go:build !remote
|
|
// +build !remote
|
|
|
|
package system
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
|
|
"github.com/containers/common/pkg/completion"
|
|
"github.com/containers/podman/v4/cmd/podman/registry"
|
|
"github.com/containers/podman/v4/cmd/podman/validate"
|
|
"github.com/containers/podman/v4/libpod/define"
|
|
"github.com/containers/podman/v4/pkg/domain/entities"
|
|
"github.com/containers/podman/v4/pkg/domain/infra"
|
|
"github.com/spf13/cobra"
|
|
)
|
|
|
|
var (
|
|
renumberDescription = `
|
|
podman system renumber
|
|
|
|
Migrate lock numbers to handle a change in maximum number of locks.
|
|
Mandatory after the number of locks in containers.conf is changed.
|
|
`
|
|
|
|
renumberCommand = &cobra.Command{
|
|
Annotations: map[string]string{registry.EngineMode: registry.ABIMode},
|
|
Use: "renumber",
|
|
Args: validate.NoArgs,
|
|
Short: "Migrate lock numbers",
|
|
Long: renumberDescription,
|
|
Run: renumber,
|
|
ValidArgsFunction: completion.AutocompleteNone,
|
|
}
|
|
)
|
|
|
|
func init() {
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Command: renumberCommand,
|
|
Parent: systemCmd,
|
|
})
|
|
}
|
|
func renumber(cmd *cobra.Command, args []string) {
|
|
// Shutdown all running engines, `renumber` will hijack all methods
|
|
registry.ContainerEngine().Shutdown(registry.Context())
|
|
registry.ImageEngine().Shutdown(registry.Context())
|
|
|
|
engine, err := infra.NewSystemEngine(entities.RenumberMode, registry.PodmanConfig())
|
|
if err != nil {
|
|
fmt.Println(err)
|
|
os.Exit(define.ExecErrorCodeGeneric)
|
|
}
|
|
defer engine.Shutdown(registry.Context())
|
|
|
|
err = engine.Renumber(registry.Context(), cmd.Flags(), registry.PodmanConfig())
|
|
if err != nil {
|
|
fmt.Println(err)
|
|
// FIXME change this to return the error like other commands
|
|
// defer will never run on os.Exit()
|
|
//nolint:gocritic
|
|
os.Exit(define.ExecErrorCodeGeneric)
|
|
}
|
|
os.Exit(0)
|
|
}
|