mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-05 08:25:40 +00:00
6f775c9091
The backstory for this is that runc 1.2 (opencontainers/runc#3967)
fixed a long-standing bug in our mount flag handling (a bug that crun
still has). Before runc 1.2, when dealing with locked mount flags that
user namespaced containers cannot clear, trying to explicitly clearing
locked flags (like rw clearing MS_RDONLY) would silently ignore the rw
flag in most cases and would result in a read-only mount. This is
obviously not what the user expects.
What runc 1.2 did is that it made it so that passing clearing flags
like rw would always result in an attempt to clear the flag (which was
not the case before), and would (in all cases) explicitly return an
error if we try to clear locking flags. (This also let us finally fix a
bunch of other long-standing issues with locked mount flags causing
seemingly spurious errors).
The problem is that podman sets rw on all mounts by default (even if
the user doesn't specify anything). This is actually a no-op in
runc 1.1 and crun because of a bug in how clearing flags were handled
(rw is the absence of MS_RDONLY but until runc 1.2 we didn't correctly
track clearing flags like that, meaning that rw would literally be
handled as if it were not set at all by users) but in runc 1.2 leads to
unfortunate breakages and a subtle change in behaviour (before, a ro
mount being bind-mounted into a container would also be ro -- though
due to the above bug even setting rw explicitly would result in ro in
most cases -- but with runc 1.2 the mount will always be rw even if
the user didn't explicitly request it which most users would find
surprising). By the way, this "always set rw" behaviour is a departure
from Docker and it is not necesssary.
Fixes: https://issues.redhat.com/browse/RHEL-152635,
https://issues.redhat.com/browse/RHEL-152631
Signed-off-by: rcmadhankumar <madhankumar.chellamuthu@suse.com>
(cherry picked from commit
|
||
|---|---|---|
| .. | ||
| annotations | ||
| api | ||
| auth | ||
| autoupdate | ||
| bindings | ||
| channel | ||
| checkpoint | ||
| copy | ||
| criu | ||
| ctime | ||
| domain | ||
| emulation | ||
| env | ||
| errorhandling | ||
| farm | ||
| fileserver | ||
| inspect | ||
| k8s.io | ||
| libartifact | ||
| lookup | ||
| machine | ||
| namespaces | ||
| parallel | ||
| ps | ||
| rctl | ||
| rootless | ||
| seccomp | ||
| selinux | ||
| signal | ||
| specgen | ||
| specgenutil | ||
| specgenutilexternal | ||
| systemd | ||
| terminal | ||
| timetype | ||
| trust | ||
| util | ||