spiegel_podman/libpod
Matthew Heon 407fba4942 Unconditionally remove conmon files before starting
We've been seeing a lot of issues (ref: #4061, but there are
others) where Podman hiccups on trying to start a container,
because some temporary files have been retained and Conmon will
not overwrite them.

If we're calling start() we can safely assume that we really want
those files gone so the container starts without error, so invoke
the cleanup routine. It's relatively cheap (four file removes) so
it shouldn't hurt us that much.

Also contains a small simplification to the removeConmonFiles
logic - we don't need to stat-then-remove when ignoring ENOENT is
fine.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2019-09-20 09:30:15 -04:00
..
common Set blob cache directory based on GraphDriver 2019-03-29 08:27:33 -04:00
define Fix exit code failure 2019-09-17 12:01:02 -04:00
driver removMergeDir from inspect result if not mounted 2019-08-13 15:13:20 -04:00
events performance fix for podman events with large journalds 2019-08-14 09:30:12 -05:00
image Do not prune images being used by a container 2019-09-10 13:30:50 -04:00
layers Initial checkin from CRI-O repo 2017-11-01 11:24:59 -04:00
lock trivial cleanups from golang 2019-07-03 15:41:33 -05:00
logs golangci-lint pass number 2 2019-07-11 09:13:06 -05:00
boltdb_state.go Volume lookup needs to include state to unmarshal into 2019-09-11 10:17:28 -04:00
boltdb_state_internal.go Add ability for volumes with options to mount/umount 2019-09-05 17:12:27 -04:00
boltdb_state_linux.go podman-remote inspect 2019-01-18 15:43:11 -06:00
boltdb_state_unsupported.go podman-remote inspect 2019-01-18 15:43:11 -06:00
common_test.go code cleanup 2019-07-08 09:18:11 -05:00
container.go Add support for launching containers without CGroups 2019-09-10 10:52:37 -04:00
container.log.go libpod removal from main (phase 2) 2019-06-27 07:56:24 -05:00
container_api.go Podman-remote run should wait for exit code 2019-09-12 16:20:01 -04:00
container_commit.go Fix commit --changes env=X=Y 2019-07-26 16:04:17 -07:00
container_graph.go generate systemd: support pods and geneartig files 2019-08-21 17:28:30 +02:00
container_graph_test.go generate systemd: support pods and geneartig files 2019-08-21 17:28:30 +02:00
container_inspect.go Add support for launching containers without CGroups 2019-09-10 10:52:37 -04:00
container_internal.go Unconditionally remove conmon files before starting 2019-09-20 09:30:15 -04:00
container_internal_linux.go linux: fix systemd with --cgroupns=private 2019-09-12 14:33:26 +02:00
container_internal_test.go Potentially breaking: Make hooks sort order locale-independent 2019-04-09 21:08:44 +02:00
container_internal_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
container_linux.go Do not fetch pod and ctr State on retrieval in Bolt 2018-07-31 14:19:50 +00:00
container_log_linux.go libpod removal from main (phase 2) 2019-06-27 07:56:24 -05:00
container_log_unsupported.go libpod removal from main (phase 2) 2019-06-27 07:56:24 -05:00
container_top_linux.go Add support for launching containers without CGroups 2019-09-10 10:52:37 -04:00
container_top_unsupported.go libpod removal from main (phase 2) 2019-06-27 07:56:24 -05:00
container_unsupported.go Do not fetch pod and ctr State on retrieval in Bolt 2018-07-31 14:19:50 +00:00
diff.go Add function to get a filtered tarstream diff 2019-07-11 14:43:34 +02:00
events.go get last container event 2019-07-07 08:54:20 -05:00
healthcheck.go Implement conmon exec 2019-07-22 15:57:23 -04:00
healthcheck_linux.go golangci-lint pass number 2 2019-07-11 09:13:06 -05:00
healthcheck_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
in_memory_state.go Add function for looking up volumes by partial name 2019-09-09 12:06:10 -04:00
info.go Return information about mount_program (fuse-overlayfs) 2019-09-06 07:32:42 -04:00
kube.go Add capability functionality to play kube 2019-08-01 15:47:45 -04:00
mounts_linux.go set root propagation based on volume properties 2018-11-26 13:55:02 +01:00
networking_linux.go networking: use --enable-sandbox if available 2019-09-16 16:42:11 +02:00
networking_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
oci.go Add support for launching containers without CGroups 2019-09-10 10:52:37 -04:00
oci_attach_linux.go exec: Register resize func a bit later 2019-09-12 16:14:30 -04:00
oci_attach_linux_cgo.go Implement conmon exec 2019-07-22 15:57:23 -04:00
oci_attach_linux_nocgo.go Implement conmon exec 2019-07-22 15:57:23 -04:00
oci_attach_unsupported.go Implement conmon exec 2019-07-22 15:57:23 -04:00
oci_internal_linux.go rootless: automatically create a systemd scope 2019-09-12 08:35:26 +02:00
oci_linux.go exec: fix --preserve-fds 2019-09-16 15:27:00 -04:00
oci_unsupported.go Implement conmon exec 2019-07-22 15:57:23 -04:00
options.go Add support for launching containers without CGroups 2019-09-10 10:52:37 -04:00
pod.go Allow customizing pod hostname 2019-08-18 03:48:40 +00:00
pod_api.go Report errors when trying to pause rootless containers 2019-09-13 08:29:46 -04:00
pod_internal.go remove libpod from main 2019-06-25 13:51:24 -05:00
pod_top_linux.go libpod removal from main (phase 2) 2019-06-27 07:56:24 -05:00
pod_top_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
runtime.go fix trivial type for event logger 2019-09-19 18:20:01 -05:00
runtime_cstorage.go Add further fields to StorageContainer 2019-09-11 10:53:21 -04:00
runtime_ctr.go Merge pull request #3581 from mheon/no_cgroups 2019-09-11 00:58:46 +02:00
runtime_img.go make rmi messages more compatible with docker 2019-08-08 20:05:55 -05:00
runtime_img_test.go switch projectatomic to containers 2018-08-16 17:12:36 +00:00
runtime_migrate.go code cleanup 2019-07-08 09:18:11 -05:00
runtime_migrate_unsupported.go system: migrate stops the pause process 2019-05-17 20:48:25 +02:00
runtime_pod.go remove libpod from main 2019-06-25 13:51:24 -05:00
runtime_pod_infra_linux.go Merge pull request #3836 from chenzhiwei/hostname 2019-08-19 13:33:15 +02:00
runtime_pod_linux.go Fix error message on podman stats on cgroups v1 rootless environments 2019-08-19 07:41:50 -04:00
runtime_pod_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
runtime_renumber.go Re-add locks to volumes. 2019-08-28 11:35:00 -04:00
runtime_volume.go Add function for looking up volumes by partial name 2019-09-09 12:06:10 -04:00
runtime_volume_linux.go Correctly report errors on unmounting SHM 2019-09-05 17:12:27 -04:00
runtime_volume_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
state.go Add function for looking up volumes by partial name 2019-09-09 12:06:10 -04:00
state_test.go libpod removal from main (phase 2) 2019-06-27 07:56:24 -05:00
stats.go Add support for launching containers without CGroups 2019-09-10 10:52:37 -04:00
stats_config.go changes to allow for darwin compilation 2018-06-29 20:44:09 +00:00
stats_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
storage.go remove libpod from main 2019-06-25 13:51:24 -05:00
util.go Return information about mount_program (fuse-overlayfs) 2019-09-06 07:32:42 -04:00
util_linux.go pkg/cgroups: use DBUS session when rootless 2019-08-14 15:46:07 +02:00
util_test.go Stage3 Image Library 2018-03-14 20:21:31 +00:00
util_unsupported.go remove libpod from main 2019-06-25 13:51:24 -05:00
volume.go When first mounting any named volume, copy up 2019-09-09 17:17:39 -04:00
volume_inspect.go Fix typos 2019-08-02 15:30:31 -04:00
volume_internal.go When first mounting any named volume, copy up 2019-09-09 17:17:39 -04:00
volume_internal_linux.go Correctly report errors on unmounting SHM 2019-09-05 17:12:27 -04:00
volume_internal_unsupported.go Add ability for volumes with options to mount/umount 2019-09-05 17:12:27 -04:00