spiegel_podman/cmd/podman
Matthew Heon 32f0c8f624 Do not use image CMD if user gave ENTRYPOINT
This matches Docker behavior, and seems to make sense - the CMD
may have been specific to the original entrypoint and probably
does not make sense if it was changed.

While we're in here, greatly simplify the logic for populating
the SpecGen's Command. We create the full command when making the
OCI spec, so the client should not be doing any more than setting
it to the Command the user passed in, and completely ignoring
ENTRYPOINT.

Fixes #7115

Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-08-20 12:16:53 -04:00
..
common Do not use image CMD if user gave ENTRYPOINT 2020-08-20 12:16:53 -04:00
containers fix pod creation with "new:" syntax 2020-08-11 13:53:23 +02:00
generate Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
healthcheck Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
images podman save use named pipe 2020-08-20 12:16:52 -04:00
inspect Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
manifest Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
networks replace the html/template package with text/template 2020-07-31 11:37:22 -04:00
parse version/info: format: allow more json variants 2020-07-22 14:42:53 -04:00
play Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
pods Fix container and pod create commands for remote create 2020-07-22 14:39:41 -04:00
registry add newline to output in error message 2020-07-31 11:39:17 -04:00
report move go module to v2 2020-07-06 15:52:17 +02:00
system Fix podman service --valink timeout 2020-08-11 13:53:23 +02:00
utils move go module to v2 2020-07-06 15:52:17 +02:00
validate Fix imports to ensure v2 is used with libpod 2020-07-06 14:44:40 -04:00
volumes replace the html/template package with text/template 2020-07-31 11:37:22 -04:00
auto-update.go auto-update: clarify systemd-unit requirements 2020-07-06 13:08:56 -04:00
diff.go Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
early_init_linux.go abi: set default umask and rlimits 2020-07-22 14:05:20 -04:00
early_init_unsupported.go abi: set default umask and rlimits 2020-07-22 14:05:20 -04:00
inspect.go Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
login.go move go module to v2 2020-07-06 15:52:17 +02:00
logout.go move go module to v2 2020-07-06 15:52:17 +02:00
main.go Fixes --remote flag issues 2020-07-06 14:14:53 -04:00
README.md [CI:DOCS] Bring README.md up to date 2020-05-01 11:22:39 -07:00
root.go abi: set default umask and rlimits 2020-07-22 14:05:20 -04:00
syslog_linux.go Fix build on OS X 2020-05-20 18:24:56 -04:00
syslog_unsupported.go Fix build on OS X 2020-05-20 18:24:56 -04:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/cmd/podman/validate"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/libpod/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())