mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-08 09:55:42 +00:00
30e7cbccc1
This commit addresses three intertwined bugs to fix an issue when using Gitlab runner on Podman. The three bug fixes are not split into separate commits as tests won't pass otherwise; avoidable noise when bisecting future issues. 1) Podman conflated states: even when asking to wait for the `exited` state, Podman returned as soon as a container transitioned to `stopped`. The issues surfaced in Gitlab tests to fail [1] as `conmon`'s buffers have not (yet) been emptied when attaching to a container right after a wait. The race window was extremely narrow, and I only managed to reproduce with the Gitlab runner [1] unit tests. 2) The clearer separation between `exited` and `stopped` revealed a race condition predating the changes. If a container is configured for autoremoval (e.g., via `run --rm`), the "run" process competes with the "cleanup" process running in the background. The window of the race condition was sufficiently large that the "cleanup" process has already removed the container and storage before the "run" process could read the exit code and hence waited indefinitely. Address the exit-code race condition by recording exit codes in the main libpod database. Exit codes can now be read from a database. When waiting for a container to exit, Podman first waits for the container to transition to `exited` and will then query the database for its exit code. Outdated exit codes are pruned during cleanup (i.e., non-performance critical) and when refreshing the database after a reboot. An exit code is considered outdated when it is older than 5 minutes. While the race condition predates this change, the waiting process has apparently always been fast enough in catching the exit code due to issue 1): `exited` and `stopped` were conflated. The waiting process hence caught the exit code after the container transitioned to `stopped` but before it `exited` and got removed. 3) With 1) and 2), Podman is now waiting for a container to properly transition to the `exited` state. Some tests did not pass after 1) and 2) which revealed the third bug: `conmon` was executed with its working directory pointing to the OCI runtime bundle of the container. The changed working directory broke resolving relative paths in the "cleanup" process. The "cleanup" process error'ed before actually cleaning up the container and waiting "main" process ran indefinitely - or until hitting a timeout. Fix the issue by executing `conmon` with the same working directory as Podman. Note that fixing 3) *may* address a number of issues we have seen in the past where for *some* reason cleanup processes did not fire. [1] https://gitlab.com/gitlab-org/gitlab-runner/-/issues/27119#note_970712864 Signed-off-by: Valentin Rothberg <vrothberg@redhat.com> [MH: Minor reword of commit message] Signed-off-by: Matthew Heon <mheon@redhat.com> |
||
|---|---|---|
| .. | ||
| common | ||
| define | ||
| driver | ||
| events | ||
| layers | ||
| linkmode | ||
| lock | ||
| logs | ||
| plugin | ||
| shutdown | ||
| boltdb_state.go | ||
| boltdb_state_internal.go | ||
| boltdb_state_linux.go | ||
| common_test.go | ||
| container.go | ||
| container_api.go | ||
| container_commit.go | ||
| container_config.go | ||
| container_copy_linux.go | ||
| container_exec.go | ||
| container_graph.go | ||
| container_graph_test.go | ||
| container_inspect.go | ||
| container_internal.go | ||
| container_internal_linux.go | ||
| container_internal_linux_test.go | ||
| container_internal_test.go | ||
| container_linux.go | ||
| container_log.go | ||
| container_log_linux.go | ||
| container_log_unsupported.go | ||
| container_path_resolution.go | ||
| container_stat_linux.go | ||
| container_top_linux.go | ||
| container_validate.go | ||
| diff.go | ||
| doc.go | ||
| events.go | ||
| healthcheck.go | ||
| healthcheck_linux.go | ||
| info.go | ||
| info_test.go | ||
| kube.go | ||
| mounts_linux.go | ||
| networking_linux.go | ||
| networking_linux_test.go | ||
| networking_machine.go | ||
| networking_slirp4netns.go | ||
| oci.go | ||
| oci_conmon.go | ||
| oci_conmon_attach_linux.go | ||
| oci_conmon_exec_linux.go | ||
| oci_conmon_linux.go | ||
| oci_missing.go | ||
| oci_util.go | ||
| options.go | ||
| pod.go | ||
| pod_api.go | ||
| pod_internal.go | ||
| pod_status.go | ||
| pod_top_linux.go | ||
| reset.go | ||
| runtime.go | ||
| runtime_cstorage.go | ||
| runtime_ctr.go | ||
| runtime_img.go | ||
| runtime_migrate.go | ||
| runtime_pod.go | ||
| runtime_pod_linux.go | ||
| runtime_renumber.go | ||
| runtime_volume.go | ||
| runtime_volume_linux.go | ||
| runtime_worker.go | ||
| service.go | ||
| state.go | ||
| state_test.go | ||
| stats.go | ||
| storage.go | ||
| util.go | ||
| util_linux.go | ||
| util_linux_test.go | ||
| util_test.go | ||
| volume.go | ||
| volume_inspect.go | ||
| volume_internal.go | ||
| volume_internal_linux.go | ||