mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-10-31 02:07:42 +00:00
5df883e87d
One of the main uses of context.Context is to provide cancellation for go-routines, including API requests. While all user-facing bindings already used a context parameter, it was only used to pass the client information around. This commit changes the internal DoRequest wrapper to take an additional context argument, and pass that to the http request. Previously, the context was derived from context.Background(), which made it impossible to cancel once started. All the convenience wrappers already supported the context parameter, so the only user facing change is that cancelling those context now works as one would expect. Signed-off-by: Moritz "WanzenBug" Wanzenböck <moritz@wanzenbug.xyz>
46 lines
1.3 KiB
Go
46 lines
1.3 KiB
Go
package images
|
|
|
|
import (
|
|
"context"
|
|
"net/http"
|
|
|
|
"github.com/containers/podman/v3/pkg/api/handlers/types"
|
|
"github.com/containers/podman/v3/pkg/bindings"
|
|
"github.com/containers/podman/v3/pkg/domain/entities"
|
|
"github.com/containers/podman/v3/pkg/errorhandling"
|
|
)
|
|
|
|
// Remove removes one or more images from the local storage. Use optional force option to remove an
|
|
// image, even if it's used by containers.
|
|
func Remove(ctx context.Context, images []string, options *RemoveOptions) (*entities.ImageRemoveReport, []error) {
|
|
if options == nil {
|
|
options = new(RemoveOptions)
|
|
}
|
|
// FIXME - bindings tests are missing for this endpoint. Once the CI is
|
|
// re-enabled for bindings, we need to add them. At the time of writing,
|
|
// the tests don't compile.
|
|
var report types.LibpodImagesRemoveReport
|
|
conn, err := bindings.GetClient(ctx)
|
|
if err != nil {
|
|
return nil, []error{err}
|
|
}
|
|
|
|
params, err := options.ToParams()
|
|
if err != nil {
|
|
return nil, nil
|
|
}
|
|
for _, image := range images {
|
|
params.Add("images", image)
|
|
}
|
|
response, err := conn.DoRequest(ctx, nil, http.MethodDelete, "/images/remove", params, nil)
|
|
if err != nil {
|
|
return nil, []error{err}
|
|
}
|
|
defer response.Body.Close()
|
|
|
|
if err := response.Process(&report); err != nil {
|
|
return nil, []error{err}
|
|
}
|
|
|
|
return &report.ImageRemoveReport, errorhandling.StringsToErrors(report.Errors)
|
|
}
|