mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-11 11:25:45 +00:00
52371057cd
in cases where commands require input and we dont provide it, we often would segv. This can be attributed in many cases to the subcommand not picked up the cobra Args attribute or neither had them. Signed-off-by: baude <bbaude@redhat.com>
121 lines
4.2 KiB
Go
121 lines
4.2 KiB
Go
package containers
|
|
|
|
import (
|
|
"bufio"
|
|
"os"
|
|
|
|
"github.com/containers/libpod/cmd/podman/registry"
|
|
"github.com/containers/libpod/pkg/domain/entities"
|
|
envLib "github.com/containers/libpod/pkg/env"
|
|
"github.com/pkg/errors"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
var (
|
|
execDescription = `Execute the specified command inside a running container.
|
|
`
|
|
execCommand = &cobra.Command{
|
|
Use: "exec [flags] CONTAINER [COMMAND [ARG...]]",
|
|
Short: "Run a process in a running container",
|
|
Long: execDescription,
|
|
RunE: exec,
|
|
DisableFlagsInUseLine: true,
|
|
Example: `podman exec -it ctrID ls
|
|
podman exec -it -w /tmp myCtr pwd
|
|
podman exec --user root ctrID ls`,
|
|
}
|
|
|
|
containerExecCommand = &cobra.Command{
|
|
Use: execCommand.Use,
|
|
Short: execCommand.Short,
|
|
Long: execCommand.Long,
|
|
RunE: execCommand.RunE,
|
|
DisableFlagsInUseLine: true,
|
|
Example: `podman container exec -it ctrID ls
|
|
podman container exec -it -w /tmp myCtr pwd
|
|
podman container exec --user root ctrID ls`,
|
|
}
|
|
)
|
|
|
|
var (
|
|
envInput, envFile []string
|
|
execOpts entities.ExecOptions
|
|
)
|
|
|
|
func execFlags(flags *pflag.FlagSet) {
|
|
flags.SetInterspersed(false)
|
|
flags.StringVar(&execOpts.DetachKeys, "detach-keys", containerConfig.DetachKeys(), "Select the key sequence for detaching a container. Format is a single character [a-Z] or ctrl-<value> where <value> is one of: a-z, @, ^, [, , or _")
|
|
flags.StringArrayVarP(&envInput, "env", "e", []string{}, "Set environment variables")
|
|
flags.StringSliceVar(&envFile, "env-file", []string{}, "Read in a file of environment variables")
|
|
flags.BoolVarP(&execOpts.Interactive, "interactive", "i", false, "Keep STDIN open even if not attached")
|
|
flags.BoolVarP(&execOpts.Latest, "latest", "l", false, "Act on the latest container podman is aware of")
|
|
flags.BoolVar(&execOpts.Privileged, "privileged", false, "Give the process extended Linux capabilities inside the container. The default is false")
|
|
flags.BoolVarP(&execOpts.Tty, "tty", "t", false, "Allocate a pseudo-TTY. The default is false")
|
|
flags.StringVarP(&execOpts.User, "user", "u", "", "Sets the username or UID used and optionally the groupname or GID for the specified command")
|
|
flags.UintVar(&execOpts.PreserveFDs, "preserve-fds", 0, "Pass N additional file descriptors to the container")
|
|
flags.StringVarP(&execOpts.WorkDir, "workdir", "w", "", "Working directory inside the container")
|
|
if registry.IsRemote() {
|
|
_ = flags.MarkHidden("latest")
|
|
_ = flags.MarkHidden("preserve-fds")
|
|
}
|
|
}
|
|
|
|
func init() {
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Mode: []entities.EngineMode{entities.ABIMode},
|
|
Command: execCommand,
|
|
})
|
|
flags := execCommand.Flags()
|
|
execFlags(flags)
|
|
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Mode: []entities.EngineMode{entities.ABIMode},
|
|
Command: containerExecCommand,
|
|
Parent: containerCmd,
|
|
})
|
|
|
|
containerExecFlags := containerExecCommand.Flags()
|
|
execFlags(containerExecFlags)
|
|
}
|
|
|
|
func exec(cmd *cobra.Command, args []string) error {
|
|
var nameOrId string
|
|
|
|
if len(args) == 0 && !execOpts.Latest {
|
|
return errors.New("exec requires the name or ID of a container or the --latest flag")
|
|
}
|
|
execOpts.Cmd = args
|
|
if !execOpts.Latest {
|
|
execOpts.Cmd = args[1:]
|
|
nameOrId = args[0]
|
|
}
|
|
// Validate given environment variables
|
|
execOpts.Envs = make(map[string]string)
|
|
for _, f := range envFile {
|
|
fileEnv, err := envLib.ParseFile(f)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
execOpts.Envs = envLib.Join(execOpts.Envs, fileEnv)
|
|
}
|
|
|
|
cliEnv, err := envLib.ParseSlice(envInput)
|
|
if err != nil {
|
|
return errors.Wrap(err, "error parsing environment variables")
|
|
}
|
|
|
|
execOpts.Envs = envLib.Join(execOpts.Envs, cliEnv)
|
|
execOpts.Streams.OutputStream = os.Stdout
|
|
execOpts.Streams.ErrorStream = os.Stderr
|
|
if execOpts.Interactive {
|
|
execOpts.Streams.InputStream = bufio.NewReader(os.Stdin)
|
|
execOpts.Streams.AttachInput = true
|
|
}
|
|
execOpts.Streams.AttachOutput = true
|
|
execOpts.Streams.AttachError = true
|
|
|
|
exitCode, err := registry.ContainerEngine().ContainerExec(registry.GetContext(), nameOrId, execOpts)
|
|
registry.SetExitCode(exitCode)
|
|
return err
|
|
}
|