spiegel_podman/cmd/podman
Matthew Heon 6b9e9610d8 Enable cleanup processes for detached exec
The cleanup command creation logic is made public as part of this
and wired such that we can call it both within SpecGen (to make
container exit commands) and from the ABI detached exec handler.
Exit commands are presently only used for detached exec, but
theoretically could be turned on for all exec sessions if we
wanted (I'm declining to do this because of potential overhead).

I also forgot to copy the exit command from the exec config into
the ExecOptions struct used by the OCI runtime, so it was not
being added.

There are also two significant bugfixes for exec in here. One is
for updating the status of running exec sessions - this was
always failing as I had coded it to remove the exit file *before*
reading it, instead of after (oops). The second was that removing
a running exec session would always fail because I inverted the
check to see if it was running.

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-05-20 16:11:05 -04:00
..
common rootless: do not set pids limits with cgroupfs 2020-05-12 11:00:54 +02:00
containers Enable cleanup processes for detached exec 2020-05-20 16:11:05 -04:00
generate add {generate,play} kube 2020-05-06 17:08:22 +02:00
healthcheck Fix errors found when comparing podman v1 --help versus V2 2020-05-04 14:16:34 -04:00
images v2podman image sign 2020-05-11 09:18:56 -05:00
inspect enable inspect tests 2020-04-29 07:25:31 +02:00
manifest set binding tests to required 2020-05-08 09:05:37 -05:00
networks enable podman v2 networking for remote client 2020-05-12 13:23:43 -05:00
parse Enables port test 2020-05-06 16:06:41 -04:00
play add {generate,play} kube 2020-05-06 17:08:22 +02:00
pods Fix podman pod create --infra=false 2020-05-08 13:25:41 -04:00
registry default to tunnel without ABISupport tag 2020-05-08 11:09:48 -04:00
report Provide a json variable pointing to a configured json API 2020-04-21 07:56:10 -07:00
system fix bug --format {{json.}} of events 2020-05-14 14:28:51 -04:00
utils And system prune feature for v2. 2020-05-01 13:57:16 -04:00
validate V2 enable ps tests 2020-04-29 15:51:37 -07:00
volumes And system prune feature for v2. 2020-05-01 13:57:16 -04:00
auto-update.go auto-update: support authfiles 2020-05-12 10:20:48 +02:00
diff.go V2 enable ps tests 2020-04-29 15:51:37 -07:00
inspect.go enable inspect tests 2020-04-29 07:25:31 +02:00
login.go Fix handling of overridden paths from database 2020-05-08 09:27:39 -04:00
logout.go Fix handling of overridden paths from database 2020-05-08 09:27:39 -04:00
main.go add {generate,play} kube 2020-05-06 17:08:22 +02:00
README.md [CI:DOCS] Bring README.md up to date 2020-05-01 11:22:39 -07:00
root.go default to tunnel without ABISupport tag 2020-05-08 11:09:48 -04:00

Podman CLI

The following is an example of how to add a new primary command (manifest) and a sub-command (inspect) to the Podman CLI. This is example code, the production code has additional error checking and the business logic provided.

See items below for details on building, installing, contributing to Podman:

Adding a new command podman manifest

$ mkdir -p $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/manifest.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/cmd/podman/validate"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman _manifests_
    manifestCmd = &cobra.Command{
        Use:               "manifest",
        Short:             "Manage manifests",
        Args:              cobra.ExactArgs(1),
        Long:              "Manage manifests",
        Example:           "podman manifest IMAGE",
        TraverseChildren:  true,
        RunE:              validate.SubCommandExists, // Report error if there is no sub command given
    }
)
func init() {
    // Subscribe command to podman
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: manifestCmd,
    })
}

To "wire" in the manifest command, edit the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/main.go to add:

package main

import	_ "github.com/containers/libpod/cmd/podman/manifests"

Adding a new sub command podman manifests list

Create the file $GOPATH/src/github.com/containers/libpod/cmd/podmanV2/manifests/inspect.go

package manifests

import (
    "github.com/containers/libpod/cmd/podman/registry"
    "github.com/containers/libpod/pkg/domain/entities"
    "github.com/spf13/cobra"
)

var (
    // podman manifests _inspect_
    inspectCmd = &cobra.Command{
        Use:     "inspect IMAGE",
        Short:   "Display manifest from image",
        Long:    "Displays the low-level information on a manifest identified by image name or ID",
        RunE:    inspect,
        Annotations: map[string]string{
            // Add this annotation if this command cannot be run rootless
            // registry.ParentNSRequired: "",
        },
        Example: "podman manifest inspect DEADBEEF",
    }
)

func init() {
    // Subscribe inspect sub command to manifest command
    registry.Commands = append(registry.Commands, registry.CliCommand{
        // _podman manifest inspect_ will support both ABIMode and TunnelMode
        Mode:    []entities.EngineMode{entities.ABIMode, entities.TunnelMode},
        // The definition for this command
        Command: inspectCmd,
        // The parent command to proceed this command on the CLI
        Parent:  manifestCmd,
    })

    // This is where you would configure the cobra flags using inspectCmd.Flags()
}

// Business logic: cmd is inspectCmd, args is the positional arguments from os.Args
func inspect(cmd *cobra.Command, args []string) error {
    // Business logic using registry.ImageEngine()
    // Do not pull from libpod directly use the domain objects and types
    return nil
}

Helper functions

The complete set can be found in the validate package, here are some examples:

  • cobra.Command{ Args: validate.NoArgs } used when the command does not accept errors
  • cobra.Command{ Args: validate.IdOrLatestArgs } used to ensure either a list of ids given or the --latest flag
  • cobra.Command{ RunE: validate.SubCommandExists } used to validate a subcommand given to a command
  • validate.ChoiceValue used to create a pflag.Value that validate user input against a provided slice of values. For example:
    flags := cobraCommand.Flags()
    created := validate.ChoiceValue(&opts.Sort, "command", "created", "id", "image", "names", "runningfor", "size", "status")
    flags.Var(created, "sort", "Sort output by: "+created.Choices())