spiegel_podman/libpod
Valentin Rothberg 142db01942 events endpoint: fix panic and race condition
Fix a potential panic in the events endpoint when parsing the filters
parameter.  Values of the filters map might be empty, so we need to
account for that instead of uncondtitionally accessing the first item.

Also apply a similar for race conditions as done in commit f4a2d25c0f:

	Fix a race that could cause read errors to be masked.  Masking
	such errors is likely to report red herrings since users don't
	see that reading failed for some reasons but that a given event
	could not be found.

Another race was the handler closing event channel, which could lead to
two kinds of panics: double close, send to close channel.  The backend
takes care of that.  However, make sure that the backend stops working
in case the context has been cancelled.

Fixes: #6899
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-07-21 16:56:26 +02:00
..
common Set blob cache directory based on GraphDriver 2019-03-29 08:27:33 -04:00
define Print errors from individual containers in pods 2020-07-06 13:10:13 -04:00
driver removMergeDir from inspect result if not mounted 2019-08-13 15:13:20 -04:00
events events endpoint: fix panic and race condition 2020-07-21 16:56:26 +02:00
filters move go module to v2 2020-07-06 15:52:17 +02:00
image search: allow wildcards 2020-07-15 11:42:04 +02:00
layers Initial checkin from CRI-O repo 2017-11-01 11:24:59 -04:00
linkmode Add podman static build 2020-05-11 13:11:07 +02:00
lock move go module to v2 2020-07-06 15:52:17 +02:00
logs move go module to v2 2020-07-06 15:52:17 +02:00
boltdb_state.go move go module to v2 2020-07-06 15:52:17 +02:00
boltdb_state_internal.go move go module to v2 2020-07-06 15:52:17 +02:00
boltdb_state_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
boltdb_state_unsupported.go podman-remote inspect 2019-01-18 15:43:11 -06:00
common_test.go move go module to v2 2020-07-06 15:52:17 +02:00
container.go move go module to v2 2020-07-06 15:52:17 +02:00
container_api.go move go module to v2 2020-07-06 15:52:17 +02:00
container_commit.go move go module to v2 2020-07-06 15:52:17 +02:00
container_exec.go move go module to v2 2020-07-06 15:52:17 +02:00
container_graph.go move go module to v2 2020-07-06 15:52:17 +02:00
container_graph_test.go move go module to v2 2020-07-06 15:52:17 +02:00
container_inspect.go move go module to v2 2020-07-06 15:52:17 +02:00
container_internal.go container: move volume chown after spec generation 2020-07-06 13:31:21 -04:00
container_internal_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
container_internal_test.go vendor: update seccomp/containers-golang to v0.4.1 2020-05-21 16:16:09 +02:00
container_internal_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
container_linux.go Do not fetch pod and ctr State on retrieval in Bolt 2018-07-31 14:19:50 +00:00
container_log.go move go module to v2 2020-07-06 15:52:17 +02:00
container_log_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
container_log_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
container_top_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
container_top_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
container_unsupported.go Do not fetch pod and ctr State on retrieval in Bolt 2018-07-31 14:19:50 +00:00
container_validate.go move go module to v2 2020-07-06 15:52:17 +02:00
diff.go move go module to v2 2020-07-06 15:52:17 +02:00
events.go fix race condition in libpod.GetEvents(...) 2020-07-07 17:29:14 +02:00
healthcheck.go move go module to v2 2020-07-06 15:52:17 +02:00
healthcheck_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
healthcheck_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
in_memory_state.go move go module to v2 2020-07-06 15:52:17 +02:00
info.go move go module to v2 2020-07-06 15:52:17 +02:00
kube.go move go module to v2 2020-07-06 15:52:17 +02:00
mounts_linux.go set root propagation based on volume properties 2018-11-26 13:55:02 +01:00
networking_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
networking_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
oci.go move go module to v2 2020-07-06 15:52:17 +02:00
oci_attach_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
oci_attach_linux_cgo.go Implement conmon exec 2019-07-22 15:57:23 -04:00
oci_attach_linux_nocgo.go Implement conmon exec 2019-07-22 15:57:23 -04:00
oci_attach_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
oci_conmon_exec_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
oci_conmon_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
oci_conmon_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
oci_missing.go move go module to v2 2020-07-06 15:52:17 +02:00
oci_util.go move go module to v2 2020-07-06 15:52:17 +02:00
options.go container: move volume chown after spec generation 2020-07-06 13:31:21 -04:00
pod.go move go module to v2 2020-07-06 15:52:17 +02:00
pod_api.go Print errors from individual containers in pods 2020-07-06 13:10:13 -04:00
pod_internal.go move go module to v2 2020-07-06 15:52:17 +02:00
pod_status.go move go module to v2 2020-07-06 15:52:17 +02:00
pod_top_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
pod_top_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
reset.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_cstorage.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_ctr.go container: move volume chown after spec generation 2020-07-06 13:31:21 -04:00
runtime_img.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_img_test.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_migrate.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_migrate_unsupported.go Add podman system reset command 2019-11-29 05:34:52 -05:00
runtime_pod.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_pod_infra_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_pod_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_pod_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_renumber.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_volume.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_volume_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
runtime_volume_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
state.go Add support for containers.conf 2020-03-27 14:36:03 -04:00
state_test.go move go module to v2 2020-07-06 15:52:17 +02:00
stats.go move go module to v2 2020-07-06 15:52:17 +02:00
stats_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
storage.go move go module to v2 2020-07-06 15:52:17 +02:00
util.go move go module to v2 2020-07-06 15:52:17 +02:00
util_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
util_test.go move go module to v2 2020-07-06 15:52:17 +02:00
util_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00
volume.go container: move volume chown after spec generation 2020-07-06 13:31:21 -04:00
volume_inspect.go container: move volume chown after spec generation 2020-07-06 13:31:21 -04:00
volume_internal.go move go module to v2 2020-07-06 15:52:17 +02:00
volume_internal_linux.go move go module to v2 2020-07-06 15:52:17 +02:00
volume_internal_unsupported.go move go module to v2 2020-07-06 15:52:17 +02:00