mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-09-12 18:47:50 +00:00
f2c365c6f6
When we remove with --force we do not return a error if the input does not exists, however if we get more than on input we must try to remove all and not just NOP out and not remove anything just because one arg did not exists. Also make the code simpler for commands that do have the --ignore option and just make --force imply --ignore which reduces the ugly error handling. Fixes #21529 Signed-off-by: Paul Holzinger <pholzing@redhat.com>
95 lines
2.8 KiB
Go
95 lines
2.8 KiB
Go
package images
|
|
|
|
import (
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/containers/podman/v5/cmd/podman/common"
|
|
"github.com/containers/podman/v5/cmd/podman/registry"
|
|
"github.com/containers/podman/v5/pkg/domain/entities"
|
|
"github.com/containers/podman/v5/pkg/errorhandling"
|
|
"github.com/spf13/cobra"
|
|
"github.com/spf13/pflag"
|
|
)
|
|
|
|
var (
|
|
rmDescription = "Removes one or more previously pulled or locally created images."
|
|
rmCmd = &cobra.Command{
|
|
Use: "rm [options] IMAGE [IMAGE...]",
|
|
Short: "Remove one or more images from local storage",
|
|
Long: rmDescription,
|
|
RunE: rm,
|
|
ValidArgsFunction: common.AutocompleteImages,
|
|
Example: `podman image rm imageID
|
|
podman image rm --force alpine
|
|
podman image rm c4dfb1609ee2 93fd78260bd1 c0ed59d05ff7`,
|
|
}
|
|
|
|
rmiCmd = &cobra.Command{
|
|
Use: "rmi [options] IMAGE [IMAGE...]",
|
|
Args: rmCmd.Args,
|
|
Short: rmCmd.Short,
|
|
Long: rmCmd.Long,
|
|
RunE: rmCmd.RunE,
|
|
ValidArgsFunction: rmCmd.ValidArgsFunction,
|
|
Example: `podman rmi imageID
|
|
podman rmi --force alpine
|
|
podman rmi c4dfb1609ee2 93fd78260bd1 c0ed59d05ff7`,
|
|
}
|
|
|
|
imageOpts = entities.ImageRemoveOptions{}
|
|
)
|
|
|
|
func init() {
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Command: rmCmd,
|
|
Parent: imageCmd,
|
|
})
|
|
|
|
imageRemoveFlagSet(rmCmd.Flags())
|
|
|
|
registry.Commands = append(registry.Commands, registry.CliCommand{
|
|
Command: rmiCmd,
|
|
})
|
|
imageRemoveFlagSet(rmiCmd.Flags())
|
|
}
|
|
|
|
func imageRemoveFlagSet(flags *pflag.FlagSet) {
|
|
flags.BoolVarP(&imageOpts.All, "all", "a", false, "Remove all images")
|
|
flags.BoolVarP(&imageOpts.Ignore, "ignore", "i", false, "Ignore errors if a specified image does not exist")
|
|
flags.BoolVarP(&imageOpts.Force, "force", "f", false, "Force Removal of the image")
|
|
flags.BoolVar(&imageOpts.NoPrune, "no-prune", false, "Do not remove dangling images")
|
|
}
|
|
|
|
func rm(cmd *cobra.Command, args []string) error {
|
|
if len(args) < 1 && !imageOpts.All {
|
|
return errors.New("image name or ID must be specified")
|
|
}
|
|
if len(args) > 0 && imageOpts.All {
|
|
return errors.New("when using the --all switch, you may not pass any images names or IDs")
|
|
}
|
|
|
|
if imageOpts.Force {
|
|
imageOpts.Ignore = true
|
|
}
|
|
|
|
// Note: certain image-removal errors are non-fatal. Hence, the report
|
|
// might be set even if err != nil.
|
|
report, rmErrors := registry.ImageEngine().Remove(registry.GetContext(), args, imageOpts)
|
|
if report != nil {
|
|
for _, u := range report.Untagged {
|
|
fmt.Println("Untagged: " + u)
|
|
}
|
|
for _, d := range report.Deleted {
|
|
// Make sure an image was deleted (and not just untagged); else print it
|
|
if len(d) > 0 {
|
|
fmt.Println("Deleted: " + d)
|
|
}
|
|
}
|
|
}
|
|
if len(rmErrors) > 0 {
|
|
registry.SetExitCode(report.ExitCode)
|
|
}
|
|
|
|
return errorhandling.JoinErrors(rmErrors)
|
|
}
|