mirror of
https://github.com/podman-container-tools/podman.git
synced 2026-08-05 00:15:44 +00:00
4586dc2c60
NormalizeVolumePruneFilters discarded every query filter when the "all" pseudo-filter was set, deleting label/label!/until before they reached the volume filter generator. As a result `podman volume prune --all --filter label=foo` ignored the label and pruned every unused volume. "all" only widens the prune scope from anonymous-only to all unused volumes; it is orthogonal to the label filters, which must still select which of those volumes are removed. Drop only the "all" key and keep the remaining filters so they continue to apply. NormalizeVolumePruneFilters is shared by the local (abi), remote (libpod API), and Docker-compat prune paths, so all three were affected. Signed-off-by: Shuai Yuan <shuaiyuanzju@gmail.com>
237 lines
9.6 KiB
Go
237 lines
9.6 KiB
Go
//go:build linux || freebsd
|
|
|
|
package integration
|
|
|
|
import (
|
|
. "github.com/onsi/ginkgo/v2"
|
|
. "github.com/onsi/gomega"
|
|
. "go.podman.io/podman/v6/test/utils"
|
|
)
|
|
|
|
var _ = Describe("Podman volume prune", func() {
|
|
AfterEach(func() {
|
|
podmanTest.CleanupVolume()
|
|
})
|
|
|
|
It("podman prune volume -a removes all unused volumes", func() {
|
|
podmanTest.PodmanExitCleanly("volume", "create")
|
|
podmanTest.PodmanExitCleanly("volume", "create")
|
|
podmanTest.PodmanExitCleanly("create", "-v", "myvol:/myvol", ALPINE, "ls")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(4))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "-a", "--force")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
})
|
|
|
|
It("podman volume prune", func() {
|
|
session := podmanTest.PodmanExitCleanly("create", "-v", "/anon", ALPINE, "top")
|
|
podmanTest.PodmanExitCleanly("rm", session.OutputToString())
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "create", "named_vol")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(3))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--force")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
Expect(session.OutputToString()).To(ContainSubstring("named_vol"))
|
|
})
|
|
|
|
It("podman volume prune --all removes all unused volumes", func() {
|
|
podmanTest.PodmanExitCleanly("volume", "create", "prune_all_test")
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--all", "--force")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(1))
|
|
})
|
|
|
|
It("podman volume prune --filter all=true removes all unused volumes", func() {
|
|
podmanTest.PodmanExitCleanly("volume", "create", "prune_filter_all_test")
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--filter", "all=true", "--force")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(1))
|
|
})
|
|
|
|
It("podman volume prune --filter all=true does not crash without --force", func() {
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--filter", "all=true")
|
|
})
|
|
|
|
It("podman prune volume --filter until", func() {
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "label1=value1", "myvol1")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--force", "--filter", "until=50")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--force", "--filter", "until=5000000000")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(1))
|
|
})
|
|
|
|
It("podman prune volume --filter", func() {
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "label1=value1", "myvol1")
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "sharedlabel1=slv1", "myvol2")
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "sharedlabel1=slv2", "myvol3")
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "sharedlabel1", "myvol4")
|
|
podmanTest.PodmanExitCleanly("create", "-v", "myvol5:/myvol5", ALPINE, "ls")
|
|
podmanTest.PodmanExitCleanly("create", "-v", "myvol6:/myvol6", ALPINE, "ls")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(7))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--force", "--filter", "label=label1=value1")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(6))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--force", "--filter", "label=sharedlabel1=slv1")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(5))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--force", "--filter", "label=sharedlabel1")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(3))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "testlabel", "myvol7")
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--force", "--filter", "label!=testlabel")
|
|
})
|
|
|
|
It("podman volume prune --all keeps the label filter", func() {
|
|
// Regression: the "all" flag must not discard a label/label! filter.
|
|
// With "--all --filter label!=keep" only unlabeled unused volumes are
|
|
// pruned; the labeled one survives. Before the fix, "all" cleared the
|
|
// filter and both volumes were removed.
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "keep=yes", "keepvol")
|
|
podmanTest.PodmanExitCleanly("volume", "create", "dropvol")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls", "-q")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "--all", "--force", "--filter", "label!=keep")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls", "-q")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(1))
|
|
Expect(session.OutputToString()).To(Equal("keepvol"))
|
|
})
|
|
|
|
It("podman system prune --volume", func() {
|
|
useCustomNetworkDir(podmanTest, tempdir)
|
|
podmanTest.PodmanExitCleanly("volume", "create")
|
|
podmanTest.PodmanExitCleanly("volume", "create")
|
|
podmanTest.PodmanExitCleanly("create", "-v", "myvol:/myvol", ALPINE, "ls")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(4))
|
|
|
|
podmanTest.PodmanExitCleanly("system", "prune", "--force", "--volumes")
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(1))
|
|
})
|
|
|
|
It("podman volume prune --filter since/after", func() {
|
|
vol1 := "vol1"
|
|
vol2 := "vol2"
|
|
vol3 := "vol3"
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol1)
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol2)
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol3)
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "prune", "-f", "--filter", "since="+vol1)
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "ls", "-q")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(1))
|
|
Expect(session.OutputToStringArray()[0]).To(Equal(vol1))
|
|
})
|
|
|
|
It("podman volume prune --all --dry-run", func() {
|
|
vol1 := "vol1"
|
|
vol2 := "vol2"
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol1)
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol2)
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "prune", "--all", "--dry-run")
|
|
Expect(session.OutputToString()).To(ContainSubstring("Volumes that would be pruned:"))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol1))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol2))
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls", "-q")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol1))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol2))
|
|
})
|
|
|
|
It("podman volume prune --filter --dry-run", func() {
|
|
vol1 := "vol1"
|
|
vol2 := "vol2"
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "dryrun=true", vol1)
|
|
podmanTest.PodmanExitCleanly("volume", "create", "--label", "dryrun=false", vol2)
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "prune", "--dry-run", "--filter", "label=dryrun=true")
|
|
Expect(session.OutputToString()).To(ContainSubstring("Volumes that would be pruned:"))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol1))
|
|
Expect(session.OutputToString()).ToNot(ContainSubstring(vol2))
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls", "-q")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol1))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol2))
|
|
})
|
|
|
|
It("podman volume prune --dry-run only shows anonymous volumes", func() {
|
|
vol1 := "vol1"
|
|
anon_vol := podmanTest.PodmanExitCleanly("volume", "create").OutputToString()
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol1)
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "prune", "--dry-run")
|
|
Expect(session.OutputToString()).To(ContainSubstring("Volumes that would be pruned:"))
|
|
Expect(session.OutputToString()).To(ContainSubstring(anon_vol))
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls", "-q")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol1))
|
|
Expect(session.OutputToString()).To(ContainSubstring(anon_vol))
|
|
})
|
|
|
|
It("podman volume prune --all --dry-run excludes volumes in use", func() {
|
|
vol1 := "vol1"
|
|
vol2 := "vol2"
|
|
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol1)
|
|
podmanTest.PodmanExitCleanly("volume", "create", vol2)
|
|
podmanTest.PodmanExitCleanly("create", "-v", "vol2:/data", ALPINE, "ls")
|
|
|
|
session := podmanTest.PodmanExitCleanly("volume", "prune", "--all", "--dry-run")
|
|
Expect(session.OutputToString()).To(ContainSubstring("Volumes that would be pruned:"))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol1))
|
|
Expect(session.OutputToString()).ToNot(ContainSubstring(vol2))
|
|
|
|
session = podmanTest.PodmanExitCleanly("volume", "ls", "-q")
|
|
Expect(session.OutputToStringArray()).To(HaveLen(2))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol1))
|
|
Expect(session.OutputToString()).To(ContainSubstring(vol2))
|
|
})
|
|
|
|
It("podman volume prune --force --dry-run fails", func() {
|
|
session := podmanTest.Podman([]string{"volume", "prune", "--force", "--dry-run"})
|
|
session.WaitWithDefaultTimeout()
|
|
Expect(session).Should(ExitWithError(125, "--force and --dry-run cannot be used together"))
|
|
})
|
|
})
|