Speed up the Makefile by removing variable references from the release
targets. Now, the variables will only be (lazily) evaluated when they
are actually needed and not for each invocation of the Makefile which
has it down considerably.
Fixes: #4829
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Add a .PHONY line over each target instead of mixing this notation with
a separate but incomplete single list.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Move the systemd-buildtag check into the `bin/podman` target.
No need to execute the check for all invocations of the
Makefile.
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
For whatever reason, this required variable is not set when `make` is
doing validation within automation. Fix this by establishing the
value based on data provided from the CI system. Since this data
is specific to automation executing against a PR, limit this specific
job to not run during testing of branches (post-merge). This is safe
since we can assume the PR would not have been merged, if the basics
checked during gating did not pass.
Signed-off-by: Chris Evich <cevich@redhat.com>
In Podman 1.6.3, we added support for anonymous volumes - fixing
our old, broken support for named volumes that were created with
containers. Unfortunately, this reused the database field we used
for the old implementation, and toggled volume removal on for
`podman run --rm` - so now, we were removing *named* volumes
created with older versions of Podman.
We can't modify these old volumes in the DB, so the next-safest
thing to do is swap to a new field to indicate volumes should be
removed. Problem: Volumes created with 1.6.3 and up until this
lands, even anonymous volumes, will not be removed. However, this
is safer than removing too many volumes, as we were doing before.
Fixes#5009
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
Get the layer's size whether it relates to the first history entry or
not. This fixes issues where the first entry would always be shown
to be of size 0.
Fixes: #4916
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
Running the `varlink_generate` make target on non-Linux machines is not
supported, so restrict it to Linux only.
Fixes: #4814
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
if one of the cni conf files is badly formatted or cannot be loaded, we now display the error as well as the filename.
Fixes: #2909
Signed-off-by: Brent Baude <bbaude@redhat.com>
On F31 CI tests, we have uncovered several failing tests as rootless that need to be fixed. For the interim, we are going to disable those tests. Issue #5006 has been created to track and complete this.
Signed-off-by: Brent Baude <bbaude@redhat.com>
When a container specification has a pull policy, we should honor it when recreating the pods/containers from yaml. furthermore, ini kube, if a tag is :latest, then the always pull policy is automatically instituted.
Fixes: #4880
Signed-off-by: Brent Baude <bbaude@redhat.com>
Apparently, a tilde is currently rendered as a single space, making
a mess of command examples that use it, so use $HOME instead.
https://github.com/mattermost/mattermost-server/issues/8228
Signed-off-by: Robert P. J. Day <rpjday@crashcourse.ca>
Add binding for networks and begin documentation for binding methods for godoc. Also, add major functions to their own subpackages so reduce the amount of of method confusion. So instead of: bindings.ListImages(), we now do a [bindings].images.List().
Also, the connection is passed to each binding method via a context to allow for future growth.
Lastly, add first set of tests. There are a couple of things to work out for rootless tests yet.
Signed-off-by: Brent Baude <bbaude@redhat.com>
add a quick note in the rootless.md about usage of --net=host as rootless and subsequent podman execs.
Fixes: #4473
Signed-off-by: Brent Baude <bbaude@redhat.com>
We no longer wish to hide the --arch-override from the cli on pulls. we now expose it. docs updated. tests already exist.
Fixes: #4849
Signed-off-by: Brent Baude <bbaude@redhat.com>
