Commit graph

25966 commits

Author SHA1 Message Date
flouthoc
f985699460 volume: move validating volume dest from client to server.
[NO TESTS NEEDED]

Signed-off-by: flouthoc <flouthoc.git@gmail.com>
2021-08-16 16:36:39 +05:30
Paul Holzinger
91e21bed48
rootful: unset XDG_RUNTIME_DIR
Depending how the user logs in to the root account, XDG_RUNTIME_DIR is
set to /run/user/0 or it is unset. For conmon we already set it always
to an empty string. The inconsistency is causing issues for the dnsname
plugin. To fix it unset XDG_RUNTIME_DIR for the podman process.

[NO TESTS NEEDED]

Fixes #10806
Fixes #10745

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-08-16 11:47:20 +02:00
openshift-ci[bot]
a38d7530db
Merge pull request #11228 from mlegenovic/main
Fixed healthcheck default values when container created via compat API
2021-08-16 09:35:58 +00:00
Paul Holzinger
2a8c414488
Fix rootless cni dns without systemd stub resolver
When a host uses systemd-resolved but not the resolved stub resolver the
following symlinks are created: `/etc/resolv.conf` ->
`/run/systemd/resolve/stub-resolv.conf` -> `/run/systemd/resolve/resolv.conf`.
Because the code uses filepath.EvalSymlinks we put the new resolv.conf
to `/run/systemd/resolve/resolv.conf` but the `/run/systemd/resolve/stub-resolv.conf`
link does not exists in the mount ns.
To fix this we will walk the symlinks manually until we reach the first
one under `/run` and use this for the resolv.conf file destination.

This fixes a regression which was introduced in e73d482990.

Fixes #11222

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-08-16 11:30:11 +02:00
openshift-ci[bot]
5592ac9e23
Merge pull request #11219 from baude/oneshottoonce
rename oneshot initcontainers to once
2021-08-15 11:02:36 +00:00
Milivoje Legenovic
257d5e8a73 Fixed healthcheck default values when container created via compat API
Fixes #11225

Signed-off-by: Milivoje Legenovic <m.legenovic@gmail.com>
2021-08-14 13:10:28 +02:00
xatier
d997564342
Add space trimming check in ValidateSysctls
This is to catch invalid sysctl configs with extra spacing.

See
https://github.com/containers/common/issues/723#issuecomment-897395506

Signed-off-by: xatier <xatierlike@gmail.com>
2021-08-13 15:24:06 -05:00
Brent Baude
bef26f2582 rename oneshot initcontainers to once
after the init containers pr merged, it was suggested to use `once`
instead of `oneshot` containers as it is more aligned with other
terminiology used similarily.

[NO TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2021-08-12 12:57:15 -05:00
openshift-ci[bot]
94886d4aba
Merge pull request #11206 from baude/gvproxynewpath
Set gvproxy path to /usr/libexec/podman/gvproxy
2021-08-12 15:39:51 +00:00
Brent Baude
9fc9465630 Set gvproxy path to /usr/libexec/podman/gvproxy
We have reverted the previous patches to look for the gvproxy binary in
/usr/lib/podman and have again decided to use /usr/libexec/podman

[NO TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2021-08-12 09:11:09 -05:00
openshift-ci[bot]
de043a5a02
Merge pull request #11203 from rhatdan/codespell
Run codespell to fix spelling
2021-08-12 07:22:48 +00:00
openshift-ci[bot]
25ff04dcbe
Merge pull request #11167 from jwhonce/issues/11012
For compatibility, ignore Content-Type
2021-08-12 01:45:47 +00:00
openshift-ci[bot]
d594046410
Merge pull request #11190 from cevich/docs_update
[CI:DOCS] Fix multi-arch image docs
2021-08-11 21:10:29 +00:00
Jhon Honce
5a32946d61 For compatibility, ignore Content-Type
Endpoint /build logs an info entry when a client uses the wrong
Content-Type for build payload. Given Content-Type is ignored and
assumed to be "application/x-tar".

Endpoint /libpod/build will fail unless "application/x-tar" or
"application/tar" is given for Content-Type. "application/tar" will
be logged as an info entry.

Fixes #11012

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2021-08-11 13:50:51 -07:00
Daniel J Walsh
404488a087
Run codespell to fix spelling
[NO TESTS NEEDED] Just fixing spelling.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-08-11 16:41:45 -04:00
openshift-ci[bot]
7e5a9fdbc0
Merge pull request #11164 from cevich/enhance_priv_dev_test
Enhance priv. dev. check
2021-08-11 19:41:25 +00:00
Brent Baude
643178c1ec Revert "Use static path for gvproxy"
This reverts commit 4acc1d6850.

[NO TESTS NEEDED]

Signed-off-by: Brent Baude <bbaude@redhat.com>
2021-08-11 14:39:00 -05:00
Chris Evich
73a755eecb
Fix device tests using ls test files
The `ls` command is not intended for this purpose and may behave in
unexpected ways, leading to false positive or negative results.  Update
the tests to use the purpose built `test` command instead.

Also added several *TODO* comments for possible future testing
enhancements.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-08-11 13:07:00 -04:00
Chris Evich
d0e3b3c3a9
Enhance priv. dev. check
Update test to confirm the negative-case, proving the `--privileged`
"option is required" for this character device to be present in a
container (including rootless).

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-08-11 13:07:00 -04:00
Chris Evich
cfbbc38a5b
Workaround host availability of /dev/kvm
This test has been failing for a long time but nobody noticed because CI
doesn't have the device node (nested-VM support was disabled).  After
having enabled nested VM support, tests fail due to some unknown
special-handling of this device.

Fix both problems by removing the `skip()` and switching to a more generic
device which is only present when `--privileged` is used.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-08-11 13:07:00 -04:00
Ashley Cui
2e3ba9cd99 Change connection error to be helpful for machine users
If a podman-remote connection fails, remind the user to check their
linux system and podman machine vm

Signed-off-by: Ashley Cui <acui@redhat.com>
2021-08-11 09:07:24 -04:00
openshift-ci[bot]
1968fdc874
Merge pull request #11173 from jmguzik/pod-ps-until-filter
Add until filter to podman pod ps
2021-08-11 08:38:20 +00:00
openshift-ci[bot]
99e7ea51c7
Merge pull request #11153 from cdoern/scp
Added autocompletion for images and system connections for podman image SCP
2021-08-11 07:51:20 +00:00
Jakub Guzik
ed30ae4a8a Add until filter to podman pod ps
This commit adds additional until filter to podman pod ps (ls/list).
Additionally, it also adds descriptions for podman pod ps filters available
via http api.

Signed-off-by: Jakub Guzik <jakubmguzik@gmail.com>
2021-08-10 22:10:40 +02:00
Chris Evich
800a65fb25
[CI:DOCS] Fix multi-arch image docs
The automation workflow was altered in recent history to build images
daily, even if the podman version didn't change.  This was is necessary
so that any updates/security vulnerabilities in ancillary packages are
incorporated quickly.  However, documentation was never updated to
reflect this change.  This commit puts the two in sync.

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-08-10 16:06:09 -04:00
Daniel J Walsh
8b14cd84ce
Merge pull request #11160 from kpcyrd/repro-builds
Reproducible Builds: trim embedded cgo paths
2021-08-10 14:47:50 -04:00
openshift-ci[bot]
9e9174ebc5
Merge pull request #11179 from containers/dependabot/go_modules/github.com/opencontainers/selinux-1.8.4
Bump github.com/opencontainers/selinux from 1.8.3 to 1.8.4
2021-08-10 17:29:29 +00:00
dependabot[bot]
4e4c4b62fd
Bump github.com/opencontainers/selinux from 1.8.3 to 1.8.4
Bumps [github.com/opencontainers/selinux](https://github.com/opencontainers/selinux) from 1.8.3 to 1.8.4.
- [Release notes](https://github.com/opencontainers/selinux/releases)
- [Commits](https://github.com/opencontainers/selinux/compare/v1.8.3...v1.8.4)

---
updated-dependencies:
- dependency-name: github.com/opencontainers/selinux
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-10 15:01:34 +00:00
openshift-ci[bot]
859ffb40ae
Merge pull request #11178 from containers/dependabot/go_modules/github.com/containers/storage-1.34.0
Bump github.com/containers/storage from 1.33.1 to 1.34.0
2021-08-10 14:51:29 +00:00
openshift-ci[bot]
904e0f20e1
Merge pull request #11177 from Luap99/source-ip
[CI:DOCS] Document source ip for the rootlesskit port handler
2021-08-10 14:34:30 +00:00
Paul Holzinger
af46a64a8a
Document source ip for the rootlesskit port handler
Also add some missing options to podman pod create.

Fixes #10884

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-08-10 15:38:37 +02:00
dependabot[bot]
f7de8bc809
Bump github.com/containers/storage from 1.33.1 to 1.34.0
Bumps [github.com/containers/storage](https://github.com/containers/storage) from 1.33.1 to 1.34.0.
- [Release notes](https://github.com/containers/storage/releases)
- [Changelog](https://github.com/containers/storage/blob/main/docs/containers-storage-changes.md)
- [Commits](https://github.com/containers/storage/compare/v1.33.1...v1.34.0)

---
updated-dependencies:
- dependency-name: github.com/containers/storage
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-10 13:00:34 +00:00
openshift-ci[bot]
e136ad485c
Merge pull request #10589 from umohnani8/pod-userns
Add support for pod inside of user namespace.
2021-08-10 12:55:52 +00:00
Daniel J Walsh
6f61e22991
Merge pull request #11166 from cevich/skip_cgroup_parent_test
Skip cgroup-parent test due to frequent flakes
2021-08-10 08:48:54 -04:00
Daniel J Walsh
b9db2eb302
Merge pull request #11176 from Luap99/skip-flake
skip flaking auto-update test
2021-08-10 08:45:21 -04:00
Paul Holzinger
8b9b925e78
skip flaking auto-update test
This test flakes on almost every PR, so skip it for now until
someone can fix it, see #11175.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-08-10 11:06:38 +02:00
Chris Evich
27443660ce
Enable docker-py compat. testing w/ ignored result
Significant bitrot results in almost immediate test failure.  This
commit adds only the very basic, bare-minimum needed to get them
started.

***TESTING RESULTS ARE IGNORED***

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-08-09 17:32:55 -04:00
openshift-ci[bot]
6513adda18
Merge pull request #11134 from rhatdan/buildx
Alias build to buildx, so it won't fail
2021-08-09 20:09:16 +00:00
Daniel J Walsh
221b1add74 Add support for pod inside of user namespace.
Add the --userns flag to podman pod create and keep
track of the userns setting that pod was created with
so that all containers created within the pod will inherit
that userns setting.

Specifically we need to be able to launch a pod with
--userns=keep-id

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
Signed-off-by: Urvashi Mohnani <umohnani@redhat.com>
2021-08-09 15:17:22 -04:00
cdoern
12ac4198ca Libpod images pull changes
Added quiet param to docs to limit stream output. Formatted JSON.

fixes #10612

Signed-off-by: cdoern <cbdoer23@g.holycross.edu>
Signed-off-by: cdoern <cdoern@redhat.com>
2021-08-09 14:17:08 -04:00
kpcyrd
e7b7c90bae
Reproducible Builds: trim embedded cgo paths
Signed-off-by: kpcyrd <git@rxv.cc>
2021-08-09 20:10:18 +02:00
Daniel J Walsh
170fb25729
Alias build to buildx, so it won't fail
Add hidden --load and --progress flag as well.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2021-08-09 13:05:49 -04:00
openshift-ci[bot]
431707c720
Merge pull request #11161 from Luap99/slirp-info
podman info show correct slirp4netns path
2021-08-09 16:59:23 +00:00
Chris Evich
bb96da9f1d
Skip cgroup-parent test due to frequent flakes
Ref: https://github.com/containers/podman/issues/11165

Signed-off-by: Chris Evich <cevich@redhat.com>
2021-08-09 11:44:49 -04:00
cdoern
a4bdc67c45 Added autocompletion for images and system connections
[NO TESTS NEEDED] image scp should autocomplete images and system connections since the args can
be either. Made a new function, common.AutocompleteScp

Signed-off-by: cdoern <cdoern@redhat.com>
2021-08-09 09:21:47 -04:00
Paul Holzinger
1adeb2b70f
podman info show correct slirp4netns path
The slirp4netns path can be set in the config file or with
--network-cmd-path. Podman info should read the version information
correctly and not use PATH in this case. Also show the slirp4netns
version information to root users.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2021-08-09 12:59:28 +02:00
openshift-ci[bot]
04ab2b1661
Merge pull request #11137 from edsantiago/helpfulerer
[CI:DOCS] tests-expect-exit: include source line numbers
2021-08-06 14:56:44 +00:00
openshift-ci[bot]
9853b14719
Merge pull request #11151 from containers/dependabot/go_modules/github.com/onsi/gomega-1.15.0
Bump github.com/onsi/gomega from 1.14.0 to 1.15.0
2021-08-06 14:22:43 +00:00
openshift-ci[bot]
8409817733
Merge pull request #11074 from vrothberg/auto-update-rollback
auto-update: simple rollback
2021-08-06 12:26:31 +00:00
dependabot[bot]
79e4baf4ca
Bump github.com/onsi/gomega from 1.14.0 to 1.15.0
Bumps [github.com/onsi/gomega](https://github.com/onsi/gomega) from 1.14.0 to 1.15.0.
- [Release notes](https://github.com/onsi/gomega/releases)
- [Changelog](https://github.com/onsi/gomega/blob/master/CHANGELOG.md)
- [Commits](https://github.com/onsi/gomega/compare/v1.14.0...v1.15.0)

---
updated-dependencies:
- dependency-name: github.com/onsi/gomega
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-06 12:21:04 +00:00