Commit graph

25966 commits

Author SHA1 Message Date
OpenShift Merge Robot
2a6a80ef74
Merge pull request #17714 from containers/dependabot/go_modules/test/tools/golang.org/x/tools-0.7.0
build(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /test/tools
2023-03-08 16:11:46 +01:00
OpenShift Merge Robot
c0ef542213
Merge pull request #17706 from adrianreber/2023-03-07-unwrap
Update checkpointctl v0.1.0
2023-03-08 16:05:55 +01:00
dependabot[bot]
829e910cde
build(deps): bump golang.org/x/tools from 0.6.0 to 0.7.0 in /test/tools
Bumps [golang.org/x/tools](https://github.com/golang/tools) from 0.6.0 to 0.7.0.
- [Release notes](https://github.com/golang/tools/releases)
- [Commits](https://github.com/golang/tools/compare/v0.6.0...v0.7.0)

---
updated-dependencies:
- dependency-name: golang.org/x/tools
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-08 13:02:30 +00:00
Stefano Brivio
cc7a1e6148 CI: Switch to c20230307t192532z-f37f36d12 images
They include Fedora package passt-0^20230227.gc538ee8-1.fc37 and
passt-0.0~git20230227.c538ee8-1 for Debian, so that we can re-enable
the "Local Forwarder, IPv4" test for pasta(1).

Signed-off-by: Stefano Brivio <sbrivio@redhat.com>
2023-03-08 13:42:34 +01:00
OpenShift Merge Robot
f7ac9fd5d6
Merge pull request #17700 from cevich/parallel_system
Cirrus: Run system & integration tests in parallel
2023-03-07 23:35:19 +01:00
Chris Evich
799c201776
Cirrus: Run system & integration tests in parallel
Given that flakes inevitably occur as testing grows wider, position the
system tests in parallel with the integration tests as much as possible.
The thinking here is, flaking sooner is better than later.  This is
because it provides an earlier opportunity for developers to re-run
tasks.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-03-07 14:29:31 -05:00
Adrian Reber
c03cb57183
Update checkpointctl v0.1.0
With a minor fix during error unwrapping.

[NO NEW TESTS NEEDED]

Signed-off-by: Adrian Reber <areber@redhat.com>
2023-03-07 18:28:39 +00:00
OpenShift Merge Robot
45e27766e6
Merge pull request #17698 from containers/dependabot/go_modules/golang.org/x/net-0.8.0
build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0
2023-03-07 11:26:41 +01:00
OpenShift Merge Robot
971a87f0ab
Merge pull request #17691 from restitux/main
Quadlet: add support for setting --ip and --ip6
2023-03-07 11:19:02 +01:00
restitux
cb3cda55f2 Quadlet: add support for setting --ip and --ip6
Signed-off-by: restitux <restitux@ohea.xyz>
2023-03-06 18:36:41 -07:00
dependabot[bot]
af7a759e9d
build(deps): bump golang.org/x/net from 0.7.0 to 0.8.0
Bumps [golang.org/x/net](https://github.com/golang/net) from 0.7.0 to 0.8.0.
- [Release notes](https://github.com/golang/net/releases)
- [Commits](https://github.com/golang/net/compare/v0.7.0...v0.8.0)

---
updated-dependencies:
- dependency-name: golang.org/x/net
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-07 01:34:11 +00:00
OpenShift Merge Robot
b6b19bdfc0
Merge pull request #17699 from containers/dependabot/go_modules/golang.org/x/sys-0.6.0
build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0
2023-03-07 02:32:35 +01:00
OpenShift Merge Robot
72fbbd5598
Merge pull request #17695 from dfr/freebsd-cleanup
libpod: avoid nil pointer dereference in (*Container).Cleanup
2023-03-06 17:11:03 +01:00
dependabot[bot]
5d039ce222
build(deps): bump golang.org/x/sys from 0.5.0 to 0.6.0
Bumps [golang.org/x/sys](https://github.com/golang/sys) from 0.5.0 to 0.6.0.
- [Release notes](https://github.com/golang/sys/releases)
- [Commits](https://github.com/golang/sys/compare/v0.5.0...v0.6.0)

---
updated-dependencies:
- dependency-name: golang.org/x/sys
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
2023-03-06 13:00:25 +00:00
Doug Rabson
34ff27b813 libpod: avoid nil pointer dereference in (*Container).Cleanup
On FreeBSD, c.config.Spec.Linux is not populated - in this case, we can
assume that the container is not using a pid namespace.

[NO NEW TESTS NEEDED]

Signed-off-by: Doug Rabson <dfr@rabson.org>
2023-03-06 11:51:42 +00:00
OpenShift Merge Robot
8b424dcbe2
Merge pull request #17683 from TomSweeneyRedHat/dev/tsweeney/lockdoc
[CI:DOCS] Add image not found info to troubleshooting
2023-03-03 21:01:21 +01:00
OpenShift Merge Robot
f79a12972c
Merge pull request #17686 from n1hility/fix-restore
Fix package restore of shadow-utils on Windows
2023-03-03 19:45:18 +01:00
tomsweeneyredhat
25dd4d653e [CI:DOCS] Add image not found info to troubleshooting
Addresses: https://bugzilla.redhat.com/show_bug.cgi?id=2139191

We have a timing issue when doing a build or pull of an image and
a second process is removing them at the same time.  This is not
a window we're going to close now, so I'm adding a note to the
troubleshooting guide to document it.

[NO NEW TESTS NEEDED]
Signed-off-by: tomsweeneyredhat <tsweeney@redhat.com>
2023-03-03 11:22:57 -05:00
OpenShift Merge Robot
76642d5ad3
Merge pull request #17684 from giuseppe/version-no-userns
cmd: do not require userns for "version"
2023-03-03 16:56:05 +01:00
OpenShift Merge Robot
3f0f558609
Merge pull request #17677 from vyasgun/pr/system-default-connection
fix: update the default machine value when the previously set default machine is deleted
2023-03-03 14:50:12 +01:00
Giuseppe Scrivano
0498ce3a56
cmd: do not require userns for "version"
Closes: https://github.com/containers/podman/issues/17657

[NO NEW TESTS NEEDED]

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-03-03 14:27:54 +01:00
Giuseppe Scrivano
2860d55c97
cmd: drop special handling for "scp"
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-03-03 14:27:54 +01:00
Giuseppe Scrivano
da04469f06
cmd: clarify meaning of ParentNSRequired
there are no commands that are not supported by rootless mode, but
some commands require to run in the user namespace.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2023-03-03 14:27:54 +01:00
OpenShift Merge Robot
0625c85ef3
Merge pull request #17678 from vrothberg/db-backend
sqlite: add a hidden --db-backend flag
2023-03-03 13:56:37 +01:00
Jason T. Greene
0ab4b26147 Fix package restore
Signed-off-by: Jason T. Greene <jason.greene@redhat.com>
2023-03-02 20:53:38 -06:00
OpenShift Merge Robot
d4b221589a
Merge pull request #17620 from cevich/disable_version_check
[CI:DOCS] Fix docs/version-check always requesting updates
2023-03-03 02:16:12 +01:00
Chris Evich
0d219486f7
[CI:DOCS] Fix docs/version-check always requesting updates
As suggested by @edsantiago, the complex script and direct-link in the
docs are adding little value while increasing the CI maintenance burden.
Simply retire the script and strip the direct (versioned) links from the
docs.

Signed-off-by: Chris Evich <cevich@redhat.com>
2023-03-02 14:18:20 -05:00
OpenShift Merge Robot
ce67bbffa9
Merge pull request #17661 from xordspar0/chrony-makestep
podman machine: Adjust Chrony makestep config
2023-03-02 14:39:53 +01:00
Valentin Rothberg
e77f370f86 sqlite: add a hidden --db-backend flag
Add a hidden flag to set the database backend and plumb it into
podman-info.  Further add a system test to make sure the flag and the
info output are working properly.

Note that the test may need to be changed once we settled on how
to test the sqlite backend in CI.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-02 13:43:11 +01:00
OpenShift Merge Robot
96d439913e
Merge pull request #17658 from vrothberg/sqlite
sqlite updates
2023-03-02 07:55:04 +01:00
vyasgun
cca65db01d fix: update the default machine value when the previously set default machine is deleted
[NO NEW TESTS NEEDED]

Fixes: https://github.com/containers/podman/issues/16483
Signed-off-by: vyasgun <vyasgun20@gmail.com>
2023-03-02 11:06:56 +05:30
Jordan Christiansen
9ac0d4f1a6 podman machine: Adjust Chrony makestep config
This allows Chrony to update the system time when it has drifted far
from NTP time. By default Chrony only makes slight adjustments, but in
the case where a user's laptop lid has been shut for a while and then
the machine is resumed, the VM system time could be hours or days behind
real time, and it may never catch up if Chrony only makes slight
changes.

[NO NEW TESTS NEEDED]

Fixes #11541

Signed-off-by: Jordan Christiansen <xordspar0@gmail.com>
2023-03-01 19:42:56 -06:00
OpenShift Merge Robot
8457bb5542
Merge pull request #16717 from umohnani8/detach
play kube: Add --wait option
2023-03-01 16:46:54 +01:00
Valentin Rothberg
2c67ff5d40 sqlite: add container short ID to network aliases
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
38acab832d sqlite: remove dead code
Found by golangci-lint.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
2342d1a314 sqlite: addContainer: add named volume only once
There's a unique constraint in the table, so we shouldn't add the same
volume more than once to the same container.

[NO NEW TESTS NEEDED] as it fixes an existing one.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
86d12520e9 sqlite: implement RewriteVolumeConfig
[NO NEW TESTS NEEDED]

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
df88f546b6 sqlite: LookupVolume: fix partial name match
A partial name match is tricky as we want it to be fast but also make
sure there's only one partial match iff there's no full one.

[NO NEW TESTS NEEDED] as it fixes a system test.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
01359457c4 sqlite: LookupVolume: wrap error
Wrap the error with the message expexted by the system tests.

[NO NEW TESTS NEEDED]

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
69ff04f736 sqlite: fix type rewriting container config
It's `UPDATE $NAME` not `UPDATE TABLE $NAME`.

[NO NEW TESTS NEEDED]

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
e87014e444 sqlite: return correct error on pod-name conflict
I wasn't able to find a way to get error-checks working with the sqlite3
library with the time at hand.

[NO NEW TESTS NEEDED]

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
Valentin Rothberg
84b5c6c713 sqlite: RewritePodConfig: update error message
Use the same error message as the boltdb backend.

[NO NEW TESTS NEEDED]

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 16:09:51 +01:00
OpenShift Merge Robot
4f4665cbda
Merge pull request #17673 from vrothberg/fix-17607
auto-update test: wait for service to be ready
2023-03-01 16:09:14 +01:00
OpenShift Merge Robot
86a0e44ccd
Merge pull request #17659 from cevich/fix_bud_git_config
Cirrus: Fix git config permission denied
2023-03-01 15:15:35 +01:00
OpenShift Merge Robot
69ba3548f0
Merge pull request #17653 from Luap99/fix-17616
fix "podman logs --since --follow" flake
2023-03-01 15:12:32 +01:00
Valentin Rothberg
51cf2dd363 test/system/255-auto-update.bats: wait 10 for update to finish
10 seconds is used by most other tests as a timeout. Given the test
flakes on Debian use it.

Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 14:45:59 +01:00
Valentin Rothberg
b727f30ac6 auto-update test: wait for service to be ready
The symptoms in #17607 point to some race since it does not always flake
on Debian (and Debian only).  Hence, wait for the service to be ready
before building the image to make sure that the service is started with
the old image and that everything's in order.

Fixes: #17607
Signed-off-by: Valentin Rothberg <vrothberg@redhat.com>
2023-03-01 13:43:29 +01:00
OpenShift Merge Robot
6aaf0f29dc
Merge pull request #17664 from rhatdan/VENDOR
Vendor in latest containers/(common, storage, image)
2023-03-01 09:42:47 +01:00
OpenShift Merge Robot
3cab05aa3e
Merge pull request #17656 from ygalblum/quadlet-container-mount
Quadlet: Add support for the Mount key in .container files
2023-03-01 09:21:09 +01:00
OpenShift Merge Robot
295dd26225
Merge pull request #17648 from anjannath/update-qemu
pkginstaller: bump Qemu to version 7.2.0
2023-02-28 22:02:34 +01:00