Giuseppe Scrivano
a7318f7364
pkg, ps: add namespaces methods
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 17:08:52 +02:00
OpenShift Merge Robot
fdf64f0c66
Merge pull request #5994 from giuseppe/fix-healthchecks
...
v2, podman: fix healthchecks
2020-04-27 15:40:24 +02:00
OpenShift Merge Robot
529824ec1e
Merge pull request #5997 from giuseppe/fix-pod-create
...
v2, podman: fix a bunch of "podman pod *" tests
2020-04-27 15:37:58 +02:00
OpenShift Merge Robot
ef46687dc5
Merge pull request #5976 from QiWang19/manifest-add-os
...
Add --os to manifest add
2020-04-27 15:33:00 +02:00
Giuseppe Scrivano
869a1a211a
pkg, pods: report pod rm errors
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 14:02:53 +02:00
Giuseppe Scrivano
1aaef86eb4
pkg, pods: pod rm honors --ignore
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:47:52 +02:00
Giuseppe Scrivano
4028215b6a
pkg, pods: not lose pod start/restart errors
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:41:08 +02:00
Giuseppe Scrivano
e589c2219f
pkg, pods: honor --ignore for pod stop
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:19:05 +02:00
Giuseppe Scrivano
c2f77a281f
specgen: relax test to accept default network
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 13:12:19 +02:00
Giuseppe Scrivano
adb10783d9
spec, pod: honor --dns
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 12:58:02 +02:00
Giuseppe Scrivano
1cd484e13f
specgen: read healthchecks from the image
...
if there is no healthcheck configuration specified, read it from the
image.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 11:22:27 +02:00
Sujil02
c1766d5e64
Enable pod inspect integration test
...
Enable pod inspect integration test
Get rid of libpod pod inspect references
Remove libpod PodInspect struct.
Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-26 16:38:52 -04:00
Brent Baude
942a3ef588
Enable pod ps integration tests
...
Enable integration tests for pod ps.
In addition, fixed bug where output was still using slice go template routines and would fail when no infra container was present. Added integration test to prevent future regressions.
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-25 13:13:32 -05:00
OpenShift Merge Robot
2afe579c06
Merge pull request #5971 from giuseppe/fix-userns-tests
...
v2, podman: fix and enable all run_userns_test.go tests
2020-04-24 22:39:26 +02:00
Qi Wang
2f3734b143
Add --os to manifest add
...
Add --os to manifest add for overriding the os field.
Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-24 14:57:56 -04:00
OpenShift Merge Robot
a49d5c9c2f
Merge pull request #5974 from giuseppe/fix-init
...
[v2] containers, init: skip invalid state errors with --all
2020-04-24 20:33:17 +02:00
OpenShift Merge Robot
3c3adac528
Merge pull request #5967 from giuseppe/run-test-fixes
...
v2, tests: fix various run_test.go failures
2020-04-24 17:46:20 +02:00
Giuseppe Scrivano
bd7cad775a
containers, init: skip invalid state errors with --all
...
reintroduce the same check that exists in v1.9.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 17:33:27 +02:00
Giuseppe Scrivano
88f1994ab9
podman: assume user namespace if there are mappings
...
if some mappings are specified, assume there is a private user
namespace.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:55:38 +02:00
Matthew Heon
b1552d9124
Do not join pod namespaces without an infra ctr
...
We do not want to join pod namespaces if no infra container is
present. A pod may claim it shares namespaces without an infra
container (I'll take an action item to fix that - it really
should not be allowed), which was tripping up our default
namespace code and forcing us to try and join the namespaces of
the nonexistant infra container.
Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-04-24 09:44:51 -04:00
Giuseppe Scrivano
64d8b4eebb
podman: implement userns=keep-id
...
add missing implementation for userns=keep-id and enable the user
namespaces tests.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:03:50 +02:00
Giuseppe Scrivano
a3acc4f977
podman: add support for --rootfs
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:20 +02:00
Giuseppe Scrivano
23d431f0bf
specgen: fix error message
...
the check is correct but the error message was stating the opposite.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 10:49:18 +02:00
Giuseppe Scrivano
36039a38ea
create: move validate after setting default ns
...
validate the configuration only after we set the default namespaces.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 10:48:40 +02:00
Daniel J Walsh
995cd97c10
Fix SELinux functions names to not be repetitive
...
Since functions are now in an selinux subpackage, they should not start with
SELinux
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-23 15:57:34 -04:00
OpenShift Merge Robot
802763c604
Merge pull request #5933 from giuseppe/fix-namespaces
...
podman, v2: handle namespaces specified on the CLI
2020-04-23 19:32:08 +02:00
OpenShift Merge Robot
e5a3e46746
Merge pull request #5946 from jwhonce/wip/shutdown
...
V2 restore libpod.Shutdown() when exiting podman commands
2020-04-23 18:27:32 +02:00
Giuseppe Scrivano
48530acbd9
podman: handle namespaces specified on the CLI
...
and handle differently the user namespace as it supports additional
options.
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-23 18:05:03 +02:00
Giuseppe Scrivano
d98b6f4232
pkg: fix shmsize error message
...
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-23 18:05:01 +02:00
OpenShift Merge Robot
397dcc358a
Merge pull request #5843 from QiWang19/manifest_create
...
manifest create,add,inspect
2020-04-23 17:45:38 +02:00
Daniel J Walsh
e66346c7b0
Stop wrapping pull messages
...
The length and size of our error messages on failure to pull
is huge. This patch at least eliminates some of the wrapping.
But I think eventually we need to look at containers/image
and see if we can modify the error messages to something a little
more human friendly.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-23 05:31:36 -04:00
Qi Wang
17783dda68
manifest create,add,inspect
...
Implememts manifest subcommands create, add, inspect.
Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-22 20:05:21 -04:00
Jhon Honce
be5605ac4f
V2 Restore rmi tests
...
* Introduced define.ErrImageInUse to assist in determining the exit code
without resorting string searches.
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 15:34:33 -07:00
OpenShift Merge Robot
bf1e5b875f
Merge pull request #5942 from mheon/volume_flags
...
Enable basic volumes support in Podmanv2
2020-04-22 23:27:07 +02:00
Jhon Honce
565f93531e
V2 restore libpod.Shutdown() when exiting podman commands
...
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 14:25:40 -07:00
OpenShift Merge Robot
2584d6bd58
Merge pull request #5936 from rhatdan/selinux1
...
Move selinux labeling support from pkg/util to pkg/selinux
2020-04-22 22:30:59 +02:00
OpenShift Merge Robot
576fe98bbc
Merge pull request #5930 from jwhonce/issues/5765
...
Instrumentation to answer #5765
2020-04-22 21:29:10 +02:00
Matthew Heon
b4a4338dfe
Enable basic volumes support in Podmanv2
...
This enables the --volume, --mount, and --tmpfs flags in
Podmanv2. It does not enable init-related flags, image volumes,
and --volumes-from.
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-22 14:24:12 -04:00
Daniel J Walsh
ede8380d37
Move selinux labeling support from pkg/util to pkg/selinux
...
The goal here is to make the package less heavy and not overload
the pkg/util.
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 14:17:59 -04:00
Brent Baude
6fdcc09a20
Fix integration tests for untag
...
Signed-off-by: Brent Baude <bbaude@redhat.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 14:13:07 -04:00
Jhon Honce
d7a27b8e84
Instrumentation to answer #5765
...
* currently wired to localhost:8888 to prevent access from off machine
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 11:07:28 -07:00
OpenShift Merge Robot
02bd8cef7b
Merge pull request #5916 from giuseppe/userns-auto
...
v2, podman: plug --userns=auto
2020-04-21 16:10:28 -04:00
Matthew Heon
1cd2b746d0
Modify namespace generation code for specgen
...
Namespaces have now been changed to properly handle all cases.
Spec handling code for namespaces was consolidated in a single
function.
Still missing:
- Image ports
- Pod namespaces likely still broken in Podmanv2
Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-21 14:38:52 -04:00
OpenShift Merge Robot
0d817f5210
Merge pull request #5900 from baude/v2cp
...
podmanv2 cp
2020-04-21 12:47:17 -04:00
OpenShift Merge Robot
1ed849f2d1
Merge pull request #5921 from baude/v2imageep
...
add entrypoint from image where needed
2020-04-21 11:23:21 -04:00
OpenShift Merge Robot
a2541bf133
Merge pull request #5912 from giuseppe/v2-rlimits
...
v2, pkg: implement rlimits
2020-04-21 11:17:35 -04:00
Brent Baude
29ec539b3f
podmanv2 cp
...
enable podman to copy files between container and host, local mode only. this is a straight port of v1 code to v2.
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-21 09:23:27 -05:00
Brent Baude
224a5ce51e
add entrypoint from image where needed
...
if the image specifies both the image and entrypoint, we need to account for that and preprend the entrypoint to the command. this only happens if no user command and entrypoint were supplied.
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-21 09:15:21 -05:00
Brent Baude
ae5e7e7e78
v2podman port
...
add port command to podman.
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-21 08:33:15 -05:00
OpenShift Merge Robot
08823e7383
Merge pull request #5913 from rhatdan/v2
...
More fixes for podman create tests
2020-04-21 07:54:39 -04:00