Some jobs had no timeout set, add reasonable timeouts for the jobs. This
is needed because the github default it a timeout of 6 hours which is
just not sane and in case a job ever hangs will waste a lot of
resources.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Add one more test to the basic podman commands e2e tests:
- starts an HTTP server on the host
- verify HTTP requests from a container, using
`host.containers.internal` or `host.docker.internal`, are routed
successfully to the server running on the host
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
test
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
Using the app id is deprecated, also so far since the repo move this
workflow failed all the time as the github app was not in the new org.
I created a new app for this and set the right vars.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
This action never worked AFAICT, no cert was ever created[1] (outside
of the test certs on another repo) and the job gets always skipped.
Since nobody seems to be bothered by this it should be removed IMO.
Given the action commit access to the other repo was never a good idea
and with the CNCF move now we should not depend on it any more.
Like it is right now it just wastes action resources. And renovate will
update the action in the workflow so we get extra PRs for no benefit to
review and validate.
[1] https://github.com/containers/automation/tree/main/certificates
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Put the variable in the workflow file like the renovate config expects,
see https://github.com/podman-container-tools/automation/pull/29
To ensure the local runs keep working we need a fall back to parse the
file manually.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
When WSL wasn't installed, the lookup erroneously reported that
a VM with the same name existed. Instead, in this case, the lookup
should return zero matching VMs.
Fixes https://github.com/podman-container-tools/podman/issues/29053
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
The nightly release validation builds both on main and the latest release branch,
we should upload the artifacts with a suffix to differentiate the two
Signed-off-by: Ashley Cui <acui@redhat.com>
See the prior commit, we now build the swagger yaml as part of the
official readthedocs process so we do not need to host it elsewhere.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Many GitHub Actions workflows currently trigger on user forks, leading to
unnecessary CI resource consumption, unwanted bot behavior, and inevitable
failures. This commit restricts these specific workflows to only run on the
primary `containers/podman` repository.
The restricted workflows fall into two main categories:
1. Require Custom Upstream Secrets: Workflows like `release`, `mac-pkg`,
`cherry-pick`, and `dev-bump` rely on secrets (e.g., Apple/Azure certs,
PODMANBOT_TOKEN, ACTION_MAIL_*) that are unavailable in forks.
2. Manage Upstream Tracker State: Workflows like `assign`, `stale`, and
`labeler` are intended strictly for managing the primary project's
issues and PRs. Running them on personal forks creates unwanted noise.
Additionally, refactored several complex `if` conditions using YAML
multi-line strings (`|`) to maintain and improve readability.
Signed-off-by: Byounguk Lee <nimdrak@gmail.com>
Something with the cache is not working right and results in
inconsistent lint result.
Even on PRs where there are no source code changes we observe random
failures. I have seen at least 4 different instances since we the new CI
setup. It is not reasonable to spot fix each new warning (mostly just
adding new nolint comments) each time as it affects all PRs at once.
It will also be very confusing for new contributors.
Fixes: #28893
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
With podman-remote we do not enter a our user namespace like we do with
local podman so we keep running with the real user id.
So if we then try to use chrootarchive as normal user it fails with:
creating mount namespace before pivot: operation not permitted
So simply revert back to the normal archive code.
Now the more interesting thing is we do have a test
"podman save to directory with oci format" but it never runs
rootless+remote in our CI system with our current matrix as we wanted to
reduce jobs.
So rethink the matrix and add one such job as this shows it is needed.
Fixes: 25aee24cbd ("use chrootarchive over plain archive package")
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
Migrate release to use release-build-artifacts action. This re-usable build action is tested nightly, so hopefully this will make our release automation more stable, as we may catch issues in our nightly runs. Followup to https://github.com/podman-container-tools/podman/pull/28176
Signed-off-by: Ashley Cui <acui@redhat.com>
When the validate-source job is re-run manually after adding a label,
it uses stale labels (from the "pull_request" event that originally
triggered it), and so the steps that check labels don't see new labels.
Fix by querying the labels live (similar to how it was done before
commits 6e597af6dc and 1da154117c).
Note the logic differs slightly between hack/ci/make-and-check-size.sh
and hack/ci/pr-should-include-tests. This is because
pr-should-include-tests is also executed locally as well as on non-PRs,
while make-and-check-size is run strictly in CI for PRs only.
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
We need to not hard depend on the pull_request var contexts so use the
right alternatives. The PR_ envs can be left empty, the tests using them
should skip the checks if they are unset/empty.
Fixes: #28825
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
It is not strictly needed I think since other jobs depend on this
already but for consistency this is easier to check that success waits
for all jobs.
Signed-off-by: Paul Holzinger <pholzing@redhat.com>
