Commit graph

1381 commits

Author SHA1 Message Date
Mario Loriedo
988860edb7
Merge pull request #29211 from l0rd/win-installer-rm-is_upgrade
Windows installer: remove unused IS_UPGRADE property
2026-07-22 09:41:23 +02:00
Mario Loriedo
cee109e255 Windows installer: remove unused IS_UPGRADE property
This is a followup after @lstocchi comment:

https://github.com/podman-container-tools/podman/pull/29169#discussion_r3588942348

The property `IS_UPGRADE` isn't set and was a leftover of the legacy
windows installer.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-07-17 16:32:18 +02:00
Mario Loriedo
a572711c84 Fix Windows installer machine scope PATH update
Update Podman Windows installer to update the PATH for all users if
executed in machine scope mode.

Added a new test that checks if Podman installation folder is in PATH.

Fixes #29160

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-07-16 17:56:01 +02:00
Christophe Fergeau
073ad746b0
macos: Use latest vfkit release in installer
Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
2026-07-07 18:34:04 +02:00
Sergio Lopez
f68612b052 Bump bundled krunkit from 1.3.1 to 1.3.2
Bump bundled krunkit to 1.3.2, which comes with libkrun 1.19.4.

This version of libkrun includes a fix in virtio-fs on macOS for
libkrun/libkrun#769 that potentially impacts podman users.

Signed-off-by: Sergio Lopez <slp@redhat.com>
2026-07-03 13:26:47 +02:00
Sergio Lopez
06bfb55eb1 Bump bundled krunkit from 1.2.1 to 1.3.1
Bump bundled krunkit to 1.3.1, which comes with libkrun 1.19.3.

This version of krunkit makes HTTP parsing on the rest-uri more
robust to ensure it only acts on the right request.

It also enables a new permission semantics mode in libkrun that's
closer to the user expectations on macOS.

Fixes: #21402
Fixes: #29084

Signed-off-by: Sergio Lopez <slp@redhat.com>
2026-07-01 19:05:12 +02:00
Matt Heon
06af59795f
Merge pull request #29061 from mheon/meeting_minutes_20260626
Some checks failed
ci / int local root fedora-prior (push) Has been cancelled
ci / sys local root fedora-prior (push) Has been cancelled
ci / int local rootless fedora-prior (push) Has been cancelled
ci / sys local rootless fedora-prior (push) Has been cancelled
ci / int remote root fedora-prior (push) Has been cancelled
ci / sys remote root fedora-prior (push) Has been cancelled
ci / int local root fedora-rawhide (push) Has been cancelled
ci / sys local root fedora-rawhide (push) Has been cancelled
ci / int local rootless fedora-rawhide (push) Has been cancelled
ci / sys local rootless fedora-rawhide (push) Has been cancelled
ci / int remote root fedora-rawhide (push) Has been cancelled
ci / sys remote root fedora-rawhide (push) Has been cancelled
ci / apiv2 root fedora-current (push) Has been cancelled
ci / bindings root fedora-current (push) Has been cancelled
ci / compose_v2 root fedora-current (push) Has been cancelled
ci / docker_py root fedora-current (push) Has been cancelled
ci / unit root fedora-current (push) Has been cancelled
ci / apiv2 rootless fedora-current (push) Has been cancelled
ci / compose_v2 rootless fedora-current (push) Has been cancelled
ci / unit rootless fedora-current (push) Has been cancelled
ci / upgrade v5.3.1 root fedora-current (push) Has been cancelled
ci / upgrade v5.6.2 root fedora-current (push) Has been cancelled
ci / machine linux amd64 (push) Has been cancelled
ci / windows unit (push) Has been cancelled
ci / windows e2e (push) Has been cancelled
ci / windows machine hyperv (push) Has been cancelled
ci / windows machine wsl (push) Has been cancelled
ci / macos machine applehv (push) Has been cancelled
ci / macos machine libkrun (push) Has been cancelled
ci / Total Success (push) Has been cancelled
Add minutes for the 2026-06-26 Core Maintainers meeting
2026-06-26 15:12:26 -04:00
Matt Heon
9dd80122d7 Add minutes for the 2026-06-26 Core Maintainers meeting
These are AI generated (Gemini 3.5 Thinking). I have included the
full transcript as well so there is a further source of truth in
the event of error in the AI summary, but it seemed reasonably
accurate when I reviewed it.

Signed-off-by: Matt Heon <mheon@redhat.com>
2026-06-26 14:09:45 -04:00
Mario Loriedo
6ae463a9cd Windows installer tests: download v5.8.3 of the setup bundle
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-06-25 11:23:49 +02:00
Mario Loriedo
ff9f192f4d Update gh org from which releases are pulled in pswh scripts
Use https://api.github.com/repos/podman-container-tools/podman/releases.

That may eventually fix
https://github.com/podman-container-tools/podman/issues/28850 based on
https://docs.github.com/en/actions/concepts/security/github_token:

> The token's permissions are limited to the repository that contains your
> workflow.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-06-05 18:35:41 +02:00
Kir Kolyshkin
f6575bd17f
Rename contrib/cirrus to hack/ci
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2026-06-01 13:01:33 +02:00
Mario Loriedo
40a9e21644 Update release ID in win-installer-main.ps1
Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-05-29 13:48:05 +02:00
Mario Loriedo
7c7d56a0fb Use GH token to download Podman release in utils.ps1
This is to avoid requests failing due to GitHub's non-authenticated
request rate limit.

See [this PR check
failure](https://github.com/podman-container-tools/podman-sandbox/actions/runs/26632208486/job/78483599334?pr=5)
for an example of such a failure.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-05-29 13:48:05 +02:00
Matt Heon
faa1f85136
Merge pull request #28780 from erictrue/patch-1
Fix an obvious typo
2026-05-26 08:35:14 -04:00
Paul Holzinger
22c5f3fa55
Merge pull request #28527 from vyasgun/pr/krunkit-timesync
machine: add vfkit timesync device for Apple VMs
2026-05-26 12:23:04 +02:00
Eric True
ffb05a0921
Update krunkit.entitlements
Signed-off-by: Eric True <272747804+erictrue@users.noreply.github.com>
2026-05-26 02:09:43 +08:00
Kir Kolyshkin
d8fd8afad1 contrib/cirrus/prebuild.sh: drop unused get_env_key
The last user of get_env_key was removed by commit
69163af2a0 ("Remove gitleaks scanning").

Remove it.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2026-05-23 14:26:55 -07:00
Kir Kolyshkin
b2b552749d ci: rm contrib/cirrus/check_go_changes.sh
This functionality is superseded by golangci-lint.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
2026-05-21 13:16:32 -07:00
Gunjan Vyas
250e5f9914 use constant for timesync port and update mac_env.sh to print krunkit version
Signed-off-by: Gunjan Vyas <vyasgun20@gmail.com>
2026-05-20 12:56:50 +05:30
Brent Baude
b197c3324f
Core maintainer meeting minutes
meeting minutes from Apr 24

Signed-off-by: Brent Baude <bbaude@redhat.com>
2026-05-01 08:07:37 -05:00
Mario Loriedo
15c9ca130f Add command podman system hyperv-prep
Introducing a new `podmand system` subcommand to prepare a Windows host
to run Hyper-V based Podman machines: `hyperv-prep`.

When executed it:
- creates of the registry keys for VSocks
- adds the current user to the Hyper-V administrators group

This command requires an administrator terminal.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-04-29 23:00:29 +02:00
Lokesh Mandvekar
b0f1889de7
contrib/packit-tmt: Rename script for clarity of intent
Signed-off-by: Lokesh Mandvekar <lsm5@linux.com>
2026-04-27 13:11:53 -04:00
Mario Loriedo
53fc1d902e Install WiX v5.0.2 to build the Windows installer
To avoid failures such as

https://github.com/containers/podman/actions/runs/24401569105/job/71274410909#step:10:78

use version v5.0.2 of WiX as we do in CI images:

fe80516848/win_images/win_packaging.ps1 (L27)

Related to issue https://github.com/containers/podman/issues/27042

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-04-14 18:44:58 +02:00
Lokesh Mandvekar
9ff3f4cb1e
Clean up outdated slirp4netns references in comments
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2026-04-13 09:05:09 -04:00
Paul Holzinger
427aded546
cirrus: do not remove /usr/share/containers/storage.conf
Per new config file parsing order the /etc/containers/storage.conf path
we create below is a clean overwrite so there is no need to explicitly
remove the file here.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-03-23 14:54:59 +01:00
Jan Rodák
dcc8ff3965
Merge pull request #28333 from gounthar/feat/riscv64-cross
ci: add riscv64 cross-compilation to Cirrus CI alt-arch matrix
2026-03-23 11:44:09 +01:00
Bruno Verachten
f3f36d176d
ci: add riscv64 cross-compilation to Cirrus CI alt-arch matrix
Add GOARCH=riscv64 cross-build alongside the existing x86, ARM, MIPS,
MIPS64, ppc64le, and s390x cross-compilation checks.

Closes #28329

Signed-off-by: Bruno Verachten <gounthar@gmail.com>
2026-03-20 14:03:38 +01:00
Paul Holzinger
ac49a4b416
cirrus: setup composefs in rootful storage.conf
Rootless users cannot use composefs so we need to set it up in the
storage.rootful.conf.d/ directory so only the rootful podman reads this
file.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-03-19 21:49:20 +01:00
Paul Holzinger
c7e51fa1c1
cirrus: make sure we do not test the fedora storage.conf file
It hard codes a graphroot which is not correct for rootless users based
on our new config file parsing.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-03-19 21:49:20 +01:00
Lokesh Mandvekar
61cb417c26
Remove CNI references from comments
Update comments that reference CNI as a network backend since it
has been removed.

Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>
2026-03-19 20:26:21 +05:30
Tom Sweeney
bb9d188d4a
Merge pull request #28236 from Honny1/fix-unless-stopped
Fix `unless-stopped` containers not restarting after `podman-restart-service` stop them
2026-03-19 10:45:28 -04:00
Sergio Lopez
9dcc73079f Bump bundled krunkit from 1.1.1 to 1.2.1
Bump bundled krunkit to 1.2.1, which comes with libkrun 1.17.4.

The highlights for podman in this release of libkrun are a number
of virtio-fs behavioural fixes, specially when running non-root
users within a container, along with better disk performance and
lower space consumption thanks to support for F_DISCARD and
F_WRITE_ZEROES.

This release of krunkit also introduces the "--timesync" flag,
with the same behavior as the vfkit counterpart, meaning it's now
possible to enable clock synchronization with this mechanism.

Fixes: #27679

Signed-off-by: Sergio Lopez <slp@redhat.com>
2026-03-17 12:58:38 +01:00
Jan Rodák
7326b862e3
Fix unless-stopped containers not restarting after podman-restart.service stop them
When `podman-restart.service` stops containers, it marks them as "stopped by
user" which breaks the `unless-stopped` restart policy. Add hidden
`--not-stopped-by-user` flag to prevent this, allowing `unless-stopped`
containers to restart on next boot.

Fixes: https://github.com/containers/podman/issues/28152
Fixes: https://issues.redhat.com/browse/RUN-4357

Signed-off-by: Jan Rodák <hony.com@seznam.cz>
2026-03-16 13:51:17 +01:00
Mario Loriedo
4bdc1d372a [Design Doc] New feature to import local CA certs
Related to https://issues.redhat.com/browse/RUN-3839

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-03-02 17:04:01 +01:00
Paul Holzinger
b45b826061
DESIGN DOC: update config-file-parsing
Add some more work items I should tackle as part of this.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-02-16 13:47:55 +01:00
Paul Holzinger
af7c36eae3
make curl error on non success status codes
By default something like a 404 will not make curl exit with an error
code. This is problematic for obvious reasons and instead of the file
you want you may now have some 404 html text instead.

I noticed this in #28003 which well just build fine installers except
the binary downloaded by the installer Makefile simply did not exist.

So to address that add --fail to most curl commands.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-02-06 17:29:49 +01:00
Lewis Roy
fc18d3229d [DOCS] Update references common -> container-libs/common
Signed-off-by: Lewis Roy <lewisdenny@me.com>
2026-02-04 21:29:17 +10:00
Mario Loriedo
f71465a025 Fix PowerShell Write-Error multi-line argument
This is a follow-up of d04c84e7 and fixes the error message that is
displayed if someone tries to run `contrib/win-installer/build.ps1` but
doesn't have the .NET SDK installed.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-01-27 15:06:51 +01:00
Paul Holzinger
990733c32f
Merge pull request #27925 from afbjorklund/validatepr-architecture
Set architecture for validatepr builds
2026-01-27 12:54:35 +01:00
Jeff MAURY
d04c84e783
fix: generate correct error message if Wix is not installed
Fixes #27955

Signed-off-by: Jeff MAURY <jmaury@redhat.com>
2026-01-26 14:11:35 +01:00
Anders F Björklund
ea01acf325 Set architecture for validatepr builds
It was failing on darwin, because amd64 is no longer supported.

"build constraints exclude all Go files" in pkg/machine/libkrun

Signed-off-by: Anders F Björklund <anders.f.bjorklund@gmail.com>
2026-01-20 07:32:54 +01:00
Alessio Attilio
f0dd315bdf systemd: update podman-restart.service description
Update the service description to reflect that it now also restarts
containers with unless-stopped restart policy, not just always.

This was changed in PR #27619 but the description was not updated.

Fixes: #27908
Signed-off-by: Alessio Attilio <attilio.alessio@protonmail.com>
2026-01-19 23:38:35 +01:00
Paul Holzinger
6fd970afe0
design doc: config file parsing changes
As part of podman 6 we like to improve and consolidate how we parse our
various config files.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2026-01-07 16:03:02 +01:00
Mario Loriedo
74043cf726 Remove legacy win installer files
The old setup bundle was still built and released to avoid breaking
downstream projects. This commit removes it and, starting from Podman
v6, only the installer that doesn't require elevated privileges will be
released.

This is a subtask of issue #27624.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-01-05 12:19:44 +01:00
Mario Loriedo
d9975a5390 Stop copying gvproxy in legacy installation dir
Before running machine e2e tests on Windows, the gvproxy executable was
copied in `C:\Program Files\Redhat\Podman`. This is wrong because the
target folder, where Podman is installed, has changed but is also
useless because, after #27612, podman looks for gvproxy in `podman.exe`
folder too. This commit removes the gvproxy copy step.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
2026-01-05 12:19:44 +01:00
Paul Holzinger
7e3caaed84
cirrus: ensure NOTIFY_SOCKET is properly unset for all tests
Podman uses this env toi do various things, we don't want the external
env to affect our tests here.

Signed-off-by: Paul Holzinger <pholzing@redhat.com>
2025-12-12 14:09:18 +01:00
Tim Zhou
5d79adbd6a update fedoral base image to 43 and related tests
Signed-off-by: Tim Zhou <tizhou@redhat.com>
2025-12-11 12:51:21 -05:00
Brent Baude
f87cefc262 Remove Intel MacOS support
This PR removes support for Intel Apple Macs. The removal includes
impacts to code, tests, Makefile, builds, release builds, and so forth.

Fixes Jira: RUN-3621

Signed-off-by: Brent Baude <bbaude@redhat.com>
2025-12-07 07:03:06 -06:00
openshift-merge-bot[bot]
5508d873c1
Merge pull request #27619 from Honny1/fix-unless-stopped-reboot
Fix `unless-stopped` restart policy to match Docker behavior
2025-12-04 15:04:10 +00:00
Brent Baude
1bddd38e0a Add perl to make validatepr
Users reported that our container image for make validatepr needs perl
base installed.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2025-12-02 12:47:34 -06:00