Commit graph

23873 commits

Author SHA1 Message Date
Qi Wang
2f3734b143 Add --os to manifest add
Add --os to manifest add for overriding the os field.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-24 14:57:56 -04:00
OpenShift Merge Robot
a49d5c9c2f
Merge pull request #5974 from giuseppe/fix-init
[v2] containers, init: skip invalid state errors with --all
2020-04-24 20:33:17 +02:00
OpenShift Merge Robot
3c3adac528
Merge pull request #5967 from giuseppe/run-test-fixes
v2, tests: fix various run_test.go failures
2020-04-24 17:46:20 +02:00
Giuseppe Scrivano
bd7cad775a
containers, init: skip invalid state errors with --all
reintroduce the same check that exists in v1.9.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 17:33:27 +02:00
OpenShift Merge Robot
dcb99f5315
Merge pull request #5972 from mheon/fix_noinfra
Do not join pod namespaces without an infra ctr
2020-04-24 16:58:24 +02:00
Giuseppe Scrivano
88f1994ab9
podman: assume user namespace if there are mappings
if some mappings are specified, assume there is a private user
namespace.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:55:38 +02:00
Matthew Heon
b1552d9124 Do not join pod namespaces without an infra ctr
We do not want to join pod namespaces if no infra container is
present. A pod may claim it shares namespaces without an infra
container (I'll take an action item to fix that - it really
should not be allowed), which was tripping up our default
namespace code and forcing us to try and join the namespaces of
the nonexistant infra container.

Signed-off-by: Matthew Heon <mheon@redhat.com>
2020-04-24 09:44:51 -04:00
Giuseppe Scrivano
64d8b4eebb
podman: implement userns=keep-id
add missing implementation for userns=keep-id and enable the user
namespaces tests.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:03:50 +02:00
OpenShift Merge Robot
46463e454e
Merge pull request #5968 from giuseppe/fix-cgroup-tests
v2, test: enable cgroup parent tests
2020-04-24 14:55:07 +02:00
OpenShift Merge Robot
ec17b2652e
Merge pull request #5965 from containers/dependabot/go_modules/github.com/containers/common-0.9.5
Bump github.com/containers/common from 0.9.4 to 0.9.5
2020-04-24 14:52:21 +02:00
Chris Evich
62accbc565
Cirrus: Utilize new VM images
Signed-off-by: Chris Evich <cevich@redhat.com>
2020-04-24 08:22:50 -04:00
Chris Evich
97ecd21b59
Cirrus: Unify package installation
Also, test-build critical container images depended upon for
CI-purposes.

Signed-off-by: Chris Evich <cevich@redhat.com>
2020-04-24 08:22:50 -04:00
Giuseppe Scrivano
c746980baf
test: enable cgroup parent tests
cgroups tests should pass now

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 13:05:43 +02:00
Giuseppe Scrivano
3eeb03d1f9
podman: fix --log-opt=path=%s
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 13:02:07 +02:00
Giuseppe Scrivano
145d74716c
podman: fix --http-proxy
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:24 +02:00
Giuseppe Scrivano
a1f73d0954
podman: fix podman --group-add
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:23 +02:00
Giuseppe Scrivano
543d5f1740
test: fix --host-env test
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:22 +02:00
Giuseppe Scrivano
2e6a62fc38
podman: fix --cgroups=disabled
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:21 +02:00
Giuseppe Scrivano
9f8d002e1f
test: enable some run_test.go tests that pass now
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:21 +02:00
Giuseppe Scrivano
a3acc4f977
podman: add support for --rootfs
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:20 +02:00
OpenShift Merge Robot
2c457a632c
Merge pull request #5962 from rhatdan/selinux
Fix SELinux functions names to not be repetitive
2020-04-24 12:48:39 +02:00
dependabot-preview[bot]
f0ebde8254
Bump github.com/containers/common from 0.9.4 to 0.9.5
Bumps [github.com/containers/common](https://github.com/containers/common) from 0.9.4 to 0.9.5.
- [Release notes](https://github.com/containers/common/releases)
- [Commits](https://github.com/containers/common/compare/v0.9.4...v0.9.5)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-24 06:43:30 -04:00
Giuseppe Scrivano
23d431f0bf
specgen: fix error message
the check is correct but the error message was stating the opposite.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 10:49:18 +02:00
Giuseppe Scrivano
36039a38ea
create: move validate after setting default ns
validate the configuration only after we set the default namespaces.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 10:48:40 +02:00
OpenShift Merge Robot
81c7a2444c
Merge pull request #5957 from giuseppe/drop-foo
foo: delete spurious file
2020-04-24 10:03:35 +02:00
OpenShift Merge Robot
d1be20fa5b
Merge pull request #5963 from akerl-unpriv/fix/tmpdir-for-pull
set bigfilestemporarydir for pull
2020-04-24 10:00:53 +02:00
Les Aker
26081e79c1 remove blank line
Signed-off-by: Les Aker <me@lesaker.org>
2020-04-23 16:25:02 -04:00
Les Aker
2c328f94b6 set bigfilestemporarydir for pull
Signed-off-by: Les Aker <me@lesaker.org>
2020-04-23 16:15:55 -04:00
Daniel J Walsh
995cd97c10
Fix SELinux functions names to not be repetitive
Since functions are now in an selinux subpackage, they should not start with
SELinux

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-23 15:57:34 -04:00
Giuseppe Scrivano
0e9967e038
foo: delete spurious file
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-23 20:51:56 +02:00
OpenShift Merge Robot
802763c604
Merge pull request #5933 from giuseppe/fix-namespaces
podman, v2: handle namespaces specified on the CLI
2020-04-23 19:32:08 +02:00
Lokesh Mandvekar
c10bd7c11f Makefile: include -nobuild install targets
Distro packaging often uses non-default build and linker flags.
The current Makefile cannot be used in the package build process as it
will end up rebuilding the binaries with the default flags.

This commit introduces install targets which do not depend on the build
targets. Distro packages should prefer these if they want to use any
non-default flags.

NOTE: This commit effectively leaves prior targets unchanged, so users
won't notice any difference.

Signed-off-by: Lokesh Mandvekar <lsm5@fedoraproject.org>
2020-04-23 13:08:25 -04:00
OpenShift Merge Robot
e5a3e46746
Merge pull request #5946 from jwhonce/wip/shutdown
V2 restore libpod.Shutdown() when exiting podman commands
2020-04-23 18:27:32 +02:00
Giuseppe Scrivano
48530acbd9
podman: handle namespaces specified on the CLI
and handle differently the user namespace as it supports additional
options.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-23 18:05:03 +02:00
Giuseppe Scrivano
2fd6a84c09
specgen: do not always set shmsize
if it wasn't overriden on the CLI, leave it undefined.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-23 18:05:02 +02:00
Giuseppe Scrivano
d98b6f4232
pkg: fix shmsize error message
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-23 18:05:01 +02:00
OpenShift Merge Robot
397dcc358a
Merge pull request #5843 from QiWang19/manifest_create
manifest create,add,inspect
2020-04-23 17:45:38 +02:00
OpenShift Merge Robot
e25528633d
Merge pull request #5952 from rhatdan/v
Stop wrapping pull messages
2020-04-23 13:31:51 +02:00
Daniel J Walsh
e66346c7b0
Stop wrapping pull messages
The length and size of our error messages on failure to pull
is huge.  This patch at least eliminates some of the wrapping.
But I think eventually we need to look at containers/image
and see if we can modify the error messages to something a little
more human friendly.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-23 05:31:36 -04:00
OpenShift Merge Robot
c71bbffc0f
Merge pull request #5948 from jwhonce/jira/826
V2 Restore rmi tests
2020-04-23 10:32:15 +02:00
Qi Wang
17783dda68 manifest create,add,inspect
Implememts manifest subcommands create, add, inspect.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-22 20:05:21 -04:00
Jhon Honce
be5605ac4f V2 Restore rmi tests
* Introduced define.ErrImageInUse to assist in determining the exit code
  without resorting string searches.

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 15:34:33 -07:00
OpenShift Merge Robot
bf1e5b875f
Merge pull request #5942 from mheon/volume_flags
Enable basic volumes support in Podmanv2
2020-04-22 23:27:07 +02:00
Jhon Honce
565f93531e V2 restore libpod.Shutdown() when exiting podman commands
Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-22 14:25:40 -07:00
OpenShift Merge Robot
142757bd72
Merge pull request #5947 from rhatdan/v
Turn on version.go except for -v check
2020-04-22 23:10:46 +02:00
OpenShift Merge Robot
2584d6bd58
Merge pull request #5936 from rhatdan/selinux1
Move selinux labeling support from pkg/util to pkg/selinux
2020-04-22 22:30:59 +02:00
OpenShift Merge Robot
576fe98bbc
Merge pull request #5930 from jwhonce/issues/5765
Instrumentation to answer #5765
2020-04-22 21:29:10 +02:00
OpenShift Merge Robot
94dc39a41b
Merge pull request #5945 from rhatdan/pull
Fix podman push and podman pull to check for authfile
2020-04-22 21:26:42 +02:00
OpenShift Merge Robot
cac05c8588
Merge pull request #5944 from rhatdan/untag
Fix integration tests for untag
2020-04-22 21:23:42 +02:00
Daniel J Walsh
34ee183ae6
Turn on version.go except for -v check
Currently podman -v does not work but the other version checks all pass.

enabling tests to that we can get more tests running in CI.

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-22 15:18:42 -04:00