Commit graph

4109 commits

Author SHA1 Message Date
Giuseppe Scrivano
65d7f22720
cmd, podman: handle --pod new:POD
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:33 +02:00
Giuseppe Scrivano
27f5145445
create: propagate override-arch and override-os
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-30 11:33:32 +02:00
Qi Wang
75eeb40f41 testv2: enable attach test
testv2: enable attach test

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-29 23:47:15 -04:00
Jhon Honce
22d5b2e305 V2 enable ps tests
* Combine cobra.Command helper functions into validate package
  from registry and common packages
* Introduce ChoiceValue for flags

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 15:51:37 -07:00
OpenShift Merge Robot
99f8cfc2dc
Merge pull request #5956 from jwhonce/wip/version
V2 restore podman -v command
2020-04-29 20:50:43 +02:00
Jhon Honce
6a586992c1 V2 restore podman -v command
* Removed extra spaces and improved error message
* Updated tests to use gomega matchers

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 09:15:24 -07:00
Jhon Honce
a9cc13448e V2 Restore images list tests
* Fix history --quiet formatting
* Fix image inspect --format=json
* Fix image list --sort

Signed-off-by: Jhon Honce <jhonce@redhat.com>
2020-04-29 08:24:56 -07:00
Valentin Rothberg
5ee3af2d03 enable search tests
Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 16:28:18 +02:00
Valentin Rothberg
2d10471b8d pull/search options: tls verify -> skip
Change the logic in the options from tls-verify to skipping
verification.  It require a constant brain yoga to translate
from doing verification (CLI logic) to skipping it (c/image logic).
As the code is using c/image, let's make it consistent.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 16:28:12 +02:00
Valentin Rothberg
d6d1e3860c push: fix --tls-verify
Fix --tls-verify parsing and make the associated options reflect the
correct logic.  Other commands are affected as well but will be fixed
later.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:33:00 +02:00
Valentin Rothberg
46b185942c push: simplify cmd
The indirection via a 2nd variable isn't needed.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 14:14:02 +02:00
Valentin Rothberg
854293a59a push: fix push with one argument
When doing a `podman push $IMG`, $IMG acts as the source and the
destination.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 11:42:36 +02:00
OpenShift Merge Robot
3e912f711b
Merge pull request #6022 from vrothberg/enable-inspect-tests
enable inspect tests
2020-04-29 11:21:47 +02:00
Valentin Rothberg
8700c2fd03 enable inspect tests
A surprisingly big change.  A core problem was that `podman inspect`
allows for passing containers AND images with the default `--type=all`.
This only worked partially as the data was processed in isolation which
caused various issues (e.g., two separate outputs instead of one) but it
also caused issues regarding error handling.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:25:31 +02:00
Valentin Rothberg
b2414b580e generate systemd
Implement `podman generate systemd` for Podman v2 and enable associated
tests.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-29 07:22:18 +02:00
OpenShift Merge Robot
bf4efc1953
Merge pull request #6026 from baude/v2forcesystemtests
system tests must pass
2020-04-28 23:29:20 +02:00
OpenShift Merge Robot
30b27819d0
Merge pull request #5991 from sujil02/pod-rm-test
Fix typos in messages pod rm
2020-04-28 22:40:09 +02:00
Brent Baude
517bc28360 system tests must pass
Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-28 15:17:00 -05:00
Sujil02
b3cfb20aa2 Fix typos in rm messages
Fix typos in pod rm messages

Signed-off-by: Sujil02 <sushah@redhat.com>
2020-04-28 15:57:40 -04:00
OpenShift Merge Robot
8f57f312d6
Merge pull request #6020 from giuseppe/fix-exec
v2, podman: fix create tests
2020-04-28 19:19:12 +02:00
Giuseppe Scrivano
c999f9daf2
specgen: remove dead code
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 14:30:55 +02:00
Giuseppe Scrivano
e76c8527dc
cmd: set correct parent for container exec
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-28 14:15:39 +02:00
Brent Baude
e78e66c5b9 enable volume integration tests
enabled integration tests for volumes.  there are two exceptions that still need work because of something not yet implemented.

also, add code to deal with the fact that containers conf appears to set a local volume driver where it used to be simply blank.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 16:12:06 -05:00
OpenShift Merge Robot
f6f7172494
Merge pull request #6000 from mheon/volume_backend_flags
Add support for volumes-from, image volumes, init
2020-04-27 21:53:37 +02:00
OpenShift Merge Robot
8642e256f2
Merge pull request #5978 from rhatdan/ports
Make podman container list == podman ps
2020-04-27 21:27:49 +02:00
OpenShift Merge Robot
ccf009d22e
Merge pull request #6001 from baude/v2intload
enable load integration tests
2020-04-27 20:34:39 +02:00
OpenShift Merge Robot
5554698a44
Merge pull request #5975 from giuseppe/fix-pause-tests
[v2] tests: fix pause tests
2020-04-27 20:25:14 +02:00
Matthew Heon
02671a103f Add support for volumes-from, image volumes, init
This should complete Podmanv2's support for volume-related flags.
Most code was sourced from the old pkg/spec implementation with
modifications to account for the split between frontend flags
(volume, mount, tmpfs) and the backend flags implemented here.

Also enables tests for podman run with volumes

Signed-off-by: Matthew Heon <matthew.heon@pm.me>
2020-04-27 13:13:21 -04:00
Brent Baude
6db081fc5e enable load integration tests
fix bug where multiple images can be loaded and have to be able to handle the return of multiple names

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-27 10:20:53 -05:00
OpenShift Merge Robot
ca1c674d2e
Merge pull request #5966 from vrothberg/v2-pod-stats
implement pod stats
2020-04-27 16:15:09 +02:00
Daniel J Walsh
a83d1a2772
Make podman container list == podman ps
Also make
podman create -p PUBLISHPorts
work.

This PR fixes ps_test.go

Signed-off-by: Daniel J Walsh <dwalsh@redhat.com>
2020-04-27 09:51:26 -04:00
OpenShift Merge Robot
fdf64f0c66
Merge pull request #5994 from giuseppe/fix-healthchecks
v2, podman: fix healthchecks
2020-04-27 15:40:24 +02:00
OpenShift Merge Robot
529824ec1e
Merge pull request #5997 from giuseppe/fix-pod-create
v2, podman: fix a bunch of "podman pod *" tests
2020-04-27 15:37:58 +02:00
OpenShift Merge Robot
ef46687dc5
Merge pull request #5976 from QiWang19/manifest-add-os
Add --os to manifest add
2020-04-27 15:33:00 +02:00
Giuseppe Scrivano
408d1328e2
spec: propagate --no-hosts to specgen
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 12:58:01 +02:00
Valentin Rothberg
7ee0f7e14c implement pod stats
Implement pod stats for the local and remote client. Both code paths end
up in infra/abi to allow for code share.

Signed-off-by: Valentin Rothberg <rothberg@redhat.com>
2020-04-27 12:00:35 +02:00
Giuseppe Scrivano
edbdbe5b3a
cmd, ps: add .Status as synonym for .State
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 11:59:21 +02:00
Giuseppe Scrivano
eab41cac6f
podman: handle --no-healthcheck
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 11:31:46 +02:00
Giuseppe Scrivano
350727570b
podman: special case health-cmd none
now we have to pass down this information to libpod

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-27 11:21:55 +02:00
Brent Baude
0e82dece77 enable run_restart integration tests
also, correct arg processing mistake in start

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-26 10:44:17 -05:00
Brent Baude
942a3ef588 Enable pod ps integration tests
Enable integration tests for pod ps.

In addition, fixed bug where output was still using slice go template routines and would fail when no infra container was present.  Added integration test to prevent future regressions.

Signed-off-by: Brent Baude <bbaude@redhat.com>
2020-04-25 13:13:32 -05:00
OpenShift Merge Robot
2afe579c06
Merge pull request #5971 from giuseppe/fix-userns-tests
v2, podman: fix and enable all run_userns_test.go tests
2020-04-24 22:39:26 +02:00
Qi Wang
2f3734b143 Add --os to manifest add
Add --os to manifest add for overriding the os field.

Signed-off-by: Qi Wang <qiwan@redhat.com>
2020-04-24 14:57:56 -04:00
Giuseppe Scrivano
88f1994ab9
podman: assume user namespace if there are mappings
if some mappings are specified, assume there is a private user
namespace.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:55:38 +02:00
Giuseppe Scrivano
64d8b4eebb
podman: implement userns=keep-id
add missing implementation for userns=keep-id and enable the user
namespaces tests.

Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 15:03:50 +02:00
Giuseppe Scrivano
3eeb03d1f9
podman: fix --log-opt=path=%s
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 13:02:07 +02:00
Giuseppe Scrivano
145d74716c
podman: fix --http-proxy
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:24 +02:00
Giuseppe Scrivano
a1f73d0954
podman: fix podman --group-add
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:23 +02:00
Giuseppe Scrivano
2e6a62fc38
podman: fix --cgroups=disabled
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:21 +02:00
Giuseppe Scrivano
a3acc4f977
podman: add support for --rootfs
Signed-off-by: Giuseppe Scrivano <gscrivan@redhat.com>
2020-04-24 12:56:20 +02:00