From cee109e25500a03076e08a0a53289cbfd59f0af6 Mon Sep 17 00:00:00 2001
From: Mario Loriedo <mario.loriedo@gmail.com>
Date: Fri, 17 Jul 2026 16:32:10 +0200
Subject: [PATCH] Windows installer: remove unused IS_UPGRADE property

This is a followup after @lstocchi comment:

https://github.com/podman-container-tools/podman/pull/29169#discussion_r3588942348

The property `IS_UPGRADE` isn't set and was a leftover of the legacy
windows installer.

Signed-off-by: Mario Loriedo <mario.loriedo@gmail.com>
---
 contrib/win-installer/wix/podman-main.wxs | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/contrib/win-installer/wix/podman-main.wxs b/contrib/win-installer/wix/podman-main.wxs
index bf7b6a5abc..2c4e539ad7 100644
--- a/contrib/win-installer/wix/podman-main.wxs
+++ b/contrib/win-installer/wix/podman-main.wxs
@@ -66,14 +66,14 @@ and other data will be preserved." />
 				Action="SetCONFDIR_User"
 				Value="[AppDataFolder]containers\containers.conf.d"
 				Before="AppSearch"
-				Condition="MSIINSTALLPERUSER=1 AND NOT IS_UPGRADE"
+				Condition="MSIINSTALLPERUSER=1"
 				Sequence="first" />
 
 		<SetProperty Id="CONFDIR"
 				Action="SetCONFDIR_Machine"
 				Value="[CommonAppDataFolder]containers\containers.conf.d"
 				Before="AppSearch"
-				Condition="ALLUSERS=1 AND NOT MSIINSTALLPERUSER=1 AND NOT IS_UPGRADE"
+				Condition="ALLUSERS=1 AND NOT MSIINSTALLPERUSER=1"
 				Sequence="first" />
 
 		<!--
@@ -81,6 +81,7 @@ and other data will be preserved." />
 			The machine provider config file is created (or is not deleted if it already exist) if these conditions are met:
 				- The user hasn't set property `SKIP_CONFIG_FILE_CREATION` to 1
 				- The main executable file (<PFILESDIR>/Podman/podman.exe) doesn't exist or, if it exists, the machine provider config file exists
+			Note: if the podman.exe exists AND the config file exists we must set to 1 or the installer deletes the existing config file ¯\_(ツ)_/¯
 		-->
 		<SetProperty Id="CREATE_MACHINE_PROVIDER_CONFIG_FILE"
 			After="AppSearch"