erabo/spiegel_podman
1
0
Fork 0
mirror of https://github.com/podman-container-tools/podman.git synced 2026-09-19 06:07:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Add a binding test to check image tag and list commands.

Browse source 
Include testcase to validate tag api responses and check if
all the image instaces are shown list command.
Also, Update the binding process and the response

Signed-off-by: Sujil02 <sushah@redhat.com>
This commit is contained in:
Sujil02 2020-01-30 18:06:44 -05:00
parent 23f7957862
commit 68287ff8bd
2 changed files with 36 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
pkg/bindings/errors.go
View file

@ -3,7 +3,6 @@ package bindings
import (
"encoding/json"
"io/ioutil"
"net/http"
"github.com/containers/libpod/pkg/api/handlers/utils"
"github.com/pkg/errors"
@ -26,7 +25,7 @@ func (a APIResponse) Process(unmarshalInto interface{}) error {
if err != nil {
return errors.Wrap(err, "unable to process API response")
}
if a.Response.StatusCode == http.StatusOK {
if a.IsSuccess() {
if unmarshalInto != nil {
return json.Unmarshal(data, unmarshalInto)
}

35
pkg/bindings/test/images_test.go
View file

@ -89,4 +89,39 @@ var _ = Describe("Podman images", func() {
})
//Tests to validate the image tag command.
It("tag image", func() {
// Validates if invalid image name is given a bad response is encountered.
err = images.Tag(connText, "dummy", "demo", "alpine")
Expect(err).ToNot(BeNil())
code, _ := bindings.CheckResponseCode(err)
Expect(code).To(BeNumerically("==", 404))
// Validates if the image is tagged sucessfully.
err = images.Tag(connText, "alpine", "demo", "alpine")
Expect(err).To(BeNil())
//Validates if name updates when the image is retagged.
_, err := images.GetImage(connText, "alpine:demo", nil)
Expect(err).To(BeNil())
})
//Test to validate the List images command.
It("List image", func() {
//Array to hold the list of images returned
imageSummary, err := images.List(connText, nil, nil)
//There Should be no errors in the response.
Expect(err).To(BeNil())
//Since in the begin context only one image is created the list context should have only one image
Expect(len(imageSummary)).To(Equal(1))
//To be written create a new image and check list count again
//imageSummary, err = images.List(connText, nil, nil)
//Since in the begin context only one image adding one more image should
///Expect(len(imageSummary)).To(Equal(2)
})
})