From 1b0f66cca11808b9445c608d77b042c219bad8a1 Mon Sep 17 00:00:00 2001 From: Animesh Parashar Date: Fri, 31 Jul 2026 20:54:07 +0530 Subject: [PATCH] Makefile: build ginkgo before running localunit make localunit fails on a clean checkout: $ git clean -xfd && make localunit /usr/bin/bash: line 1: ./bin/ginkgo: No such file or directory make: *** [Makefile:675: localunit] Error 127 The recipe runs $(GINKGO) but the target never declared it. ginkgo-run, testbindings and system.test-binary all declare .install.ginkgo; localunit did not. hack/ci/runner.sh worked around this by running make .install.ginkgo before $SUDO make localunit. That workaround is no longer needed. Signed-off-by: Animesh Parashar --- Makefile | 2 +- hack/ci/runner.sh | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/Makefile b/Makefile index d99876d2e4..18527abc57 100644 --- a/Makefile +++ b/Makefile @@ -670,7 +670,7 @@ run-docker-py-tests: rm -f test/__init__.py .PHONY: localunit -localunit: test/goecho/goecho test/version/version ## Run unit tests with coverage +localunit: .install.ginkgo test/goecho/goecho test/version/version ## Run unit tests with coverage rm -rf ${COVERAGE_PATH} && mkdir -p ${COVERAGE_PATH} UNIT=1 $(GINKGO) \ -r \ diff --git a/hack/ci/runner.sh b/hack/ci/runner.sh index 179297a31a..3d2870a0cf 100755 --- a/hack/ci/runner.sh +++ b/hack/ci/runner.sh @@ -190,7 +190,6 @@ function run_docker_py() { } function run_unit() { - make .install.ginkgo $SUDO make localunit }