ci: bump golangci-lint to v2.9.0

Apparently, prealloc got much smarter in this version, so let's disable it for _test.go files as we're not really interested in micro-optimizations for the test code.

The rest of its warnings is being fixed by the earlier commits.

Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>

(cherry picked from commit 0ba42fe487)
Signed-off-by: Lokesh Mandvekar <lsm5@redhat.com>

.golangci.yml

@@ -85,6 +85,9 @@ linters:
       - linters:
           - recvcheck
         path: pkg/k8s.io/
+      - path: _test\.go
+        linters:
+          - prealloc
 
 issues:
   max-issues-per-linter: 0

Makefile

@@ -71,7 +71,7 @@ BUILDTAGS += ${EXTRA_BUILDTAGS}
 # N/B: This value is managed by Renovate, manual changes are
 # possible, as long as they don't disturb the formatting
 # (i.e. DO NOT ADD A 'v' prefix!)
-GOLANGCI_LINT_VERSION := 2.5.0
+GOLANGCI_LINT_VERSION := 2.9.0
 PYTHON ?= $(shell command -v python3 python|head -n1)
 PKG_MANAGER ?= $(shell command -v dnf yum|head -n1)
 # ~/.local/bin is not in PATH on all systems

libpod/lock/in_memory_locks.go

@@ -133,7 +133,6 @@ func (m *InMemoryManager) AvailableLocks() (*uint32, error) {
 // Get any locks that are presently being held.
 // Useful for debugging deadlocks.
 func (m *InMemoryManager) LocksHeld() ([]uint32, error) {
-	//nolint:prealloc
 	var locks []uint32
 
 	for _, lock := range m.locks {