mirror of
https://github.com/keymanapp/keyman.git
synced 2026-08-06 08:55:34 +00:00
PR #13860 fixed a similar error by adding a check for NaN. However, it missed doing it for `layoutWidth` and only changed `layoutHeight`. This PR adds a similar check to `layoutWidth` and will thus fix the error we're still seeing in Sentry. The same error could potentially happen in `internalHeight`, so we add the check for NaN there as well. Addresses code review comments. Also add unit tests for all three methods. # User Testing TEST_INUKTITUT_KEYBOARD: Using Keyman for Android, install the `inuktitut_pirurvik` and verify that no error notifications appear. Fixes: #14108 Fixes: [KEYMAN-WEB-RA](https://keyman.sentry.io/issues/6579536471/?referrer=github_integration) Cherry-pick-of: #14684 |
||
|---|---|---|
| .. | ||
| app | ||
| engine | ||
| resources | ||
| samples | ||
| test | ||
| tools | ||
| .editorconfig | ||
| tsconfig.all.json | ||
| tsconfig.dom.json | ||