mirror of
https://github.com/keymanapp/keyman.git
synced 2026-08-11 19:35:32 +00:00
c66eb49163
This is the first half of a two-part update to Keyman for Windows. There are two significant changes here. These changes apply to keyman32/keyman64, as well as kmtip/kmtip64, but will refer to the 32-bit equivalents for simplicity: 1. Instead of using `GetProcAddress` to connect to keyman32.dll, we now have an import library connection. This removes one particularly suspect piece of architecture for Keyman, as using `GetProcAddress` could lead to a race condition, where keyman32.dll is unloaded after that function is called but before we use the handle. This makes the kmtip.dll build dependent on keyman32.dll; loading kmtip.dll (by selecting a Keyman input method) also loads keyman32.dll. 2. It's not enough (yet) to load kmtip.dll. We also need to be running keyman.exe itself, due to global hooks that we still require (it may be possible, one day, to avoid these, but it doesn't look very hopeful). To that end, kmtip calls new function `TIPIsKeymanRunning` to check whether keyman32.dll is initialised (and hence keyman.exe has initialised it). Then, if keyman.exe is not running, it issues an event to the Windows Event Log, which we will pick up with a scheduled task in the next PR. The first part of this is an architectural change which may lead to some change in behaviours, as keyman32.dll now may not be unloaded from a process when keyman.exe exits, due to the lock that kmtip.dll now has on it. It will be important to test this (@MakaraSok) by running through various startup and shutdown scenarios. In my initial testing, I found that there were some situations after restarting keyman.exe where I needed to switch in and out of the Keyman TIP, but those were not all critical. This change also lays groundwork for an eventual ability to run the Keyman input method without keyman.exe running, which will be helpful e.g. on login screen, even if missing certain additional functionality such as the serialised input queue.
42 lines
948 B
MonkeyC
42 lines
948 B
MonkeyC
; // Keymanmc.mc
|
|
|
|
; // This is the header section.
|
|
|
|
|
|
SeverityNames=(Success=0x0:STATUS_SEVERITY_SUCCESS
|
|
Informational=0x1:STATUS_SEVERITY_INFORMATIONAL
|
|
Warning=0x2:STATUS_SEVERITY_WARNING
|
|
Error=0x3:STATUS_SEVERITY_ERROR
|
|
)
|
|
|
|
|
|
FacilityNames=(System=0x0:FACILITY_SYSTEM
|
|
Runtime=0x2:FACILITY_RUNTIME
|
|
Stubs=0x3:FACILITY_STUBS
|
|
Io=0x4:FACILITY_IO_ERROR_CODE
|
|
)
|
|
|
|
LanguageNames=(English=0x409:MSG00409)
|
|
|
|
|
|
; // The following are the categories of events.
|
|
|
|
MessageIdTypedef=WORD
|
|
|
|
MessageId=0x1
|
|
SymbolicName=SIMPLE_CATEGORY
|
|
Language=English
|
|
Default
|
|
.
|
|
|
|
; // The following are the message definitions.
|
|
|
|
MessageIdTypedef=DWORD
|
|
|
|
MessageId=0x100
|
|
Severity=Informational
|
|
Facility=Runtime
|
|
SymbolicName=MSG_START_KEYMAN_ON_DEMAND
|
|
Language=English
|
|
A Keyman input method has been activated while Keyman was not running; now attempting to start Keyman.
|
|
.
|