Commit graph

71 commits

Author SHA1 Message Date
Marc Durdin
307f600f43
Merge pull request #13663 from MattGyverLee/feat/android/keyboard-min-max
fix(android): address keyboard height vs touch height race after keyboard height preference change (also min max heights + docs)
2025-12-01 14:22:25 +01:00
Darcy Wong
fd7c1b3683 docs(android): Document Keyman API for keyboard font change 2025-11-28 10:55:54 +07:00
Matthew Lee
d2b40bd3c1
Update android/docs/engine/KMManager/getKeyboardHeightMin.md
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
2025-11-25 02:39:28 -06:00
Claude
99704c4ec2
fix(android): resolve PR review comments for keyboard height min/max
Addresses review feedback from Marc and Darcy:

- Add JavaDoc comments to getKeyboardHeightMin() and getKeyboardHeightMax()
  explaining the purpose, parameters, and return values
- Implement separate pending height tracking per keyboard type (in-app/system)
  and orientation (portrait/landscape) instead of a single flag
- Add four preference keys following KMKey_ naming convention:
  KMKey_PendingHeightUpdate_InappPortrait, KMKey_PendingHeightUpdate_InappLandscape,
  KMKey_PendingHeightUpdate_SystemPortrait, KMKey_PendingHeightUpdate_SystemLandscape
- Create helper function getPendingHeightKey() to determine the correct key
- Create setPendingHeightUpdate() and getAndClearPendingHeightUpdate() functions
- Fix applyKeyboardHeight() to use new helper functions and remove broken
  heightApplied variable and duplicate pending height logic
- Update KMKeyboard.onResume() to use getAndClearPendingHeightUpdate()
- Add documentation links for getKeyboardHeightMin and getKeyboardHeightMax
  in index.md
2025-11-24 23:14:52 +00:00
Matthew Lee
43bb10d967
Update android/docs/engine/KMManager/getKeyboardHeightMin.md
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
2025-11-23 19:25:36 -06:00
Matthew Lee
6be82ac9b8 Adding Docs for getKeyboardHeightMin/max & updating webview height
Handling invalid orientations

updating orientation logic

refresh webview height if ApplyKeyboardHeight() has been applied without KB active

I ran into a bug building this code into app-builders and fixed it downstream. This commit pushes it upstream.

While resize dialog is open:
- Keyboard WebView is NOT loaded (isKeyboardLoaded() == false)
- ACTION_UP saves to SharedPreferences:  Works
 -But skips WebView layout update:  Because keyboard not loaded
 - User exits dialog, keyboard appears:
    - If the keyboard WebView loads and reads from SharedPreferences properly:  Works
    - But if there's a timing issue or the WebView had old layout params cached:  Touch zone mismatch
2025-11-21 14:50:03 -06:00
Darcy Wong
32de05a385 docs(android): Rearrange section and add Sentry blurb 2025-11-11 15:42:58 +07:00
Darcy Wong
1c5fc9d6fc
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-11-11 15:03:41 +07:00
Darcy Wong
61eb2d9090 docs(android): Document disclaimer of Keyman containing adware/spyware 2025-11-11 14:37:05 +07:00
Darcy Wong
7226d27145 docs(android): Update getNavigationBarHeight API 2025-10-08 05:35:31 +07:00
Darcy Wong
7e08782703 docs(android): Document getNavigationBarHeight API 2025-09-25 14:54:05 +07:00
Darcy Wong
c4a156b692
Update android/docs/help/basic/config/index.md
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-08-19 06:56:43 +07:00
Darcy Wong
d827d2f796 docs(android): Add "Show On-screen keyboard" to in-app help 2025-08-18 11:18:34 +07:00
Darcy Wong
c472b5a03d docs(android): Update system-requirements help on minimum Chrome version 2025-07-23 08:48:24 +07:00
Marc Durdin
9d4214c54c chore: Merge remote-tracking branch 'origin/master' into chore/merge-beta-to-master-release-prep 2025-04-22 13:16:21 +07:00
Marc Durdin
4f829f5c8f chore: Merge remote-tracking branch 'origin/master' into chore/merge-beta-to-master-b18s5 2025-04-21 07:13:35 +07:00
Darcy Wong
0affbd6d4b docs(android): Update documentation 2025-04-11 11:07:17 +07:00
Darcy Wong
f03096a34f docs(android): Add xxxhdpi keyboard height 2025-04-04 14:11:01 +07:00
Darcy Wong
3bd69f182e fix(android): Adjust keyboard height for 10" tablet landscape 2025-04-04 08:36:05 +07:00
Darcy Wong
8cc35dfdf3 fix(android): Adjust keyboard and banner height for 7" tablet 2025-04-04 07:42:54 +07:00
Darcy Wong
3d127f0f7d docs(android): Update table documentation 2025-04-03 11:12:35 +07:00
Darcy Wong
b5e30b7c83 docs(android): Update table 2025-04-03 09:55:33 +07:00
Darcy Wong
231d9e3b6b
Merge branch 'beta' into cherrypick/android/13578-adjust-keyboard-height 2025-04-03 09:44:29 +07:00
Darcy Wong
e894f79880
Merge pull request #13592 from keymanapp/fix/android/430dpi
fix(android): Add dimensions for 320+dpi phones in landscape
2025-04-02 08:41:00 +07:00
Marc Durdin
690d62ca3f fix(android): Move responsibility for setting keyboard height preference
Cherrypick of #13578 to beta

Moves responsibility for setting keyboard height preference into `applyKeyboardHeight()`
2025-04-01 14:10:55 +07:00
Marc Durdin
8dbca1b651
Merge branch 'master' into fix/kmea/13511/applykeyboardHeight 2025-04-01 06:02:54 +07:00
Matthew Lee
527f8e0d7a Current Height Refactor
Avoiding multiple calls to system prefs.
2025-03-28 21:01:30 -04:00
Matthew Lee
776bb381ff Docs for getDefaultKeyboardHeight() 2025-03-28 20:19:45 -04:00
Matthew Lee
61ec797597
Update android/docs/engine/KMManager/getKeyboardHeight.md
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-03-28 19:22:13 -04:00
Marc Durdin
a52437c407 chore: Merge branch 'master' into chore/b18s4-merge-beta-to-master 2025-03-29 05:38:08 +07:00
Matthew Lee
0cb5a17971 Updating docs for Adjust Keyboard Height feature 2025-03-27 23:21:43 -04:00
Darcy Wong
9a4bc0c049 docs(android): Update table 2025-03-28 09:56:08 +07:00
Matthew Lee
908d17099e Drafting docs for overloads. 2025-03-27 09:59:15 -04:00
Matthew Lee
8cd1518e24
Update android/docs/engine/KMManager/applyKeyboardHeight.md
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-03-27 09:00:39 -04:00
Matthew Lee
8e523aff89 Reverting to removing height values. 2025-03-26 00:34:11 -04:00
Matthew Lee
d84901fdc1
Update android/docs/engine/KMManager/applyKeyboardHeight.md
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-03-25 20:27:19 -04:00
Matthew Lee
c09df23fbc update docs for applyKeyboardHeight() 2025-03-25 10:51:24 -04:00
Darcy Wong
75bf69bfbf fix(android): Cleanup comments
Cleanup references to mayPredictOverride in comments
2025-03-24 10:27:50 +07:00
Darcy Wong
009829a842 docs(android): Update Keyman Engine for Android API
Documents added getPredictionsSuspended() and setPredictionsSuspended() API calls for Keyman 18.0
2025-03-24 08:57:14 +07:00
Marc Durdin
1a0b830c0b
Merge branch 'master' into chore/b18s3-merge-beta-to-master 2025-03-14 08:54:50 +07:00
Darcy Wong
84f7da519a docs(common): Update Sentry links to keyman.sentry.io
The previous redirect from sentry.keyman.com is long-gone, so this updates all the links.
2025-03-13 16:33:52 +07:00
Darcy Wong
1380597be2
Merge branch 'beta' into chore/common/crowdin-vi 2025-03-05 19:45:39 +07:00
Marc Durdin
f61a104acf
Merge branch 'master' into chore/merge-beta-into-master-B18S2 2025-03-01 15:45:19 +07:00
Darcy Wong
417be635bd
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-03-01 07:58:13 +07:00
Darcy Wong
4a73bc3ffc docs(android): document control flag for system keyboard picker and task 2025-02-28 09:30:46 +07:00
Darcy Wong
0674317a00 chore(android): Add PR number 2025-02-22 07:49:30 +07:00
Darcy Wong
40d166f873 fix(android): Add Vietnamese 2025-02-22 07:45:46 +07:00
Darcy Wong
83f886f643
Update android/docs/engine/KMManager/setLongpressDelay.md
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-02-13 16:06:50 +07:00
Darcy Wong
aca4ed0861 docs(android): Document removing sendOptionsToKeyboard API 2025-02-13 15:31:21 +07:00
Marc Durdin
342f216291 chore: increment to alpha 19.0 2025-02-11 14:14:15 +07:00