Commit graph

3803 commits

Author SHA1 Message Date
Marc Durdin
881e08282a
Merge pull request #14795 from keymanapp/feat/windows/14787-improve-startup-time
feat(windows): improve startup time by caching locale names
2025-09-26 09:09:24 +02:00
rc-swag
96a28feeed
Merge pull request #13573 from keymanapp/fix/windows/13376-language-Selector-setup-is-not-sorted
fix(windows): sort setup UI language selector according to language names
2025-09-26 15:28:13 +10:00
Marc Durdin
39b4d630dd docs(windows): add documentation for localization functions
Build-bot: skip
2025-09-25 09:46:24 +02:00
Marc Durdin
914bf6a8a4 fix(windows): disable .msi shortcut advertisement
Change Keyman shortcuts to standard Windows shortcuts, rather than
advertised shortcuts, to work around a problem with advertised shortcuts,
elevated custom actions, and non-admin users, as described in #14791.

The problem is related to advertised shortcuts in Windows Installer. When
you have an advertised shortcut, the first use of the shortcut triggers a
repair to prepare the app for use in the new user's context. And now, with
Aug 2025 Windows security patch KB5063878, tweaked in Sep 2025, this
triggers an elevation dialog, which the non-admin user cannot work around.

This means that the shortcuts will be regular Windows shortcut files rather
than advertised shortcuts, and are added to
`%ProgramData%\Microsoft\Windows\Start Menu\Programs\Keyman for Windows`
(so, available for all users on that machine, but will not follow a user
across machines).

* DISABLEADVTSHORTCUTS: https://learn.microsoft.com/en-us/windows/win32/msi/disableadvtshortcuts
* Shortcut advertisement: https://learn.microsoft.com/en-us/windows/win32/msi/advertisement

Relates-to: #14809
Fixes: #14791
Build-bot: skip release:windows
2025-09-25 09:04:37 +02:00
rc-swag
c5b82bd01a
fix(windows): minor review comments 2025-09-25 14:29:23 +10:00
Marc Durdin
ad9ab53c72 feat(windows): improve startup time by caching locale names
This was flagged years ago as a potential performance hotspot: each
locale is loaded at process start for any kmcomapi-involved process,
which takes quite a long time. This refactor moves the locale
enumeration out of kmcomapi and into the build process, so we have a
static list of locales put into locale/index.xml.

This includes a minor breaking change to Keyman Engine API on Windows:
`MessageFromID(id, locale)` now only allows the three ids
SKUILanguageName, SKUILanguageNameWithEnglish, and SKLanguageCode, for
performance reasons. At this point, only SKUILanguageNameWithEnglish is
actually used anywhere in Keyman, and it is unlikely that any other
consumers are requesting alternate IDs.

Fixes: #14787
Build-bot: skip release:windows
2025-09-19 14:11:37 +02:00
sze2st
a8c8f6c776
Merge branch 'master' into fix/windows/13376-language-Selector-setup-is-not-sorted 2025-09-17 09:40:41 +02:00
EberhardSchweizer07@gmail.com
0ce8e1b876 fix(windows): remove FSortedDisplayValues and related function
SortedDisplayValues and its related references
2025-09-15 11:14:54 +02:00
sze2st
33fe208338
Update windows/src/desktop/setup/Keyman.Setup.System.SetupUILanguageManager.pas
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2025-09-15 10:17:15 +02:00
sze2st
b4fbe54d73
Update windows/src/desktop/setup/Keyman.Setup.System.SetupUILanguageManager.pas
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2025-09-15 10:13:26 +02:00
sze2st
5389795ff3
Update windows/src/desktop/setup/Keyman.Setup.System.SetupUILanguageManager.pas
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2025-09-15 10:12:06 +02:00
sze2st
c5099bfceb
Update windows/src/desktop/setup/Keyman.Setup.System.SetupUILanguageManager.pas
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2025-09-15 10:09:42 +02:00
sze2st
45f0686adb
Update windows/src/desktop/setup/Keyman.Setup.System.SetupUILanguageManager.pas
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2025-09-15 10:05:52 +02:00
Marc Durdin
377b1056ec maint(resources): rename KEYMAN_VERSION_FOR_PR_FILENAME
Address review comment from #14703.

Test-bot: skip
Build-bot: skip
Relates-to: #14703
Relates-to: #10521
2025-09-10 11:17:41 +02:00
Marc Durdin
50f86cfbf7
Merge pull request #14703 from keymanapp/maint/android/10521-use-versioned-filenames-for-pr-artifacts
maint(android): use versioned filenames for PR artifacts
2025-09-10 11:15:02 +02:00
Marc Durdin
e425de71af
Merge pull request #14702 from keymanapp/maint/windows/10521-use-versioned-filenames-for-pr-artifacts
maint(windows): use versioned filenames for PR artifacts
2025-09-10 11:14:51 +02:00
rc-swag
2c34a7f1d4
Merge pull request #14644 from keymanapp/fix/windows/14578/waitingrestart-idle-kmshellcontinue
fix(windows): kmshell continues when sm is in waitingrestart  and returns to idle
2025-09-10 11:09:42 +10:00
rc-swag
96507a433b
update(windows): review comment
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-09-09 21:00:49 +10:00
rc-swag
4d38b254e5 fix(windows): fix confusing code comments 2025-09-09 12:04:16 +10:00
Marc Durdin
634fef64d4 maint(android): use versioned filenames for PR artifacts
Relates-to: #10521
Test-bot: skip
Build-bot: skip release:android,developer,windows
2025-09-08 12:31:11 +02:00
Marc Durdin
e6d9d8c32a maint(windows): use versioned filenames for PR artifacts
Relates-to: #10521
Test-bot: skip
Build-bot: skip release:windows
2025-09-08 10:20:42 +02:00
EberhardSchweizer07@gmail.com
1b18514f3e fix(windows): add ssLanguageNameInEnglish and use it for sorting/displaying in setup's ComboBox 2025-09-06 21:19:36 +02:00
rc-swag
3ea8756192 fix(windows): refactor ReadyToInstall
It became apparent that we need to abort the "waitingtorestart" state
before promting the user if they want to install. Otherwise it is
confusing as to why nothing happens and Keyman just starts.
In doing that it was easier to refactor ReadyToInstall to validate the
cache, and check that automatic updates was still set.
It can now also trigger an abort clearing the cache and returning to
idle. This has slight flow on effect in that the HandleKMShell event
can still be called following in the exectution flow.
2025-09-04 14:30:12 +10:00
Marc Durdin
f420f15567 docs(common): update license date and owner
Fixes: #14665
Test-bot: skip
Build-bot: skip
2025-09-02 16:13:36 +02:00
rc-swag
c6a207ac76
Merge branch 'master' into fix/windows/14578/waitingrestart-idle-kmshellcontinue 2025-09-02 14:23:54 +10:00
Marc Durdin
7084eb25b5 maint(windows): for build buildlevel, do not publish artifacts
Build-bot: skip build:windows
Test-bot: skip
2025-09-01 06:06:47 +02:00
rc-swag
017a26435e fix(windows): continue when waitingrestart return to idle
When waiting restart on a handlekmshell event and returning to idle
kmshell execution should continue
2025-08-29 15:45:50 +10:00
Marc Durdin
52310ce6d0
Merge branch 'master' into fix/windows/dont-prompt-updates-off 2025-08-25 05:06:43 +02:00
Marc Durdin
00b98f2286 fix(windows): emit nunit report path correctly and update TeamCity links
* Windows and Developer sources
* Fixes the report path to be fully qualified
* Adds the TeamCity report logger to remaining DUnitX automated tests

Fixes: #14197
Build-bot: skip build:windows,developer
Test-bot: skip
2025-08-20 07:21:03 +02:00
Marc Durdin
81c807c257 chore(common): Merge branch 'master' into maint/common/14453-move-ci-scripts 2025-08-19 10:46:11 +02:00
rc-swag
aadfe4c7cc
fix(windows): commit review suggestions
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-08-19 14:01:18 +10:00
Marc Durdin
a81138c62b
Merge pull request #14449 from keymanapp/maint/common/14065-consolidate-builder-scripts
maint(common): consolidate builder scripts 🐸
2025-08-12 10:41:09 +07:00
Marc Durdin
f95b26ac1f
Merge pull request #14446 from keymanapp/maint/common/14275-rename-and-cleanup-shellHelperFunctions.sh
maint(common): rename shellHelperFunctions.sh to utils.inc.sh 🐸
2025-08-12 10:40:59 +07:00
EberhardSchweizer07@gmail.com
6fcf882e30 fix(windows): avoid calling FIndexMapping.Clear twice 2025-08-11 15:30:19 +02:00
sze2st
3ecc2dcc51
Update windows/src/desktop/setup/Keyman.Setup.System.SetupUILanguageManager.pas
Co-authored-by: rc-swag <58423624+rc-swag@users.noreply.github.com>
2025-08-11 11:57:37 +02:00
EberhardSchweizer07@gmail.com
aaa89e0947 fix(windows): rework on memory management and added comments 2025-08-11 11:48:52 +02:00
EberhardSchweizer07@gmail.com
14aa49f773 fix(windows): rework based on comments from review 2025-08-06 20:06:26 +02:00
Darcy Wong
afd4256ce6 chore(common): Update Crowdin strings for Spanish 2025-08-06 11:36:52 +07:00
Marc Durdin
f3fb3ac87b maint(common): move build-utils-ci.inc.sh to ci/ci-publish.inc.sh
Removes a number of unused functions from the file, renames remaining
functions to match our builder script prefix patterns, removes unused
imports from various build scripts (e.g. Android).

Fixes: #14453
2025-08-05 12:54:56 +10:00
Marc Durdin
f394245636 maint(common): consolidate builder scripts
Clarifies the confusing builder.inc.sh / build-utils.sh distinction by
giving the scripts more appropriate names. Most build scripts should use
builder-full.inc.sh; some helper scripts can use builder-basic.inc.sh.
Documented in resources/build/README.md.

Renames:
* resources/build/builder.inc.sh to resources/build/builder-full.inc.sh
* resources/build/build-utils.sh to resources/build/builder-basic.inc.sh

Other changes:
* Moves Android-specific functions out of builder-basic.inc.sh and into
  android/build.sh.
* Renames functions in builder-basic.inc.sh

More functions may be moved from builder-basic.inc.sh into utils.inc.sh
or other scripts in the future.

Fixes: #14065
Build-bot: build all
Test-bot: skip
2025-08-02 08:11:24 +10:00
Marc Durdin
65158a0526 maint(common): rename shellHelperFunctions.sh to utils.inc.sh
Adds documentation for various functions, removes unused functions (a
couple of simple, very lightly used functions were unDRYed; these could
go back the other way across all shell scripts if necessary). TODO items
noted for follow-up refactoring.

Fixes: #14275
Relates-to: #14269
Build-bot: build all
Test-bot: skip
2025-08-02 06:58:40 +10:00
rc-swag
8889bad33c
Merge branch 'master' into fix/windows/dont-prompt-updates-off 2025-07-30 15:50:34 +10:00
rc-swag
ad962172e9 fix(windows): remove dead code 2025-07-28 16:54:37 +10:00
rc-swag
f38145eaa2
Merge branch 'master' into fix/windows/14342/invalid-data-type-for-regkey 2025-07-25 10:58:55 +10:00
rc-swag
3c311a5aaa fix(windows): free the correct object KeyboardToggleReg 2025-07-24 16:59:41 +10:00
rc-swag
9807d5e137 fix(windows): add early return if SM abort is called
If it has been determined the user turned off automatic
updates in the function ShouldSendToBUpdateSM then it shall
return early.
2025-07-24 16:19:23 +10:00
Eberhard Beilharz
b6c0c68af3
maint(windows): cd before adding to zip 2025-07-22 18:09:41 +02:00
Eberhard Beilharz
e4c1867583
maint(windows): remove another (unused) include of win/zip.inc.sh
Addresses code review comment.
2025-07-21 10:26:32 +02:00
Eberhard Beilharz
4a2cf53fbc
maint(windows): replace use of wzzip with add_zip_files
This makes use of the new functionality refactored in the previous
commit by replacing the use of the `wzzip` function with `add_zip_files`.

Test-bot: skip
2025-07-21 10:26:31 +02:00
rc-swag
314c606aec fix(windows): add check a fix for registry datatypes
Fixes: #14342
The Windows system level keyboard hotkeys controlled in
registry have sometimes been incorrectly written as
a DWORD datatype. There 106 events in sentry for just
July. When opening the Windows setting dialog and the registry
has DWORDS it will show unassinged in the dialog if apply
is pressed it will convert the keys to REG_SZ.
This fix follows a similar pattern it will check the data
type of the registry key if it is DWORD it will remove it
and add a new key of the same name as REG_SZ and set it to
the unassigned value.

Fixes: KEYMAN-WINDOWS-4NK
2025-07-15 16:27:14 +10:00