Eberhard Beilharz
f464008326
fix(web): add check to internalHeight
...
The same error could potentially happen in `internalHeight`, so we
add the check for NaN there as well. Addresses code review comments.
2025-09-05 09:35:50 +02:00
Eberhard Beilharz
74ef39726b
fix(web): fix error trying to calculate style scaling effects
...
PR #13860 fixed a similar error by adding a check for NaN. However, it
missed doing it for `layoutWidth` and only changed `layoutHeight`. This
PR adds a similar check to `layoutWidth` and will thus fix the error
we're still seeing in Sentry.
Also add unit tests for both methods.
User Testing
============
TEST_INUKTITUT_KEYBOARD: Using Keyman for Android, install the
`inuktitut_pirurvik` and verify that no error notifications appear.
Fixes : #14108
Fixes: [KEYMAN-WEB-RA](https://keyman.sentry.io/issues/6579536471/?referrer=github_integration )
2025-09-04 17:28:15 +02:00
Joshua Horton
191db9cba9
Merge pull request #14618 from keymanapp/refactor/web/simplify-calculation-inputs
...
refactor(web): simplify edit-distance calculation-object inputs
2025-09-03 22:11:00 +07:00
Joshua Horton
770ac2a13f
Merge pull request #14592 from keymanapp/feat/web/search-subset-batching
...
feat(web): batch correction-search paths by related subsets
2025-09-03 22:10:46 +07:00
Joshua Horton
6969206701
Merge pull request #14581 from keymanapp/feat/web/transform-cataloging
...
feat(web): adds transform cataloging methods to predictive-text worker
2025-09-03 22:10:38 +07:00
Eberhard Beilharz
3e3cccc97d
Apply suggestions from code review
...
Co-authored-by: Darcy Wong <darcy_wong@sil.org>
2025-09-03 08:42:39 +02:00
Eberhard Beilharz
f166f11d14
docs(common): update docs Keyman Desktop → Keyman for Windows
...
Also change path to engine help pages. This requires a corresponding
change in help.keyman.com.
Test-bot: skip
2025-09-02 14:29:53 +02:00
Joshua Horton
6d991eeecc
fix(web): Apply unit-test suggestions from code review
...
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2025-08-28 22:46:58 +07:00
Joshua Horton
33ae31f3a4
fix(web): prevent undefined traversal entry
2025-08-28 09:32:48 -05:00
Joshua Horton
1942309356
feat(web): add unit test for empty-char inputs, matches
2025-08-28 09:15:47 -05:00
Joshua Horton
d9aebf0213
Merge branch 'feat/web/search-subset-batching' into refactor/web/simplify-calculation-inputs
2025-08-28 09:10:11 -05:00
Joshua Horton
26c787d24d
fix(web): improve unit-test setup assertions
2025-08-28 09:07:58 -05:00
Joshua Horton
820c082839
docs(web): Apply comment-oriented suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-08-28 21:03:52 +07:00
Joshua Horton
9f54ab1b25
change(web): add missing semi-colon
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-08-28 20:57:39 +07:00
Joshua Horton
82c35d0b97
refactor(web): simplify calculation-object inputs
2025-08-27 16:40:45 -05:00
Joshua Horton
a08390750f
refactor(web): track traversal history on search node, not calculation object
2025-08-27 16:08:27 -05:00
Joshua Horton
129470c5ca
docs(web): processSubsetEdge comment enhancements
2025-08-25 11:17:17 -05:00
Joshua Horton
0c85d0e4fa
Merge branch 'feat/web/transform-cataloging' into feat/web/search-subset-batching
2025-08-25 10:54:28 -05:00
Joshua Horton
c573f26e23
docs(web): clean up comments added during subset-batch PR work
2025-08-25 10:54:11 -05:00
Joshua Horton
0c3c58ae5d
docs(web): adds PartialSearchEdge type doc comment
2025-08-25 10:48:04 -05:00
Joshua Horton
e0928b2b20
feat(web): add unit tests interacting with search-term keying
2025-08-25 10:41:50 -05:00
Joshua Horton
23d682e5e2
feat(web): adds delete, substitution path unit tests for starting mid-word
2025-08-25 10:16:30 -05:00
Joshua Horton
80194c022f
fix(web): restore search-iteration unit tests
2025-08-25 09:08:42 -05:00
Joshua Horton
2fb96709f3
feat(web): implement search-node clone-constructor unit tests
2025-08-25 08:49:11 -05:00
Joshua Horton
057b6cbc1b
refactor(web): place all partial-edge properties under single object-based property
2025-08-25 08:48:48 -05:00
Joshua Horton
aa9df34623
feat(web): batch correction-search paths by related subsets
...
This change should dramatically cut down on the number of heavily-mismatched paths that the correction-search engine builds during operation. Now, whenever input characters are being matched against a character from the lexicon, they're all replaced, **together**, with a single sentinel character instance that represents them all together - with their exact accumulated probability mass.
Doing so dramatically cuts down on the rate of memory use expansion during correction-search's operation... and likely cuts down on execution time on average, allowing for more potential corrections to be considered.
2025-08-22 18:23:13 -05:00
Joshua Horton
e20bd8ebd9
feat(web): adds transform subset-building methods to predictive-text worker
...
These methods place a set of input Transforms into multiple subsets with common properties. They're designed for use in upcoming enhancements to the predictive-text worker's correction-search approach.
2025-08-22 15:38:55 -05:00
Joshua Horton
e17e014815
docs(web): improve documentation for SearchSpace and SearchNode
2025-08-19 10:49:15 -05:00
Marc Durdin
81c807c257
chore(common): Merge branch 'master' into maint/common/14453-move-ci-scripts
2025-08-19 10:46:11 +02:00
Joshua Horton
6d27c3468d
Merge branch 'refactor/web/apply-suggestion-casing' into maint/web/convert-worker-thread-tests
2025-08-14 11:01:39 -05:00
Joshua Horton
51fc6f636f
Merge branch 'fix/web/suggestion-typing' into refactor/web/apply-suggestion-casing
2025-08-14 11:00:11 -05:00
Joshua Horton
aa77e4ca0b
fix(web): remove unneeded sort from unit test
2025-08-14 10:59:45 -05:00
Joshua Horton
65885a4669
chore(web): add displayAs strings where previously unset
2025-08-14 08:32:11 -05:00
Joshua Horton
981905717a
change(web): add MAX_PROB constant for use in 'keep'-suggestion construction
2025-08-14 08:23:40 -05:00
Joshua Horton
ae469ed1b4
change(web): apply suggestion from code-review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2025-08-14 20:19:53 +07:00
Joshua Horton
87eb476ecd
change(web): eliminate extra tsconfig
...
I tried to get a multi-config setup to split off the tests that caused compilation issues in a prior commit, but I never got it working. It's best to simplify and remove the thing that didn't work.
2025-08-13 11:00:52 -05:00
Joshua Horton
c3124ec685
change(web): use contextTracker getter internally
2025-08-13 10:57:16 -05:00
Joshua Horton
ec888dd751
Merge branch 'refactor/web/apply-suggestion-casing' into maint/web/convert-worker-thread-tests
2025-08-13 10:52:57 -05:00
Joshua Horton
519e39e327
refactor(web): move applySuggestionCasing to standalone exportable method
2025-08-13 10:45:15 -05:00
Joshua Horton
e24deefdb8
fix(web): improve typing accuracy for suggestions & suggestion-generation
...
Also adds doc-comments to a couple of the related types
2025-08-13 10:27:13 -05:00
Joshua Horton
a01211efa4
change(web): improve exposure of once-private members
2025-08-13 08:49:41 -05:00
Joshua Horton
e9a1f6c349
maint(web): converts worker-thread tests to TS
2025-08-12 15:38:53 -05:00
Joshua Horton
88f3a1a716
maint(web): convert models-templates, models-wordbreakers unit tests to TS
2025-08-12 10:12:10 -05:00
Marc Durdin
942b06afdd
Merge pull request #14451 from keymanapp/maint/common/14447-node.inc.sh
...
maint(common): rename and move node-related script functions into node.inc.sh 🐸
2025-08-12 10:41:18 +07:00
Marc Durdin
a81138c62b
Merge pull request #14449 from keymanapp/maint/common/14065-consolidate-builder-scripts
...
maint(common): consolidate builder scripts 🐸
2025-08-12 10:41:09 +07:00
Marc Durdin
f95b26ac1f
Merge pull request #14446 from keymanapp/maint/common/14275-rename-and-cleanup-shellHelperFunctions.sh
...
maint(common): rename shellHelperFunctions.sh to utils.inc.sh 🐸
2025-08-12 10:40:59 +07:00
Joshua Horton
09611146dc
fix(web): legacy model unit tests should use an actual legacy model
2025-08-05 10:27:48 -05:00
Marc Durdin
f3fb3ac87b
maint(common): move build-utils-ci.inc.sh to ci/ci-publish.inc.sh
...
Removes a number of unused functions from the file, renames remaining
functions to match our builder script prefix patterns, removes unused
imports from various build scripts (e.g. Android).
Fixes : #14453
2025-08-05 12:54:56 +10:00
Marc Durdin
3c3ad4a088
maint(common): move github.inc.sh to ci/
...
Relates-to: #14453
2025-08-05 10:51:19 +10:00
Marc Durdin
2726050601
maint(common): rename and move node-related script functions into node.inc.sh
...
Consolidates the node-related script functions into node.inc.sh, as part
of cleaning up the build scripts and making them easier to maintain into
the future.
Fixes : #14447
2025-08-02 13:34:29 +10:00
