Commit graph

3221 commits

Author SHA1 Message Date
Steven R. Loomis
70ced9847a chore(developer): ldml: unit test for .run() validation
- re-run invalid-illegal.xml through compiler.run()
- ensure it fails

Fixes: #14067
2025-05-29 13:53:23 -05:00
Steven R. Loomis
c70464e23f fix(developer): ldml: make sure .run() calls compile() with postValidation
- .run() doesn't call validate() and then compile(), so it needs to call compile() with postValidation=true

Fixes: #14067
2025-05-28 20:15:33 -05:00
Steven R. Loomis
043ccf9687
Merge pull request #14054 from keymanapp/feat/developer/13940-ln-locacompiler
feat(developer): line numbers for LocaCompiler
2025-05-27 19:00:53 -05:00
Steven R. Loomis
4d9551ae07
Merge pull request #14050 from keymanapp/feat/developer/13939-ln-layrcompiler
feat(developer): line numbers for layr compiler
2025-05-27 19:00:41 -05:00
Steven R. Loomis
fd032eb9aa
Merge pull request #14048 from keymanapp/feat/developer/13938-ln-dispcompiler
feat(developer): add line numbers to disp compiler
2025-05-27 19:00:25 -05:00
Steven R. Loomis
2d93f94ab9
Merge pull request #14037 from keymanapp/feat/developer/13937-line-numbers-trancompiler
feat(developer): line numbers for tran compiler
2025-05-27 19:00:05 -05:00
Steven R. Loomis
153c03e9f5
Merge branch 'feat/developer/13939-ln-layrcompiler' into feat/developer/13940-ln-locacompiler 2025-05-27 10:54:16 -05:00
Steven R. Loomis
0674fccb05
Merge branch 'feat/developer/13938-ln-dispcompiler' into feat/developer/13939-ln-layrcompiler 2025-05-27 10:54:10 -05:00
Steven R. Loomis
a13cf744fd
Merge branch 'feat/developer/13937-line-numbers-trancompiler' into feat/developer/13938-ln-dispcompiler 2025-05-27 10:53:41 -05:00
Steven R. Loomis
28b919bce8 feat(developer): update tran compiler per code review
For: #13937
2025-05-27 10:46:16 -05:00
Marc Durdin
0a856ecd9d
Merge pull request #14044 from keymanapp/maint/13833-package.json-add-empty-scripts-tag
maint: add empty 'scripts' tag to package.json to silence warning
2025-05-27 08:13:30 +07:00
Steven R. Loomis
f9305f33f2 feat(developer): add line numbers to loca compiler
Fixes #13940
2025-05-26 13:12:40 -05:00
Steven R. Loomis
b681885eca feat(developer): add more tests to layr compiler
- check for duplicate minDeviceWidth
- check for invalid minDeviceWidth

Fixes #13939
2025-05-26 12:30:59 -05:00
Steven R. Loomis
d2af8cf41a feat(developer): add line numbers to layr compiler
Fixes #13939
2025-05-26 11:34:05 -05:00
Steven R. Loomis
577b439721 feat(developer): add line numbers to disp compiler
Fixes #13938
2025-05-26 10:44:12 -05:00
Steven R. Loomis
235b2937e9
Merge branch 'master' into feat/developer/13937-line-numbers-trancompiler 2025-05-26 10:13:45 -05:00
Steven R. Loomis
c8966c8429
Merge pull request #14036 from keymanapp/feat/developer/13936-line-numbers-varscompiler
feat(developer): add line numbers to vars compiler
2025-05-24 19:35:25 -05:00
Marc Durdin
9f15e7c7ec maint: add empty 'scripts' tag to package.json to silence warning
Also removes './' from front of gosh.js to address another npm cleanup
(from `npm pkg fix`).

Fixes: #13833
2025-05-25 06:35:28 +07:00
Steven R. Loomis
00b4de5f53 feat(developer): add line numbers to tran compiler
- move ObjectWithMetadata into symbol utils
- don't validate transforms twice (tran + bksp)

This is for #13937 but does not resolve all items
2025-05-22 17:03:40 -05:00
Steven R. Loomis
870dec3da3 feat(developer): add percentage (permille) of messages without line numbers 2025-05-22 15:54:08 -05:00
Steven R. Loomis
be9ca8323b feat(developer): add line numbers to vars compiler
- some are remaining without errors

This is for #13936 but does not resolve all items
2025-05-22 13:14:18 -05:00
Steven R. Loomis
9b957f4103
Merge branch 'master' into feat/developer/13941-keys-update-messages 2025-05-21 15:24:22 -05:00
Steven R. Loomis
d176a9dc2e feat(developer): revamp line numbers per design doc
- update the mx() signature and add jsdoc with recommendation
- fix call sites

Fixes: #13941
2025-05-21 07:51:29 -05:00
Marc Durdin
2d7484c84a maint(developer): update multer to v2.0.0
Looks like dependabot did not cleanly upgrade multer (#13982). Possibly
a bug with workspaces? Removed from package.json, npm install, re-added,
npm install to fix the issue.

See-also: #13982
2025-05-21 10:58:29 +02:00
dependabot[bot]
87a9935c28
chore(deps): bump multer from 1.4.5-lts.1 to 2.0.0
Bumps [multer](https://github.com/expressjs/multer) from 1.4.5-lts.1 to 2.0.0.
- [Release notes](https://github.com/expressjs/multer/releases)
- [Changelog](https://github.com/expressjs/multer/blob/v2.0.0/CHANGELOG.md)
- [Commits](https://github.com/expressjs/multer/compare/v1.4.5-lts.1...v2.0.0)

---
updated-dependencies:
- dependency-name: multer
  dependency-version: 2.0.0
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2025-05-20 01:45:05 +00:00
Joshua Horton
7b1310a7d5
Merge pull request #13899 from keymanapp/maint/update-mocha
maint: update mocha
2025-05-19 08:42:53 +07:00
Marc Durdin
7a393f7e27
Merge pull request #13847 from keymanapp/fix/developer/13846-remove-ngrok-mac-binary
fix(developer): remove ngrok binary at build time
2025-05-15 23:09:31 +07:00
Steven R. Loomis
158661aee1
Merge pull request #13916 from keymanapp/feat/developer/10622-line-number-meta
feat(developer):  add line number for MetaCompiler 🙀
2025-05-15 09:20:31 -05:00
Steven R. Loomis
419b43c496 feat(developer): bug fix per review
Fixes: #10622
2025-05-15 08:40:24 -05:00
Steven R. Loomis
be1668aa55
Merge branch 'feat/developer/10622-add-more-line-number-issues' into feat/developer/10622-line-number-meta 2025-05-14 16:53:03 -05:00
Steven R. Loomis
497405c4df feat(developer): fixup for api test
Fixes: #10622
2025-05-14 16:52:12 -05:00
Steven R. Loomis
30099fc75d feat(developer): add line number for meta
- made the 'x' parameter optional for some cases

Fixes: #10622
2025-05-14 16:47:54 -05:00
Steven R. Loomis
155b5558bf feat(developer): add line number for keys
- all remaining tests for KeysCompiler
- who's next?

Fixes: #10622
2025-05-14 16:25:59 -05:00
Steven R. Loomis
bdb8823eff feat(developer): add line number for keys
- restructure form loading a little bit, so that we remember the form object
- add a commented-out test that validates that offsets are actually produced

Fixes: #10622
2025-05-14 15:56:19 -05:00
Steven R. Loomis
21c87e2cdc feat(developer): add line number for Warn_CustomForm
- improve test machinery so that it ignores offsets (line number) most of the time unless retainOffsetInMessages is set
- add Warn_CustomForm() using a new model, changing 'o' to be an LKKeys
- update test with the new warning

Fixes: #10622
2025-05-14 14:33:57 -05:00
Steven R. Loomis
7f2d2b945e feat(developer): tests for offsets (line numbers in messages)
- add unit test that complains if no tests have offset(line) numbers, and whine if any don't. Also round trip tests the column number working as expected.
- rename helper withColumn() to withOffset()

Fixes: #10622
2025-05-14 08:50:32 -05:00
Joshua Horton
155c1a2b12 maint: update mocha
Some of the npm audit warnings left after #13897 require an updated `mocha` version to remedy.  As we only really use `mocha` to do unit-testing, it should be safe to update if all of our existing tests pass with the new version.

Test-bot: skip
2025-05-13 14:02:02 +07:00
Steven R. Loomis
c2b6a65f1b
Merge pull request #13375 from keymanapp/feat/developer/10622-xml-parse-line-numbers-epic-ldml
feat(developer): line numbers for XML parsing and kmc-ldml 🙀
2025-05-12 18:37:23 -05:00
Steven R. Loomis
42d9c68e2b feat(developer): fix Error() function
- swap x, o because the 'api' call getMessageDetail() is going to call with {}

Fixes: #10622
2025-05-09 16:43:59 -05:00
Steven R. Loomis
b23275d7e1 feat(developer): fix imports in ldml-keyboard-xml-reader.ts
Fixes: #10622
2025-05-09 13:32:15 -05:00
Steven R. Loomis
8ec8fb1890 feat(developer): update for line numbers
- annotate why we're calling SymbolUtils.removeSymbols()

Fixes: #10622
2025-05-09 13:09:53 -05:00
Steven R. Loomis
6194392310 feat(developer): update for line numbers
- reduce whitespace churn
- other review comments

Fixes: #10622

Co-authored-by: Marc Durdin <marc@durdin.net>
2025-05-09 13:07:51 -05:00
Steven R. Loomis
8e2eb498e3 feat(developer): update for line numbers
- reduce whitespace churn

Fixes: #10622
2025-05-09 11:41:23 -05:00
Steven R. Loomis
307288dc3b chore(developer): deps: fast-xml-parser@5.2.2
My line number changes were merged into the main branch

Fixes: #10622
2025-05-08 17:43:19 -05:00
Steven R. Loomis
ad0ea8678b feat(developer): update for line numbers
- added new DelegatingCompilerCallbacks class
- added ResolvingCompilerCallbacks which does event resolution
- added the XML file name metadata to *every object* after XML parse.

Fixes: #10622
2025-05-08 17:29:30 -05:00
Eberhard Beilharz
4d81589f48
maint(common): use unique names for Keyman version variables
Previously the builder scripts defined a readonly `VERSION` environment
variable for the Keyman version. That caused problems when another
(external) script tried to define a `VERSION` variable. We encountered
this problem when trying to move the TC build steps of a configuration
into a single script (#13399) when we tried to source `~/.nvm/nvm.sh`.

This change uses a Keyman specific prefix for the version variables and
renames `VERSION` → `KEYMAN_VERSION` etc. Unfortunately these variables
are used in a lot of places, so this turned out to be a bit of a yak
shave.

Test-bot: skip
2025-05-07 18:46:51 +02:00
Marc Durdin
2a48f54b70 fix(developer): remove ngrok binary at build time
While ngrok.exe was already removed, ngrok (mac? linux?) was still
present in node_modules.

Fixes: #13846
2025-05-07 10:55:29 +08:00
Steven R. Loomis
937573869b Merge remote-tracking branch 'upstream/master' into feat/developer/10622-xml-parse-line-numbers-epic-ldml 2025-05-05 09:28:15 -05:00
Steven R. Loomis
a401d7eec3 feat(developer): update for line numbers
- make line finder cache lazy loading
- rename LDMLResolver to LineFinderResolver

Fixes: #10622
2025-05-05 09:17:36 -05:00
Marc Durdin
43cf66a9d4
Merge pull request #13796 from keymanapp/maint/meson-versioning-improvements
maint(common): cleanup meson versioning
2025-05-02 13:39:47 +07:00