Commit graph

657 commits

Author SHA1 Message Date
Eddie Antonio Santos
eb7e9f7722
Document @keymanapp/lexical-model-types. 2019-10-05 13:41:33 -06:00
Eddie Antonio Santos
377e018ceb
Fix other build.sh. 2019-10-02 09:31:49 -06:00
Eddie Antonio Santos
556d89b11e
Fix link before install in the event of ./build.sh -clean. 2019-10-02 09:26:03 -06:00
Eddie Antonio Santos
00ccc0080f
Add set -eu and failure messages in ./build.sh(s). 2019-10-02 08:45:44 -06:00
Eddie Antonio Santos
f2f511840e
Move npm link . to dependent build.sh scripts. 2019-10-01 14:55:58 -06:00
Eddie Antonio Santos
fc633ae94d
Rename WorkerInternalModel -> LexicalModel. 2019-10-01 14:31:40 -06:00
Eddie Antonio Santos
e14d1b0fba
Do not try to build anything in build.sh! 2019-10-01 14:10:07 -06:00
Eddie Antonio Santos
2d975138ac
Setup @keymanapp/lexical-model-types for publication. 2019-10-01 14:00:15 -06:00
Eddie Antonio Santos
1ce770d958
Add a few readonly declarations.
All consumers of these APIs compile with the current set of readonly properties. It's best to make the interfaces as strict as possible right now, for a few reasons:

 1) When I get objects of a particular interface, I don't expect its properties to change. Mutability is harder to reason about than immutability.
 2) Open-closed principle: it's easier to move from a restrictive declaration to a less restrictive declaration than the other way around.
2019-10-01 13:26:39 -06:00
Eddie Antonio Santos
b9398749c1
Add SuggestionTag interface. 2019-10-01 13:13:21 -06:00
Eddie Antonio Santos
d75c04ca39
Remove worker-compiler-interfaces entirely. 2019-10-01 12:56:03 -06:00
Eddie Antonio Santos
81d8f7eb87
Completely move worker-compiler-interfaces.d.ts to lexical-model-types. 2019-10-01 12:48:19 -06:00
Eddie Antonio Santos
a630c0e249
Move common things from message.d.ts to the lexical-model-types. 2019-10-01 12:32:08 -06:00
Eddie Antonio Santos
eb6f9b53b1
Get linking to work. 2019-10-01 09:45:33 -06:00
Eddie Antonio Santos
5b58e6c236
Somehow that works. 2019-10-01 09:28:36 -06:00
Eddie Antonio Santos
c2f8767fe2
Setup scaffolding. 2019-10-01 09:15:35 -06:00
jahorton
c364fdbeec Adjusts old unit test accordingly. 2019-08-07 10:36:49 +07:00
jahorton
a454b99971 Fixes double-space bug. 2019-08-07 09:38:55 +07:00
Joshua Horton
01fc91dfcf
Merge pull request #1918 from keymanapp/lmlayer-history-notes
[LMLayer] Initial history, history.md CI check support
2019-08-01 08:18:25 +07:00
Eddie Antonio Santos
fd5173c882
Typo
Co-Authored-By: Marc Durdin <marc@durdin.net>
2019-07-31 09:40:09 -06:00
jahorton
59327fab81 Moved LMLayer history notes to KMW's history.md. 2019-07-31 14:49:33 +07:00
Eddie Antonio Santos
27e63e16b1
Be explicit about the type of punctuation defaults. 2019-07-30 10:20:36 -06:00
Eddie Antonio Santos
3017300f33
Factor out some interfaces required both by compiler and by worker to their own file. 2019-07-30 10:07:11 -06:00
Eddie Antonio Santos
13c5a4cdd5
Trie to appease IE... 2019-07-30 09:47:15 -06:00
Eddie Antonio Santos
fe0a99c6e4
Merge branch 'master' into lmlayer-specify-punctuation 2019-07-30 09:22:34 -06:00
jahorton
9c7b8cca78 Fleshes out LMLayer history 2019-07-30 10:36:28 +07:00
Joshua Horton
12b686aa4b
Merge pull request #1902 from keymanapp/lmlayer-worker-interface-docs
[LMLayer] Documents the methods of WorkerInternalModel
2019-07-30 08:40:42 +07:00
Joshua Horton
d8cd238e36
Update common/predictive-text/worker/worker-interfaces.ts
Co-Authored-By: Eddie Antonio Santos <easantos@ualberta.ca>
2019-07-30 08:40:00 +07:00
Eddie Antonio Santos
d99337bf39
Add punctuation to trie model. 2019-07-29 16:06:43 -06:00
Eddie Antonio Santos
eb12da683b
Test that the trie model exposes punctuation. 2019-07-29 16:04:41 -06:00
Eddie Antonio Santos
32a8dcb0c2
Convert determinePunctuationFromModel() to a static method. 2019-07-29 15:44:23 -06:00
Eddie Antonio Santos
b20541ea8b
Allow for the partial specification of punctuation, with more robust defaults selector thing. 2019-07-29 15:40:08 -06:00
Eddie Antonio Santos
5e2528a78c
Extract method: determinePunctuationFromModel(). 2019-07-29 15:29:36 -06:00
jahorton
8f374d24fc Missed including this edit. 2019-07-29 08:11:06 +07:00
jahorton
efbeafa78e PR review polish, round 1 2019-07-29 05:57:14 +07:00
Marc Durdin
2c680329c0
Merge pull request #1895 from keymanapp/lmlayer-disable-firefox-and-edge-in-karma-tests
[LMLayer] Disable Firefox and Edge in unit tests
2019-07-28 16:53:39 +10:00
jahorton
5776cd9138 Documents the methods of WorkerInternalModel 2019-07-26 16:03:12 +07:00
Eddie Antonio Santos
ada6af46f6
Fix old dummy model test case. 2019-07-25 16:05:04 -06:00
Eddie Antonio Santos
529f0d3adf
Move space adding to the model compositor. 2019-07-25 15:47:54 -06:00
Eddie Antonio Santos
096ecad140
Test that the proper space is appended. 2019-07-25 15:29:59 -06:00
Eddie Antonio Santos
87089a197d
Implement alternate open/close quote. 2019-07-25 15:11:40 -06:00
Marc Durdin
e413b96a65 [LMLayer] Disable Firefox and Edge in unit tests 2019-07-26 07:05:57 +10:00
Marc Durdin
a09e711f4a [LMLayer] Make license consistent with rest of Keyman 2019-07-26 06:52:31 +10:00
Eddie Antonio Santos
d71cec5bf1
Write test to detect if the model compositor understands punctuation. 2019-07-25 13:00:35 -06:00
jahorton
1c8f2b3481 Adds comment for future extension work. 2019-07-23 11:00:06 +07:00
jahorton
09f4db3445 Merge branch 'master' into web-lmlayer-suggestion-ux 2019-07-23 08:30:38 +07:00
jahorton
d518d6d92c Addresses PR review elements. 2019-07-23 08:28:06 +07:00
jahorton
4ae9394f51 Fixes mid-word backspace issues. 2019-07-22 13:06:46 +07:00
jahorton
9137eca2e7 Null-context suggestion whitespace preservation 2019-07-22 11:53:25 +07:00
jahorton
989dc881fc Right, null-check that. 2019-07-22 10:22:49 +07:00