Commit graph

400 commits

Author SHA1 Message Date
Marc Durdin
49eb062c65 feat(web): prediction casing follows current layer
Fixes #6455.

This involved adding an extra hint to the data passed into the lexical
model layer, being the CasingForm that the current layer wants to use.

Given there are several entry points to the lexical model layer, this
meant a few places where we needed to check the current layer.

I refactored the very long function `InputProcessor.processKeyEvent` to
extract out the `buildAlternates` function. There should be no
functional changes to the `buildAlternates` code. But it makes
`processKeyEvent` significantly easier to read.
2022-04-08 16:14:01 +10:00
Marc Durdin
e616900cad
Revert "feat(web): prediction casing follows current layer" 2022-04-08 14:50:32 +10:00
Marc Durdin
b7ce99480f feat(web): prediction casing follows current layer
Fixes #6455.

This involved adding an extra hint to the data passed into the lexical
model layer, being the CasingForm that the current layer wants to use.

Given there are several entry points to the lexical model layer, this
meant a few places where we needed to check the current layer.

I refactored the very long function `InputProcessor.processKeyEvent` to
extract out the `buildAlternates` function. There should be no
functional changes to the `buildAlternates` code. But it makes
`processKeyEvent` significantly easier to read.
2022-04-01 16:20:50 +11:00
Joshua Horton
01217a76ae
Merge pull request #5480 from keymanapp/fix/common/models/keep-diacritic-sensitivity
fix(common/models): keep/suggestion diacritic sensitivity when de-duping
2021-08-06 11:32:48 +07:00
Joshua Horton
9d35b26f1b
docs(common/models): applies PR suggestion
Co-authored-by: Marc Durdin <marc@durdin.net>
2021-07-22 10:56:38 +07:00
jahorton
3fd881d680 fix(common/models): keep/suggestion diacritic sensitivity when de-duping 2021-07-22 09:28:23 +07:00
jahorton
52c3356c7b fix(common/models): adds worker null guard for predict 2021-07-21 11:40:21 +07:00
jahorton
3c6e6a8095 docs(common/models): adds comment 2021-06-11 15:25:13 +07:00
jahorton
05833e8966 fix(common/models): correction search use of edge keying with NFD 2021-06-11 15:18:35 +07:00
Joshua Horton
af0fd256d1
change(common/models): PR suggestion
Co-authored-by: Marc Durdin <marc@durdin.net>
2021-03-23 09:44:18 +07:00
jahorton
9439090205 fix(common/models): fixes overly zealous thresholding near word starts 2021-03-23 09:13:02 +07:00
jahorton
8d74ece6f7 fix(common/models): prevents wordbreak-insertion aliasing 2021-03-22 14:04:09 +07:00
jahorton
24cbb23622 fix(common/models): prevents "undefined" reversion display string 2021-03-11 10:51:48 +07:00
jahorton
978eea2204 change(common/models): a bit of tidy-up 2021-03-04 12:44:08 +07:00
jahorton
35ee5828da fix(common/models): fixes incorrect deleteLeft prop for post-bksp suggestions 2021-03-04 12:36:39 +07:00
jahorton
a232f32ea4 chore: reverts right-delete changes 2021-02-26 10:32:48 +07:00
jahorton
8516561081 change(common/models): disables right-deletion for now 2021-02-25 14:31:11 +07:00
jahorton
28ed690fe2 chore(common/models): Merge branch 'beta' into feat/common/models/mid-context-suggestions 2021-02-25 09:16:45 +07:00
jahorton
21d9f49001 fix(common/models): merges identical suggestions after casing 2021-02-22 14:43:58 +07:00
jahorton
785b9500c1 fix(common/models): correction-search smp issues 2021-02-10 10:52:32 +07:00
jahorton
8334e49076 chore(common/models): Merge branch 'fix/common/models/context-reset-predictions' into feat/common/models/mid-context-suggestions 2021-02-09 14:41:28 +07:00
jahorton
a8b5203997 fix(common/models): fixes context tracking with SMP chars 2021-02-09 14:32:53 +07:00
jahorton
f0f1ae351e docs(common/models): removes defunct comment-doc 2021-02-09 09:22:09 +07:00
jahorton
ee6b11aca6 fix(common/models): missed a spot 2021-02-09 08:22:09 +07:00
jahorton
ae634a93a9 chore(common/models): Merge remote-tracking branch 'origin/fix/common/models/context-reset-predictions' 2021-02-09 08:21:11 +07:00
jahorton
c449d0318f fix(common/models): logic check - deleteRight may be undefined 2021-02-09 08:20:09 +07:00
Joshua Horton
8dcc4a713b
change(common/models): PR suggestion
Adds `primaryInput.deleteRight == 0` to logic check for empty transforms.

Co-authored-by: Marc Durdin <marc@durdin.net>
2021-02-09 08:18:37 +07:00
jahorton
0483f3e13c chore(common/models): Merge branch 'fix/common/models/context-reset-predictions' into feat/common/models/mid-context-suggestions 2021-02-08 12:48:47 +07:00
jahorton
2b12b0a3e8 fix(common/models): search alg failed to clear batches 2021-02-08 12:21:11 +07:00
jahorton
a2adfd736e chore(common/models): Merge branch 'fix/common/models/context-reset-predictions' into feat/common/models/mid-context-suggestions 2021-02-08 09:31:26 +07:00
jahorton
d5161e344e fix(common/models): accumulates 'keep' probability / prevents replacement 2021-02-08 09:27:40 +07:00
jahorton
29f9625d7a change(common/models): better suggestion thresholding strat 2021-02-08 09:11:37 +07:00
jahorton
861d1b5501 fix(common/models): branch polishing, unit test fix 2021-02-05 12:58:06 +07:00
jahorton
e1bab443ea fix(common/models): mid-context post-revert suggestion acceptance 2021-02-05 10:22:52 +07:00
jahorton
2b999d6274 fix(common/models): fixes reversion application 2021-02-05 09:33:28 +07:00
jahorton
138a7db228 feat(common/models): mid-context suggestion acceptance 2021-02-05 09:16:06 +07:00
jahorton
e50596335e fix(common/models): adds wordbreak text only at end of context 2021-02-03 10:59:37 +07:00
jahorton
1c9c64c7d7 fix(common/models): predictions after context reset / caret shift 2021-02-03 10:59:16 +07:00
jahorton
21b917d9d7 change(common/models): let -> const (from PR review) 2021-02-03 08:18:40 +07:00
jahorton
f5b0dcfc8a docs(common/models): better comments for ContextTracker's match method 2021-02-02 14:59:16 +07:00
jahorton
f9a7c0b3e1 fix(common/models): bksp workaround now works beyond first word 2021-02-02 14:45:52 +07:00
jahorton
790ad79b3f change(common/models): diagonal width boost to help multi-char transforms 2021-01-11 10:01:36 +07:00
jahorton
14148e3aee fix(common/models): null guard for prior commits 2021-01-11 10:01:36 +07:00
jahorton
43625b5a2d feat(common/models): paradigm shift; single-char transform sequence for workaround 2021-01-11 10:01:35 +07:00
jahorton
0972f44c2b feat(common/models): compacts context tokens on bksp 2021-01-11 10:01:35 +07:00
jahorton
07daee7b16 fix(common/models): fixes post-wordbreak suggestions 2020-12-04 13:39:04 +07:00
jahorton
6d111783e3 fix(common/core/web): predictive context reset 2020-12-03 15:48:18 +07:00
jahorton
f7869c48b3 fix(common/models): fixes non-nil context predict bug 2020-11-11 15:42:27 +07:00
jahorton
5de62a96be chore(common/models): Merge branch 'feat/common/core/web/input-processor-unit-tests' into feat/common/models/integrated-suggestion-casing-tests 2020-11-11 11:57:56 +07:00
jahorton
e8322e0aa7 feat(common/models): properly casing partial suggestions 2020-11-11 10:07:29 +07:00