Commit graph

24978 commits

Author SHA1 Message Date
Marc Durdin
d2b5d986dc
Merge branch 'fix/core/10605-app-context-copy-strip-markers' into fix/core/10615-10616-10617-core-surrogates-and-app-context-markers-and-memory-leak 2024-02-05 16:12:58 +11:00
Marc Durdin
5f4aeb6c2f
Merge branch 'fix/core/10582-km_core_state_get_actions-idempotency' into fix/core/10605-app-context-copy-strip-markers 2024-02-05 16:12:26 +11:00
Marc Durdin
6d8cae1f2e refactor(core): is_context_changed() into two functions
Refactors `is_context_changed()` into two functions,
`get_context_change()` and `get_context_items_change()`, to eliminate
use of `goto` for cleanup, and more accurately reflect the purpose of
the function. Also renames some variables referencing the return value
from these functions.

These functions would probably benefit from unit tests proving them.
2024-02-05 12:07:41 +07:00
Marc Durdin
e69bfe7e71 chore(windows): remove old code relating to actions lifecycle
After the changes to core in previous commit, Windows no longer needs to
dispose the actions struct. Also refactored the lifecycle of
core_actions to make ownership clearer.
2024-02-05 09:59:47 +07:00
Marc Durdin
fe8eba176c
Merge branch 'fix/core/10605-app-context-copy-strip-markers' into fix/core/10615-10616-10617-core-surrogates-and-app-context-markers-and-memory-leak 2024-02-05 13:45:03 +11:00
Marc Durdin
49eb6f42a9
Merge branch 'fix/core/10582-km_core_state_get_actions-idempotency' into fix/core/10605-app-context-copy-strip-markers 2024-02-05 13:44:56 +11:00
Marc Durdin
70ba1d1c1e
Merge branch 'chore/core/10520-hide-old-action-apis' into fix/core/10582-km_core_state_get_actions-idempotency 2024-02-05 13:44:47 +11:00
Marc Durdin
aa80992fb8
Merge branch 'feat/windows/use-km-core-actions-struct' into chore/core/10520-hide-old-action-apis 2024-02-05 13:44:36 +11:00
rc-swag
433faab1c5 chore(windows): Merge branch 'master' into feat/windows/use-km-core-actions-struct 2024-02-05 12:42:08 +10:00
Darcy Wong
8817d240e2 fix(android/app): Cleanup AndroidManifest handling of *.kmp 2024-02-05 09:32:46 +07:00
rc-swag
7ad81f9440 feat(windows): revert kmshell.res 2024-02-05 11:03:31 +10:00
rc-swag
50b5d197b3 feat(windows): remove extra debug messages 2024-02-05 11:00:27 +10:00
Keyman Server
55dc824bb4
Merge pull request #10619 from keymanapp/auto/version-master-17.0.261
auto: increment master version to 17.0.261
2024-02-04 01:03:02 +07:00
Keyman Build Agent
514d6f3f1a auto: increment master version to 17.0.261 2024-02-03 13:02:27 -05:00
Eberhard Beilharz
91fd8d20be
Merge pull request #10612 from keymanapp/chore/linux/10453_APICheck
chore(linux): Fix API check if lines got removed in .symbols file
2024-02-03 14:22:27 +01:00
Eberhard Beilharz
2446662587
Merge pull request #10610 from keymanapp/docs/linux/pydebug
docs(linux): Update sample settings
2024-02-03 14:22:10 +01:00
Eberhard Beilharz
fce77f1b99
Merge pull request #10609 from keymanapp/fix/linux/artifactpath
fix(linux): Fix path to artifacts when uploading to llso
2024-02-03 13:14:17 +01:00
Marc Durdin
9ba919c2a9 fix(core): surrogate handling, markers in app context, and memory leak
Fixes #10615 (surrogate handling, km_core_state_context_set_if_needed).
Fixes #10616 (markers in app context, in unit tests)
Fixes #10617 (memory leak in replace_context).

The surrogate handling and markers in app context bugs were quite
tangled, so opted to fix those both together in one commit. The memory
leak was spotted while verifying the changes for surrogate handling.

Surrogates were not handled in is_context_unchanged, and opted to
refactor to work directly with km_core_context_item arrays rather than
continue with the string-based comparison, for simplicity.

While writing the corresponding unit tests, realised that the
app_context checks were incorrect in a number of existing tests, and so
fixed up the existing tests at the same time as writing up the new
tests. The only changes to core for this were to add assertions for the
app_context to ensure that markers are not inadvertently added.
2024-02-03 09:16:16 +07:00
Darcy Wong
1fdbfd83fe
Merge pull request #10606 from keymanapp/chore/fv/keyboards-csv/version
chore(oem/fv): Update versions in keyboards.csv
2024-02-03 08:26:24 +07:00
Steven R. Loomis
90119c0ffe
Merge branch 'feat/developer/10554-sometimes-no-norm' into feat/developer/10316-range-warning 2024-02-02 17:03:04 -06:00
Steven R. Loomis
80ad3a87fc feat(developer): hint/warn on range check 🙀
- add warning into tran.ts - will be one warning per <tranform> element

#10316
2024-02-02 16:59:58 -06:00
Marc Durdin
dbb24bc19d
Merge branch 'fix/core/10582-km_core_state_get_actions-idempotency' into fix/core/10605-app-context-copy-strip-markers 2024-02-03 09:41:56 +11:00
Marc Durdin
e109e4feca
Merge branch 'chore/core/10520-hide-old-action-apis' into fix/core/10582-km_core_state_get_actions-idempotency 2024-02-03 09:41:49 +11:00
Marc Durdin
f34976e8c0
Merge branch 'feat/windows/use-km-core-actions-struct' into chore/core/10520-hide-old-action-apis 2024-02-03 09:40:53 +11:00
Steven R. Loomis
10940be7e0 feat(developer): hint/warn on range check 🙀
- analyzer

#10316
2024-02-02 15:18:08 -06:00
Eberhard Beilharz
883b9fc4c8
chore(linux): Fix API check if lines got removed in .symbols file
If lines got removed in the .symbols file we won't find the current
version number in the .symbols file. This change fixes the expectations.

Also, if a major API change happens during the Alpha cycle we don't expect
another API version increment if one already happened since we released
the stable version.

This change also adds some unit tests for the new functionality. These
can be run manually and won't run during CI builds.

Fixes #10453.
2024-02-02 20:15:22 +01:00
Steven R. Loomis
107e8e98f9 feat(developer): hint/warn on range check 🙀
- analyzer

#10316
2024-02-02 12:09:23 -06:00
Keyman Server
0f53c4737f
Merge pull request #10611 from keymanapp/auto/version-master-17.0.260
auto: increment master version to 17.0.260
2024-02-03 01:03:50 +07:00
Keyman Build Agent
cf58476744 auto: increment master version to 17.0.260 2024-02-02 13:03:21 -05:00
Steven R. Loomis
dfe1a9f9c9
Merge branch 'master' into feat/developer/10554-sometimes-no-norm 2024-02-02 11:06:23 -06:00
Eberhard Beilharz
99598294d3
docs(linux): Update sample settings
Python debugger in vscode >= 1.86 now uses a different type.
2024-02-02 16:42:07 +01:00
Eberhard Beilharz
0b4ade8018
fix(linux): Fix path to artifacts
With the new download-artifact version when using `merge-multiple:true`
all artifacts end up in the same directory. This change adjusts for that.

Another follow-up of #10577.
2024-02-02 12:07:02 +01:00
Eberhard Beilharz
97bbcee3ef
Merge pull request #10596 from keymanapp/chore/linux/cherry-pick/changelog
chore(linux): Update debian changelog 🍒
2024-02-02 09:28:53 +01:00
Marc Durdin
9e50f50687 fix(core): strip markers in actions_update_app_context_nfu()
Fixes #10605.
2024-02-02 15:10:05 +07:00
rc-swag
8f2e0a76eb feat(windows): code comment 2024-02-02 16:55:28 +10:00
rc-swag
d34ba7e527 feat(windows): remove extra debugging 2024-02-02 16:48:09 +10:00
Steven R. Loomis
db1c4b8636 feat(developer): hint/warn on range check 🙀
- failing test

#10316
2024-02-02 00:05:10 -06:00
Darcy Wong
b9d42df0e9 chore(oem/fv): Update versions in keyboards.csv 2024-02-02 12:40:04 +07:00
Steven R. Loomis
ef99b81f14
Merge branch 'master' into feat/developer/10554-sometimes-no-norm 2024-02-01 22:21:55 -06:00
Marc Durdin
ff3a06f894
Merge pull request #10601 from keymanapp/chore/history-fixup
chore(common): history missing message fixup
2024-02-02 14:26:18 +11:00
Darcy Wong
e246dcb4f1
Merge pull request #10603 from keymanapp/chore/history-16-0-145
chore(common): Add entries from 16.0.145 HISTORY.md
2024-02-02 10:25:28 +07:00
Darcy Wong
307a27165b chore(common): Add entries from 16.0.145 HISTORY.md 2024-02-02 10:20:02 +07:00
Marc Durdin
37cfe365bb chore: history missing message fixup
Not sure why this is happening, nothing obvious in logs. Will monitor.
2024-02-02 09:28:16 +07:00
Steven R. Loomis
71443836a2 feat(developer): support normalization=disabled 🙀
- avoid dead store to transforms class

#10554
2024-02-01 19:05:31 -06:00
Steven R. Loomis
535418d9ef feat(developer): hint/warn on range check 🙀
- just the test files

#10316
2024-02-01 19:02:54 -06:00
Steven R. Loomis
3a538c103f feat(developer): support normalization=disabled 🙀
- test and code fixes

#10554
2024-02-01 18:40:02 -06:00
Steven R. Loomis
7572c9476e feat(developer): support normalization=disabled 🙀
- main core changes and test changes

#10554
2024-02-01 17:32:42 -06:00
Marc Durdin
8156a8b19d
Merge pull request #10576 from keymanapp/fix/linux/9593_version-comparison
fix(linux): Fix version comparison
2024-02-02 09:47:37 +11:00
Marc Durdin
702b91a682
Merge pull request #10599 from keymanapp/chore/linux/fixarmhf
chore(linux): Use correct format specifier for `g_utf8_strlen`
2024-02-02 09:38:51 +11:00
Marc Durdin
404fe172c9
Merge pull request #10593 from keymanapp/chore/common/10590-cancel-earlier-builds
chore(common): cancel earlier builds when new test builds triggered
2024-02-02 09:34:56 +11:00