Commit graph

3302 commits

Author SHA1 Message Date
Darcy Wong
41bb899164 chore(windows/resources): Add titles to other index pages
* common/editions were removed in #4105
2021-01-28 14:15:36 +07:00
Darcy Wong
c4ef2221fb chore(windows/resources): Update context help titles
* Fix titles
* Remove unused osk_usage.md
* Remove link to osk_usage because the actual link is onscreenkeyboard
* Fix link to charactermap
* Remove unused links to psrt*language
2021-01-28 14:15:36 +07:00
Marc Durdin
eb3f8d658b fix(windows): Ignore Access Denied error creating task
Fixes #4116.
Fixes KEYMAN-WINDOWS-5T.

If we get an 'access denied' error, we won't report it to Sentry. This
error is of minor consequence as it arises in normal configurations only
if the task was already present, created by an elevated instance of
kmshell under the same user name. In that situation, the task works
fine; it just cannot be updated by a non-elevated instance of kmshell.
If there are other reasons for receiving access denied, we won't be able
to distinguish them anyway, so the best response is to suppress this
message.

An alternative would have been to either (a) avoid creating the task as
an elevated user, or (b) only ever create the task as an elevated user.
However, this adds extra unnecessary complexity and means that the task
may not always be present when we want it to be.
2021-01-28 14:13:45 +11:00
Marc Durdin
c194793a76
Merge pull request #4348 from keymanapp/fix/windows/4265-splash-button-sizes
fix(windows): Splash button sizes
2021-01-28 13:50:20 +11:00
Marc Durdin
0ae102a0d3
Merge pull request #4362 from keymanapp/fix/windows/setup-strings-comment-for-language
fix(windows): setup strings comment for language
2021-01-28 13:50:13 +11:00
Darcy Wong
4712762e9f chore(windows/resources): Use newer version of Word knowledge base 2021-01-28 06:31:26 +07:00
Marc Durdin
daa021ae85 fix(windows): setup strings comment for language 2021-01-28 08:53:15 +11:00
Marc Durdin
193478a492 fix(windows): Reverse order of backspaces
In order for the BK_SURROGATE and BK_DEADKEY flags to be matched with
the correct xstring elements in the context, we need to delete the
elements from the buffer in reverse order.

decxstr would previously assert if attempting to move before start of
string. This is undesirable behaviour as it should instead return NULL
to indicate that we've finished the string.

I also corretected a buffer underrun which would be possible if
malformed data was in the xstring.

I checked all uses of decxstr to ensure that the NULL return value is
being tested correctly.
2021-01-28 08:16:33 +11:00
Marc Durdin
098de3af78 fix(windows): SMP-aware deletion in TSF-aware apps
Fixes #4196.

When deleting characters in a TSF-aware app, we must delete both halves
of a surrogate pair. This behaviour differs from legacy apps, where a
single backspace is usually sufficient to delete both characters.

Truly ancient apps that do not know about Unicode surrogate pairs are
not going to delete both halves with a single backspace event.
Fortunately, these are few and far between; we would handle them on a
case-by-case basis if support questions for them arise.

When we come to integrating Keyman Core into Keyman for Windows, there
will need to be some careful checking of surrogate pair support, as it
is likely that the handling will need to change.
2021-01-28 07:37:05 +11:00
Darcy Wong
5c4eaffb87 chore(windows/resources): Use full paths to help site 2021-01-27 14:59:59 +07:00
Darcy Wong
5368e28425 chore(windows/resources): Copy desktop/current-version landing page 2021-01-27 13:41:04 +07:00
Marc Durdin
b97c5d293d fix(windows): Enter and Spacebar handling in Configuration
Fixes #4186.

The Enter and Spacebar key handlers had not been updated for the new
layout and so threw errors in use.
2021-01-27 15:23:19 +11:00
Marc Durdin
0d5a35f237 fix(windows): Splash button sizes
Fixes #4265.

This adjusts the button sizes of the splash screen to accommodate longer
strings such as found in the Khmer translation. We could go to a more
flexible layout model to allow for the buttons to stretch as needed, but
that's a lot more work and I don't really want to try for that right
now.
2021-01-27 15:04:45 +11:00
Darcy Wong
ee6909fa18 chore(windows/resources): Fix character map table formatting 2021-01-27 10:10:58 +07:00
Darcy Wong
00457e9ffe chore(windows/resources): Fix broken link to start/font 2021-01-27 10:10:25 +07:00
Darcy Wong
f2ea74f7f7 chore(windows/resources): Fix anchor link to Step 5 2021-01-27 09:37:40 +07:00
Darcy Wong
2306fe157c
Merge pull request #4335 from keymanapp/chore/windows/cherrypick-4109
chore(windows/resources): Cherry-pick 14.0 help from #4109
2021-01-27 07:34:42 +07:00
Darcy Wong
b07f1d92f6 chore(windows/resources): Remove option 2021-01-27 06:35:31 +07:00
Darcy Wong
4ad8da792f
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2021-01-27 06:30:30 +07:00
Marc Durdin
6089e6205f
Merge pull request #4331 from keymanapp/fix/windows/4179-top-align-title-in-install
fix(windows): align title to top in Install Keyboard
2021-01-27 07:10:24 +11:00
Marc Durdin
87e32d245c
Merge pull request #4330 from keymanapp/fix/windows/4205-invalid-character-in-text-content
fix(windows): invalid character in text content opening help
2021-01-27 07:10:18 +11:00
Darcy Wong
f4cf804413 chore(windows): Mark TODO 2021-01-25 16:14:47 +07:00
Darcy Wong
22145429bd chore(windows): Cherrypick 14.0 help from #4109 2021-01-25 15:48:42 +07:00
Marc Durdin
c6498604b0 fix(windows): align title to top in Install Keyboard
Fixes #4179.
2021-01-25 18:40:15 +11:00
Marc Durdin
1506d44e0a fix(windows): invalid character in text content opening help
Fixes #4205.

Avoids encoding UTF-8 in the URL which has patchy support in some of our
libraries.
2021-01-25 18:34:56 +11:00
Marc Durdin
b964485bf2 fix(windows): add makefile 2021-01-25 17:37:33 +11:00
Marc Durdin
7c3bbeda15 fix(windows): tweaks for strings.xml support
* Process setup strings also
* Remove legacy references to cust files from TIKE
* Add unit test to Makefile
2021-01-25 13:41:56 +11:00
Marc Durdin
4bc1730eed fix(windows): improve support for strings.xml
Fixes #4264.

The Android strings.xml format that we now use with Keyman Desktop has a
number of escapes that must be supported in order for text strings to be
rendered correctly, including: @, ?, ', ". Furthermore, positional
parameters have a slightly different format which we should transform on
load.

This change includes a unit test androidstringtokeymanlocalestring.
2021-01-25 11:17:44 +11:00
Marc Durdin
710d1d34af
Merge pull request #4237 from keymanapp/fix/developer/debug-character-grid-performance
fix(developer): Debug character grid performance
2021-01-22 17:45:33 +11:00
Darcy Wong
e77d8daf9b chore(windows/resources): Standardize Tip 2021-01-21 11:46:34 +07:00
Darcy Wong
335e9900bf chore(windows/resources): Standardize Note: 2021-01-21 11:41:24 +07:00
Darcy Wong
6a2c9513bf chore(windows/resources): Address TODO about **Note** 2021-01-21 11:34:54 +07:00
Darcy Wong
c6c2f1550f chore(windows/resources): Address TODO about 'note' 2021-01-21 11:23:56 +07:00
jahorton
a4aa945dfd fix(developer/compilers): kmlmc package.json no longer needs reset during build 2021-01-20 12:42:53 +07:00
Darcy Wong
36083a6a5c
Merge pull request #4295 from keymanapp/chore/common/crowdin-de
chore(common): Check in crowdin files for de (German)
2021-01-20 09:03:11 +07:00
Darcy Wong
169796ba60 chore(common): Configure Windows to use de locale 2021-01-20 08:05:40 +07:00
Marc Durdin
4e79cc2567
Merge pull request #4276 from keymanapp/fix/windows/4275-context-mismatch-with-if-and-dk
fix(windows, common/core/desktop): context mismatch with if and dk
2021-01-20 07:48:32 +11:00
Darcy Wong
4d1cd2c4f1 chore(windows): Check in crowdin files for de 2021-01-19 15:18:33 +07:00
Marc Durdin
b4fdc0920a fix(windows): context mismatch with if and dk
Fixes #4275.
2021-01-18 10:23:44 +11:00
Marc Durdin
5d606f0f4d fix(windows): context mismatch with if and deadkey manual test 2021-01-18 10:16:14 +11:00
Marc Durdin
65cb3aaec2 fix(developer): disable TSentryClient on WINE
Under WINE, on macOS at least, TSentryClient is crashing at
startup, e.g. when calling SymInitialise. In order to have a
working kmcomp.exe on macOS/Linux, we'll just disable Sentry
altogether for now.
2021-01-18 06:36:31 +11:00
Marc Durdin
f7e23ba0c5
Merge pull request #4251 from keymanapp/fix/windows/typo-in-font-helper-string
fix(windows): typo in font helper string
2021-01-15 06:57:38 +11:00
Marc Durdin
acf748162e chore(windows): additional typos 2021-01-15 06:57:11 +11:00
Darcy Wong
e2d4388506
Merge pull request #4228 from keymanapp/common/crowdin-km
chore(common): Check in crowdin files for km (Khmer)
2021-01-14 08:13:29 +07:00
Marc Durdin
856ed5a282 fix(windows): typo in font helper string 2021-01-14 10:21:48 +11:00
Marc Durdin
40b235443b
Merge pull request #4209 from keymanapp/fix/developer/2690-3082-unhandled-keys-in-debugger
fix(developer): Allow unhandled keys to go through to debugger memo
2021-01-14 09:16:39 +11:00
Marc Durdin
b7fb5066bc
Merge pull request #4180 from keymanapp/fix/windows/1285-amharic-sinhala-tigrigna-mitigation
fix(windows): Update mitigation for Keyman 14 and Windows 10 19597
2021-01-14 09:15:50 +11:00
Marc Durdin
c1aae3a313
Merge pull request #4175 from keymanapp/fix/windows/4013-menu-popup-positions
fix(windows): fix menu popup position
2021-01-14 09:15:38 +11:00
Marc Durdin
11612a193a fix(developer): Debug character grid performance
The character grid in the debugger would become very slow as the number
of characters increased, with substantial flickering. This refactor
removes the unnecessary recalculations of the grid cell count and
thus resolves performance problems.
2021-01-13 14:09:43 +11:00
Darcy Wong
f22c8308c8 chore(windows): Check in crowdin files for km 2021-01-08 14:57:53 +07:00