Marc Durdin
2eb10663ba
chore(web): Apply suggestions from code review
...
Co-authored-by: Joshua Horton <joshua_horton@sil.org>
2022-04-19 06:47:31 +10:00
Marc Durdin
0ad1d496d3
fix(android): key tip sticky with multitap
...
Fixes #6489 .
The issue arose in multitap scenarios, where the tip display state
became desynchronised with the actual display state as maintained in
the Android code.
The fix I applied was to reduce some of the state checks into the js
wrapper android-host.js. This is not ideal. The state machine for key
tip display is scattered across four functions in three files:
* visualKeyboard.ts: VisualKeyboard.highlightKey
* visualKeyboard.ts: VisualKeyboard.showKeyTip
* embedded/keytip.ts: KeyTip.show
* android-host.js: oskShowKeyPreview / oskClearKeyPreview
I have moved the actual re-creation check for the tip to the lowest
level functions -- those in android-host.js. But a more detailed look at
the state machine and a refactoring would certainly be worthwhile.
2022-04-07 15:27:41 +10:00
jahorton
227eb91e1f
fix(web): matching adjustments for embedded
2021-07-30 08:15:16 +07:00
jahorton
c731f28fe0
docs(web): suggested tweaks from review
2021-07-02 09:37:30 +07:00
jahorton
8aa9f49fd9
change(web): failed subkey lookup - bye bye, catch & try
2021-06-30 13:02:43 +07:00
jahorton
363811ebda
fix(web): embedded subkey cancellation
2021-06-30 12:35:54 +07:00
jahorton
cafe421e98
docs(web): gesture subclasses
2021-06-30 12:09:19 +07:00
jahorton
a8e82e5bea
chore(web): more changes from PR review
2021-06-30 11:09:32 +07:00
Joshua Horton
e0cf57d508
chore(web): Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2021-06-30 10:11:46 +07:00
jahorton
74dc8ad115
docs(web): reason for SubkeyDelegator nomenclature
2021-06-29 07:48:34 +07:00
jahorton
3d615239a7
fix(web): prevent error when attempting to reselect base key (embedded)
2021-06-24 12:54:09 +07:00
jahorton
5067337429
fix(web): selection of base key after subkey display (embedded)
2021-06-24 12:52:30 +07:00
jahorton
60081b7c4a
refactor(web): initial mutual abstraction for pending longpresses
2021-06-24 12:34:43 +07:00
jahorton
d5e5635242
refactor(web): merged subkey highlighting control
2021-06-24 12:34:43 +07:00
jahorton
0d109b12b0
refactor(web): 'easy' part of abstracted RealizedGesture for subkeys
2021-06-24 12:34:43 +07:00
jahorton
0359a68c15
fix(web): prevent error when attempting to reselect base key (embedded)
2021-06-24 12:32:22 +07:00
jahorton
39ec2cbb2e
change(web): embedded longpress tracks source vkbd
2021-06-24 12:12:28 +07:00
jahorton
d99203545b
refactor(web): encapsulates embedded popup-key lookup ops
2021-06-24 12:12:28 +07:00
jahorton
125a2ec0d0
refactor(web): two-stages embedded longpress/subkey
2021-06-24 12:12:28 +07:00
jahorton
a8e051b6f4
refactor(web): wraps embedded subkey selection with Promise
2021-06-16 15:17:17 +07:00
jahorton
9508d70589
refactor(web): keytip abstraction, showKeyTip fusion
2021-06-15 09:35:45 +07:00
jahorton
0ee50e7d85
refactor(web): encapsulates embedded keytip
2021-06-15 09:20:40 +07:00
