Commit graph

913 commits

Author SHA1 Message Date
Eberhard Beilharz
289e07572e
Merge pull request #10141 from keymanapp/fix/web/10099_null-property
fix(web): Fix null error with legacy keyboards
2023-12-07 08:13:38 +01:00
Joshua Horton
ef901a53d0
Merge pull request #10014 from keymanapp/fix/web/unwanted-banner-retoggle
fix(web): accidental suggestion-banner retoggle when disabling predictions
2023-12-07 09:52:21 +07:00
Eberhard Beilharz
38c783935e
fix(web): Fix null error with legacy keyboards
This uses a different approach in response to code review.

Fixes #10099.
2023-12-06 16:45:18 +01:00
Eberhard Beilharz
b58dcbcc3d
fix(web): Fix null error with legacy keyboards
Fixes #10099.
2023-12-05 18:11:18 +01:00
Joshua Horton
8e272d8d55
Merge pull request #10061 from keymanapp/fix/android/banner-event-loop
fix(android): no suggestions available when swapping pred-text target language 
2023-12-01 09:13:01 +07:00
Eberhard Beilharz
7e47fa29e6
fix(web): Also move source map
Previously we renamed `dom-keyboard-loader.mjs` but forgot to move
the source map along.
2023-11-28 17:47:09 +01:00
Steven R. Loomis
02c8db9fdd
Merge branch 'master' into feat/developer-9446-bad-unicode-epic-ldml 2023-11-25 14:08:41 -06:00
Steven R. Loomis
d18134fcb3 feat(common): ldml improve bad character code 🙀
- use constants for PUA

For: #9446
2023-11-25 14:08:16 -06:00
Steven R. Loomis
bb63ba8a66
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-11-25 13:51:53 -06:00
Joshua A. Horton
7754427274 fix(android): banner event loop on model change 2023-11-23 10:13:26 +07:00
Steven R. Loomis
5bfb3288d2 feat(developer): ldml improve bad character code 🙀
- refactor output section

For: #9446

Co-authored-by: Darcy Wong <darcywong00@users.noreply.github.com>
2023-11-22 16:59:02 -06:00
Joshua A. Horton
0f32515050 fix(web): app/webview did not clear deadkeys on context-reset 2023-11-22 09:09:36 +07:00
Steven R. Loomis
c42615420d feat(developer): err/hint on illegal/pua 🙀
- also found that kmc's validate() should have been async but wasn't, a little bit of churn because of this
- unassigned not implemented yet, but tests in place for it.
- change SectionCompiler.postValidate to only be called during the validate() run of compilation. This way messages will only show once.

For: #9446
2023-11-17 22:41:58 +00:00
Steven R. Loomis
3a417ade79 feat(common): PUA and illegal unicode analysis 🙀
For: #9446
2023-11-17 20:37:33 +00:00
Joshua A. Horton
cff93bec74 fix(web): accidental suggestion-banner retoggle when turning predictions off 2023-11-16 08:20:38 +07:00
Marc Durdin
a355721e1b
Merge pull request #9996 from keymanapp/chore/developer/9948-handle-project-version-cleanly-in-kmc
chore(developer): handle project version checks cleanly in kmc 🦕
2023-11-15 13:48:44 +11:00
Marc Durdin
b8dcc1b43d
Merge branch 'master' into feat/developer/9948-load-xml-ldml-files 2023-11-15 13:46:52 +11:00
Marc Durdin
65b7b20dc8 chore(developer): handle project version checks cleanly in kmc
Relates to #9948.

While the schema validation does check the version already, it gives a
fairly obtuse message, and we can do better.

Found a secondary issue with a iterator type guard needed in
kpj-file-reader when preparing unit test, which was probably masked in
other tests by not verifying all messages generated, so updated all
infrastructure message tests to verify the full set of messages
generated.
2023-11-14 06:24:28 +07:00
Marc Durdin
1d3cb5eb4b chore(common): ldmlKeyboard3.dtd 2023-11-08 05:48:24 +07:00
Eberhard Beilharz
abe6cee202
chore(web): Additional tests for backspace
Addresses code review comments.
2023-11-06 15:51:29 +07:00
Eberhard Beilharz
a43fad4678
fix(web): Don't clear deadkeys after backspace
Fixes #8568.
2023-11-06 13:29:33 +07:00
Eberhard Beilharz
2e71ec9e70
chore(web): Add failing test for deadkey bug
Also adds a similar testcase to the baseline keyboard tests.
2023-11-06 13:28:49 +07:00
Eberhard Beilharz
84dd0c6b95
chore(web): Improve debug output of nodeProctor 2023-11-06 12:20:57 +07:00
Marc Durdin
c5c5b35415 chore(common): remove prepublish step from package.json
Given we've just run a build, this (a) seems unnecessary, and (b) seems
to go wrong in some circumstances anyway, e.g.
https://build.palaso.org/buildConfiguration/Keyman_Developer_Release/421326?buildTab=log&focusLine=19936&linesState=18839&logView=flowAware:

```
07:01:29   > @keymanapp/kmc@17.0.205-alpha prepublishOnly
07:01:29   > npm run build
07:01:29
07:01:31
07:01:31   > @keymanapp/kmc@17.0.205-alpha build
07:01:31   > tsc -b
07:01:31
07:01:35   ../../../common/web/types/build/src/kmx/kmx.d.ts(1,1): error TS1036: Statements are not allowed in ambient contexts.
07:01:35   ../../../common/web/types/build/src/kmx/kmx.d.ts(1,2): error TS1345: An expression of type 'void' cannot be tested for truthiness.
...
```
2023-11-04 07:34:18 +07:00
Marc Durdin
2f227b61ed
Merge pull request #9903 from keymanapp/chore/common/9854-SchemaValidator-error-management
chore(common): fixup SchemaValidators error handling
2023-11-02 14:52:54 +11:00
Marc Durdin
45b5db1974
Merge pull request #9844 from keymanapp/chore/developer/verify-kmp-json-output-from-kmc-package
chore(developer): verify kmp.json output from kmc-package
2023-11-02 14:50:50 +11:00
Marc Durdin
f5b07f86c6 chore(common): fixup SchemaValidators error handling
Fixes #9854.
2023-10-31 11:44:08 +07:00
Steven R. Loomis
f72c571696
Merge branch 'master' into chore/developer/9838-cldr44-epic-ldml 2023-10-26 18:38:14 -05:00
Steven R. Loomis
a45dc5c345 chore(developer): ldml update to prefinal v44 🙀
-  fix binary size issue
- upstream: issue in abnt2 sample keyboard

For feat(developer): ldml re-sync with CLDR v44 spec 🙀  #9838
2023-10-26 18:21:56 -05:00
Marc Durdin
762f343b52
Merge pull request #9824 from keymanapp/chore/common/kpj-handle-xml-error
chore(common): handle invalid XML in kpj-file-reader
2023-10-26 13:46:29 +11:00
Steven R. Loomis
6da64553fc chore(developer): ldml update to prefinal v44 🙀
- form

For feat(developer): ldml re-sync with CLDR v44 spec 🙀  #9838
2023-10-25 08:56:55 -05:00
Marc Durdin
cdac2dd01b chore(developer): verify kmp.json output from kmc-package 2023-10-25 12:07:46 +07:00
Steven R. Loomis
a9f437f97a chore(common,developer): ldml update to prefinal v44 🙀
- more data and developer fixes

For feat(developer): ldml re-sync with CLDR v44 spec 🙀  #9838
2023-10-24 17:40:34 -05:00
Steven R. Loomis
1ff2bfc4d7 chore(developer,common,core): ldml update to prefinal v44 🙀
- more data file updates
- now updating some developer files
- updating the KMX+ spec with some changes.
 (vkey was dropped in #7135, remove it from the spec)

For feat(developer): ldml re-sync with CLDR v44 spec 🙀  #9838
2023-10-24 17:28:08 -05:00
Steven R. Loomis
5dbda001fc chore(common,core): ldml update to prefinal v44 🙀
- common passes tests
- updated data files

For feat(developer): ldml re-sync with CLDR v44 spec 🙀  #9838
2023-10-24 14:47:22 -05:00
Joshua A. Horton
5ba60e985b fix(web): someone forgot to actually use 'test mode' 2023-10-24 12:25:00 +07:00
Marc Durdin
c645707279 chore(common): handle invalid XML in kpj-file-reader 2023-10-23 08:53:30 +07:00
Steven R. Loomis
85ae8e0d45
Merge branch 'feat/core/9468-normalization-epic-ldml' into feat/core/9468-test-improvement-epic-ldml 2023-10-19 17:14:41 -05:00
Steven R. Loomis
13eed28a36 Merge branch 'feat/core/9468-normalization-epic-ldml' into feat/core/9468-test-improvement-epic-ldml 2023-10-19 14:00:38 -05:00
Marc Durdin
14ea216b4e fix(common): don't use URL in common/web/types
Fixes #9788.
2023-10-19 09:22:07 +07:00
Marc Durdin
5218726583 fix(developer): handle invalid project folders cleanly
Fixes #9715.
2023-10-18 06:10:41 +07:00
Marc Durdin
1db919d581 fix(developer): handle fv_all keyboard project with no .kmn 2023-10-18 05:41:52 +07:00
Steven R. Loomis
d46e08267e fix(common,developer): ldml test fix 🙀
- There are two cases. Added comments to cross-link them.

For: #9468
2023-10-16 10:52:39 -05:00
Steven R. Loomis
f89be2d21b fix(common): ldml test fix 🙀
- the wrong test case was updated previously

For: #9468
2023-10-16 10:24:49 -05:00
Steven R. Loomis
f4501fea81 chore(developer): remove an unused error code 🙀 2023-10-13 17:38:08 -05:00
Steven R. Loomis
6a62d01481 chore(core): dx: ldml test subselection 🙀
- add a filter option to run just one subtest
- support backspace event, revamp test JSON format

For: #9468
2023-10-13 16:45:56 -05:00
Marc Durdin
f61e65ceb9
Merge pull request #9736 from keymanapp/chore/merge-master-into-package-metadata
chore: merge master into package-metadata
2023-10-11 11:28:07 +11:00
Marc Durdin
f76efc38cc chore(common): stop using xml2js.processors.firstCharLowerCase
Fixes #9713.
2023-10-09 05:43:29 +07:00
Marc Durdin
400444933c feat(developer): introduce WelcomeFile property to packages
Fixes #9478.

This adds a property WelcomeFile to .kps and kmp.json, which allows us
to move away from the hardcoded welcome.htm filename in the future, and
makes transform from Markdown (#9477) a simpler operation, and just
generally starts the cleanup of the messiness of hard-coded filenames.

The package compiler will fallback to injecting welcome.htm into this
property if (a) welcome.htm is present, and (b) the property does not
already have a value. This doesn't buy us much because we still need to
support welcome.htm for existing legacy packages, but does mean that
our .kmp package metadata will be more consistent for packages compiled
with 17.0+ compilers.
2023-10-08 07:22:57 +07:00
Steven R. Loomis
505a45e933
Merge branch 'master' into feat/core/9121-more-vars-epic-ldml 2023-10-07 11:36:07 -05:00