Eberhard Beilharz
d231cb045b
Merge pull request #11637 from keymanapp/refactor/web/deprecated
...
refactor(web): Replace deprecated substr with substring
2024-06-07 16:22:18 +02:00
Joshua A. Horton
8bc7da101e
fix(web): defer keyboard activation requests made during engine initialization
2024-06-06 09:42:25 +07:00
Eberhard Beilharz
93eabd96ab
refactor(web): use substring instead of slice
...
This addresses code review comments which recommended to use `substring`
as this makes it more consistent with the rest of our code base.
2024-06-03 12:20:02 +02:00
Joshua Horton
c3277c5fdf
Merge pull request #11464 from keymanapp/chore/web/final-config-flag-fixes
...
chore(web): finalize web/ project parity with base-repo TS config settings (aside from JS version target) 🔩
2024-06-03 15:16:35 +07:00
Joshua Horton
c858824d81
Merge pull request #11463 from keymanapp/chore/web/strict-func-types
...
chore(web): enforce strict function types in web/ 🔩
2024-06-03 15:16:19 +07:00
Joshua A. Horton
d2987ac26f
chore(web): Merge branch 'chore/web/partial-config-cleanup' into chore/web/remove-no-implicit-any
2024-06-03 11:57:33 +07:00
Eberhard Beilharz
3ee8359f8f
refactor(web): Replace deprecated substr with slice
...
Also add a comment to `SourcemappedWorker` explaining the difference
to `DefaultWorker`.
2024-05-31 11:27:55 +02:00
Joshua Horton
daf2579178
Merge pull request #11600 from keymanapp/fix/web/osk.hide-event-param
...
fix(web): use correct parameter name in button UI OSK `hide` event 🔩
2024-05-30 15:50:52 +07:00
Joshua Horton
321ded4776
Merge pull request #11460 from keymanapp/chore/web/remove-unused-locals
...
chore(web): removes unused locals, imports, and private fields 🔩
2024-05-30 15:50:45 +07:00
Joshua Horton
dbee817d80
Merge pull request #11459 from keymanapp/chore/web/fix-implicit-this
...
chore(web): fixes implicit-this cases 🔩
2024-05-30 15:50:24 +07:00
Joshua Horton
294a616902
Merge pull request #11597 from keymanapp/fix/web/remove-dead-branches
...
fix(web): remove dead code-branches 🔩
2024-05-30 15:50:19 +07:00
Joshua Horton
a3c8daa218
Merge pull request #11414 from keymanapp/chore/web/update-typescript
...
chore(web): updates TypeScript version to 5.4.5
2024-05-30 14:03:48 +07:00
Joshua Horton
0b0c2fdf45
Merge pull request #11505 from keymanapp/fix/web/early-webview-kbd-activation
...
fix(web): pre-init keyboard activation awaits init before proceeding
2024-05-30 13:59:35 +07:00
Joshua Horton
c5f8ca66bf
Merge pull request #11470 from keymanapp/fix/web/error-without-neighbor
...
fix(web): fixes error on tab, enter when only a single input element is on the page
2024-05-30 13:59:17 +07:00
Joshua A. Horton
7e1571d382
chore(web): the final push for config-flag parity for web/
2024-05-29 10:57:41 +07:00
Joshua A. Horton
a94c5115a8
chore(web): enforces strict function types in web/
2024-05-29 10:46:32 +07:00
Joshua A. Horton
85a5293b8c
chore(web): adds explicit typing for the app/ui Web modules
2024-05-29 10:43:13 +07:00
Joshua A. Horton
6591c61eeb
chore(web): enforces noImplicitAny for app/browser and app/webview
2024-05-29 10:43:11 +07:00
Joshua A. Horton
4f85677ed8
fix(web): button-ui event's parameter field usage when hiding
2024-05-29 09:27:11 +07:00
Joshua A. Horton
0b05766efb
chore(web): removes web/ unused locals
2024-05-29 09:24:32 +07:00
Joshua A. Horton
1fd2f174bc
chore(web): language menu keyboard-element typing
2024-05-29 08:54:01 +07:00
Joshua A. Horton
5eca1c8815
chore(web): simple arrow-func conversion
2024-05-29 08:54:00 +07:00
Joshua A. Horton
fa2be938d9
fix(web): drops unused 'menuEvent' and associated dead branch
2024-05-29 08:48:01 +07:00
Joshua A. Horton
2c79db4cb5
chore(web): Merge branch 'master' into chore/web/update-typescript
2024-05-27 09:20:01 +07:00
Joshua A. Horton
afed638baa
fix(web): pre-init keyboard activation awaits init before proceeding
2024-05-23 08:49:42 +07:00
Joshua Horton
25e44da918
Merge pull request #11456 from keymanapp/chore/web/e2e-test-migration
...
chore(web): conversion of Web's end-to-end style auto-tests for @web/test-runner use 🏃
2024-05-23 07:41:52 +07:00
Marc Durdin
8535f43f33
Merge branch 'master' into fix/web/error-without-neighbor
2024-05-17 12:37:24 +07:00
Joshua A. Horton
3d0ce74f93
fix(web): fixes error on tab, enter when only a single input element is on the page
2024-05-17 11:52:16 +07:00
Joshua A. Horton
70d06d7cd1
chore(web): updates all KMW-related projects to TS 5.4.5
2024-05-15 16:00:34 +07:00
Joshua A. Horton
a31fa36ec0
chore(web): converts 'integrated' (e2e-ish) Web auto-tests to TS
2024-05-15 15:34:12 +07:00
Joshua Horton
aa68c1755e
Merge pull request #11402 from keymanapp/chore/web/other-dependency-updates
...
chore(web): EventEmitter3, sinon dependency updates 🏃
2024-05-15 14:10:52 +07:00
Darcy Wong
725231c80f
chore: Merge remote-tracking branch 'origin/beta' into chore/beta-to-master-a18s1-part2
2024-05-10 07:41:54 +07:00
Joshua Horton
dd3763b240
Merge pull request #11385 from keymanapp/fix/web/unexpected-null-element
2024-05-10 07:32:09 +07:00
Darcy Wong
cbf1fd5cb1
chore(common): Merge beta to master for sprint A18S1 part 2
2024-05-10 06:27:02 +07:00
Joshua A. Horton
e9631c4fb2
chore(web): adjustments per code review
2024-05-09 10:24:31 +07:00
Joshua A. Horton
a34e5c9100
fix(web): EventEmitter import pattern update
2024-05-09 08:49:50 +07:00
Joshua A. Horton
4fe71921a1
fix(web): fixes illegal KMW event state - can't focus a null element
2024-05-07 09:11:51 +07:00
Marc Durdin
7a0ab01469
fix(web): support SVG elements when checking className
...
Fixes #11364 .
Instead of using `className` which may be of type `SVGAnimatedString` if
the element is an SVG element, use `getAttribute('class')`. As that
function can return `null` if the class attribute is not defined, use
optional chaining to avoid a new error...
Uses the same pattern in hardwareEventKeyboard.ts, although I suspect
the problem may never arise there.
I audited the uses of className in our KeymanWeb source and found only
these three instances which may be problematic. I have not searched
elsewhere.
2024-05-06 10:05:39 +07:00
Marc Durdin
cd8121ef65
chore(common): builder scripts now use /resources/build/builder.inc.sh
...
Note: there is a bit of potential confusion about the difference between
/resources/builder.inc.sh (the full implementation for builder scripts),
and /resources/build/builder.inc.sh (the source script that builder
scripts should always use).
This allows us to make assumptions that will always be true for builder
scripts that may not be true for other scripts, such as setting base
folder.
2024-05-02 15:54:31 +07:00
Marc Durdin
0f390d47cc
chore(common): maintenance on build scripts - cd
...
Fixes #11324 .
* Always `cd "$THIS_SCRIPT_PATH"`
* Remove unnecessary `cd` from all build.sh
* Remove unnecessary `set -eu` from all build.sh (and `# set -x`)
* Replace old build-utils.sh incantation in a few build.sh scripts
2024-05-02 15:54:29 +07:00
Joshua A. Horton
b107daab22
chore(web): Merge branch 'beta' into change/web/init-osk-with-keyboard
2024-04-18 08:15:30 +07:00
Joshua A. Horton
7df368a143
fix(web): now auto-scrolls if target element would be obscured by OSK on device rotation
2024-04-11 11:36:10 +07:00
Joshua A. Horton
786c480742
fix(web): adds newly-needed null guards due to new pattern
2024-04-08 08:55:38 +07:00
Joshua A. Horton
4b1394a54f
change(web): initializes OSK with keyboard if available during init
...
This prevents unnecessary construction of a stand-in touch layout and related DOM initialization on touch devices when fully leveraged.
2024-04-05 13:07:15 +07:00
Marc Durdin
edfed74c62
fix(web): update import for isEmptyTransform
2024-03-27 11:48:26 +07:00
Marc Durdin
70836b40cf
chore: Apply suggestions from code review
...
Co-authored-by: Joshua Horton <joshua_horton@sil.org>
2024-03-27 13:03:35 +11:00
Marc Durdin
a54053bec6
fix(web): prevent layer switch key from erasing selection
...
Fixes #7866 .
When the transform generated by a key event results in no changes to the
text, this will no longer trigger a change event in the apps. This means
that layer switch keys will no longer erase the selection.
Fix proposed by @jahorton.
2024-03-21 10:08:23 +07:00
jahorton
4b11a5d319
fix(ios): selection range sync for long contexts
2024-03-06 15:17:36 +07:00
Joshua A. Horton
0fcbb84dfa
fix(web): context save-state on reset
2024-02-28 10:15:37 +07:00
Joshua Horton
453d24d7e8
Merge pull request #10728 from keymanapp/fix/ios/context-slide-into-multitap
...
fix(ios): multitap consistency after new-lines
2024-02-19 10:17:41 +07:00
