Steven R. Loomis
cace5cf596
feat(core): ldml C++ helper for list / key2 🙀
...
For: #7985
2023-02-15 19:00:54 -06:00
Steven R. Loomis
4a2bb6b3da
Review comments
2023-02-15 09:49:54 -06:00
Steven R. Loomis
e5620e83f1
feat(core): ldml C++ validate list / key2 🙀
...
- need helper objs still
For: #7985
2023-02-14 09:23:51 -06:00
Steven R. Loomis
aa0da57b70
fix(core): fix double precision err
2023-02-14 09:23:03 -06:00
Steven R. Loomis
ac2366f460
feat(core): ldml C++ updates to modifiers 🙀
...
- spec: change caps value to 0x100 #7533
- add a 'mod_all' for validating valid modifier keys, plus tests
- add asserts on C++ side mapping modifiers to keyman constants
- use 'mod_all' to validate modifiers
- further fix modifier -> mod in binary
For: #7985 and related to #7533
2023-02-14 09:23:03 -06:00
Steven R. Loomis
7c02ab85af
feat(core): ldml C++ feature support 🙀
...
- make ldml.cpp print FAILED on failure especially because of https://github.com/microsoft/vscode-cpptools/issues/487
- add vkey validation (#7135 )
- add disp validation
- fix: a latent bug in disp! disp.count was === vkey.count, oops. Fix and test cases.
For: #7985
2023-02-14 09:23:03 -06:00
Steven R. Loomis
57d4dfea75
Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-01-07 22:46:41 -06:00
Steven R. Loomis
2f44780e87
fix(core): ldml: add asserts to C++ 🙀
...
- found a logic bug in kmx_plus.cpp
Fixes #7984
2023-01-06 16:54:24 -06:00
Steven R. Loomis
564f98cc30
Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2023-01-06 11:46:17 -06:00
Steven R. Loomis
efef796d75
feat(core): ldml: fix C++ layr helper 🙀
...
- reenable layr/key2/list in c++
- minor update to layr helper, missed ptr assignment
For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-12-22 13:43:53 -06:00
Steven R. Loomis
05656ac499
feat(core): ldml: fix off-by-one on section count 🙀
...
- yes, sect was counting itself. Too much automation!
- disable layr/key2/list loading in C++ for now
For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-12-22 13:12:08 -06:00
Steven R. Loomis
bccb64c911
feat(core): ldml: kmx-plus.ts for layr/key2/list 🙀
...
- update kmx-plus for layr/key2/list
For #7532
2022-11-17 15:37:25 -06:00
Steven R. Loomis
208a6e40a0
feat(core): ldml: C++ builds 🙀
...
For #7532
2022-11-17 14:17:55 -06:00
Steven R. Loomis
0e6aa6566f
feat(core): ldml: First steps for layr 🙀
...
For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
- dummy Layr class for compilation
- fleshed out Layr class
- CPP validation side
2022-11-16 19:04:55 -06:00
Steven R. Loomis
a00ea0423a
chore(core): ldml: cleanup 🙀
...
- minor cleanup in the .cpp
#5015
2022-11-02 13:39:17 -05:00
Steven R. Loomis
1c7517c5a8
fix(developer): ldml: yet more review feedback fixes 🙀
...
🙀 #7532
2022-11-02 13:36:24 -05:00
Steven R. Loomis
49b46f42ea
feat(common): ldml: builder disp 🙀
...
- with initial core updates
For feat(developer): ldml: include all LDML data in kmx+ 🙀 #7532
2022-11-02 13:36:24 -05:00
Steven R. Loomis
7e5c9ec675
fix(developer): offset of 0th elem str must be 0000 🙀
...
- update test fixture
- update kmx_plus.cpp to require this
Fix: 7404
2022-10-14 15:00:49 -05:00
Steven R. Loomis
45bc101e77
fix(core): ldml: update per review comments 🙀
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2022-10-13 16:34:36 -05:00
Steven R. Loomis
8a3c8af7a1
fix(core): ldml: fix incorrect use of Debug_UnicodeString 🙀
...
- update API docs for Debug_UnicodeString
for #7234
2022-10-12 17:01:46 -05:00
Steven R. Loomis
a63ca4377f
fix(core): improve check and output
2022-10-12 15:57:12 -05:00
Steven R. Loomis
30a100aa8a
fix(core): ldml: cleanup per review comments 🙀
...
- update DebugLog macro to use scoped functions
for #7234
2022-10-12 15:21:13 -05:00
Steven R. Loomis
ced4ed9099
fix(core): ldml: use DebugLog for debug 🙀
...
for #7234
2022-10-12 15:05:03 -05:00
Steven R. Loomis
35799e2306
feat(core): kmx_plus: add accessors for elem 🙀
...
- other refactor and cleanup in kmx_plus
for #7234
2022-10-11 15:43:44 -05:00
Marc Durdin
b6c4e21c1d
chore(developer): remove name from meta section
...
Fixes #7214 .
2022-09-09 08:57:52 +10:00
Steven R. Loomis
029a2737bf
fix(core): ldml: improve utf-32 handling++ 🙀
...
- review comments
- kmx_xstring: add and document macros, add Utf32CharToUtf16
- unit tests for kmx_xstring macros
Fixes : #7134
2022-09-08 11:45:23 -05:00
Steven R. Loomis
7a71ed84cc
fix(core): ldml: improve utf-32 handling 🙀
...
- remove hacky utf-32 processing
- add utf-32 test case to test_kmx_plus.cpp
- change kmx_plus to return std::u16string
- kmx_xstring: add Uni_IsBMP() macro
Fixes : #7134
2022-09-07 18:08:26 -05:00
Steven R. Loomis
f3f498e923
fix(core): fix validators 🙀
...
- copy over asserts from 'old' code
#7136
2022-08-31 17:37:55 -05:00
Steven R. Loomis
3684cc43d0
fix(core): fix validators 🙀
...
yes, a kmxplus file does not start with a 'sect' !
#7136
2022-08-31 17:37:55 -05:00
Steven R. Loomis
90be01385b
chore(core): split out validators 🙀
...
#7136
2022-08-31 17:37:55 -05:00
Steven R. Loomis
3de77cda92
feat(core): ldml: improve reading 🙀
...
- read keys into a std::map instead of on the fly
- no longer retain copy of entire KMX file in read
2022-08-26 16:43:27 -05:00
Steven R. Loomis
aeeae1c4f4
feat(core): ldml: improve read side 🙀
...
- don't reparse structs each time
- move validation into constructor
2022-08-26 13:15:05 -05:00
Steven R. Loomis
af3bcd2a15
feat(core): ldml: padding for vkey and loca 🙀
...
- vkey and loca needed padding before the variable part
- add static asserts to validate this padding
- update sample files (null and tiny)
#7043
2022-08-25 12:54:52 -05:00
Steven R. Loomis
f7aeba5f01
feat(core): ldml: validator for kmxplus 🙀
...
- also update test case, 002_null_invalid is expected to not validate
#7097
2022-08-25 12:54:08 -05:00
Steven R. Loomis
7aac6a1747
chore(core): update 000_null_keyboard to be a proper null keyboard 🙀
...
- rewrite 000_null_keyboard.kmx to be valid, but with no keys
- remove outdated comment in kmx_plus.h
- update kmx_plus.cpp to not reverse the order of section ids (#7098 )
- add a new test option for expected-error
2022-08-24 17:04:55 -05:00
Steven R. Loomis
b180ca844d
fix(core): fixes for kmx_file rearrangement 🙀
...
fix breaks in #7111 and prior
#7098
2022-08-24 13:49:55 -05:00
Marc Durdin
eb48fb76f9
Update core/src/kmx/kmx_plus.cpp
2022-08-24 14:20:08 +10:00
Steven R. Loomis
f8e0abd810
fix(core): ldml: turn off problematic debug 🙀
...
#7098
2022-08-23 16:37:02 -05:00
Steven R. Loomis
b08f101f37
fix(core): ldml: goodbye multichar strings 🙀
...
- update builder to print out string as well as hex
- change to symbol name
2022-08-23 16:34:08 -05:00
Steven R. Loomis
59fc1521dd
fix(core): ldml: use nullptr and some other cleanups 🙀
...
- per review comments
Fixes : #7098
2022-08-23 12:04:57 -05:00
Steven R. Loomis
f5db1749b4
style(core): ldml: review comments
...
#5015
- add copyright notices
2022-08-22 17:13:45 -05:00
Steven R. Loomis
a4080d2b7a
feat(core): ldml: cleanup of header files
...
- quell debug messages unless KMXPLUS_DEBUG=1
- don't read the file twice
#5015
2022-08-19 17:42:09 -05:00
Steven R. Loomis
a333eade22
feat(core): ldml: tiny passes tests
...
- removed null from build, invalid
2022-08-18 14:27:17 -05:00
Steven R. Loomis
70639c585b
feat(core): more kmx_plus_dump functions
...
- also update sample data again
2022-08-17 18:13:17 -05:00
Steven R. Loomis
5926dfe5fe
feat(core): more kmx_plus_dump functions
...
- also update sample data
2022-08-17 17:43:14 -05:00
Steven R. Loomis
590ac8f8f6
feat(core): build out ldml structures
...
- beginning of str handling
2022-08-17 16:25:41 -05:00
Steven R. Loomis
95b4469ea8
feat(core): build out ldml structures
...
- checkin spec to repo
- new header: kmx_plus.h with data access structs and functions
- static asserts to validate header sizes
- early validation of data
- internal dump of kmx+ data
2022-08-17 15:53:53 -05:00