If the PR only contains files that we ignore, we previously failed to
finish the trigger build. This PR fixes the problem.
The problem can be observed in #14271 which only changed a file in
`resources/teamcity/common` which gets ignored in `find_platform_changes`.
Test-bot: skip
Include files are not directly executable, so it doesn't make sense to
have the shebang line. However, shellcheck needs to know what shell we
use. Turns out there is a shellcheck line that we can add instead of
the shebang line.
Follow-up-of: #14253
Build-bot: skip
Test-bot: skip
`--ci` is deprecated since the current code discovers automatically
when we're building on CI, so we don't have to pass that option when
calling the `android/build.sh` script.
Also remove the option itself since we're no longer using it.
Build-bot: build android
Test-bot: skip
Refactors the Powershell scripts that download and upload files and create .download_info files.
This change is based on #14236/#14254 which bypasses the path rewriting that msys does when calling Windows rsync.
Refactors the Powershell scripts that download and upload files and
create .download_info files.
This change is based on #14236/#14254 which bypasses the path rewriting
that msys does when calling Windows rsync.
Fixes: #14226
Related: #14236
Build-bot: skip
Test-bot: skip
Also make `_tc_rsync` function cross-platform. A comparison might show
that we omit `--perms` when calling rsync with this change. However the
short form (`-p`) is already included, so we don't have to additional
add the long form `--perms`.
There is one difference compared to the old build configurations on TC:
previously we had a separate build step to build and test FV that would
run only if environment variables were set.
This change combines building and testing FV with building the engine
and the app. If the environment variables are set we pass an additional
parameter to the TC build script.
Fixes: #14188
Part-of: #13399
Build-bot: release android
Test-bot: skip
Refactors the Powershell scripts that download and upload files and
create .download_info files.
This change is based on #14236/#14254 which bypasses the path rewriting
that msys does when calling Windows rsync. Part of this change was done
for developer in #14255.
Related: #14236, #14255
Refactors the Powershell script which built the .download_info file for
web into the keyman-web-release.sh script, and then bypasses the path
rewriting that msys does when calling a Windows executable (rsync).
This was tricky because msys was mangling all the paths to Windows-style
but we specifically need to reference one remote Unix-style path in the
rsync call. As we wanted to move away from the Powershell script anyway,
it was cleaner to resolve this in one go by moving the whole script to
bash.
The new tc-download-info.inc.sh script is a minimally generalized
version of the download_info writing from keyman-linux-release.sh, and
once the dust settles, it would be good to DRY this out.
Note that this is still Windows-only, despite the rest of the build
being basically platform-agnostic. I wanted to get this stable before we
generalize, which should be fairly straightforward, as it's only the
rsync call which will be touched.
Tested locally with a drop-in Windows executable that just prints its
arguments, to verify that path mangling is not occurring where we don't
want it. The DEBUG lines in keyman-web-release.sh will be removed once
we are confident this is correct.
Fixes: #14225
This change prefixes functions with `ba_` that are intended to be run on
a Linux build agent. That should make it easier to distinguish them from
functions that deal with building Keyman for Linux.
Test-bot: skip
