Commit graph

2839 commits

Author SHA1 Message Date
Steven R. Loomis
cc7ef60f51 fix(developer): error on missing variable name
- improve unit tests
- split out message for dollarsign, create numberspace for transform errs

Fixes: #11044
2024-03-29 11:57:04 -05:00
Steven R. Loomis
d4a0809f2d
Merge branch 'beta' into feat/developer/11044-error-invalid-var 2024-03-29 11:02:15 -05:00
Marc Durdin
ebe258d062
Merge pull request #11109 from keymanapp/fix/developer/11107-scroll-typeerror
fix(developer): prevent error when scrolling touch layout editor with no selected key
2024-03-29 15:23:13 +11:00
Steven R. Loomis
b420cccc68
Merge branch 'beta' into feat/developer/11044-error-invalid-var 2024-03-28 12:22:50 -05:00
Steven R. Loomis
876c0e7488 fix(developer): error on missing variable name
- disallow any stray $ in the from pattern (unless escaped)

Fixes: #11044
2024-03-28 11:43:55 -05:00
Joshua Horton
7c030e3be0
Merge pull request #11085 from keymanapp/feat/developer/compilers/better-suggestion-accessibility-verification
feat(developer/compilers): better unit test for suggestion accessibility
2024-03-28 13:48:28 +07:00
Steven R. Loomis
ad64bdf163 chore(developer): failing test for invalid variable name
for #11044
2024-03-28 01:17:18 -05:00
Steven R. Loomis
8d55d0b5ce
Merge pull request #11075 from keymanapp/feat/developer/11040-layr-comma-in-modifiers
feat(developer): support comma in modifiers 🙀
2024-03-28 00:13:08 -05:00
Steven R. Loomis
53224cb083
Update developer/src/kmc-ldml/src/util/util.ts
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-03-28 00:12:50 -05:00
Steven R. Loomis
c1a700d921
Merge pull request #11070 from keymanapp/fix/core/11062-error-no-match
fix(developer):  in ldml compiler, generate compiler error if `from=` regex matches empty string 🙀
2024-03-28 00:11:57 -05:00
Steven R. Loomis
5f836d72f0
Merge pull request #11059 from keymanapp/fix/core/11045-assert-marker
fix(core,developer): variable/marker substitution in sets and strings🙀
2024-03-28 00:11:28 -05:00
Steven R. Loomis
d9c97c0b78
Merge pull request #11065 from keymanapp/fix/common/unicodeset-errcheck
fix(common): properly handle illegal UnicodeSets to prevent crash in kmc-ldml compiler 🙀
2024-03-28 00:04:39 -05:00
Marc Durdin
9e369227b2 fix(developer): prevent error when scrolling touch layout editor with no selected key
Fixes #11107.
2024-03-28 10:42:19 +07:00
Steven R. Loomis
193d7d077c fix(developer): fix an additional issue on illegal UnicodeSets
- improve comments yet again, as they didn't  match the code.
2024-03-27 08:25:52 -05:00
Joshua Horton
9aac994ba3
chore(developer/compilers): comment typo fix 2024-03-27 12:45:06 +07:00
Joshua Horton
a084fcfbb8
Merge pull request #11074 from keymanapp/fix/developer/compilers/entry-additions-to-internal-trie-nodes
fix(developer): in model compiler, give correct key to shorter prefix words when a longer, higher-frequency word is also present
2024-03-27 09:29:12 +07:00
Joshua A. Horton
ff4ddd901d feat(developer/compilers): better unit test for suggestion accessibility 2024-03-27 09:17:34 +07:00
Steven R. Loomis
baeb3c80fc fix(developer): fix an additional issue on illegal UnicodeSets
- update comments per review comments
- improve logic of checks around malloc
2024-03-26 17:24:56 -05:00
Joshua A. Horton
6fd975c2d2 chore(developer/compilers): minor cleanup 2024-03-26 12:09:21 +07:00
Marc Durdin
9cba6e7053
Merge pull request #10939 from keymanapp/docs/developer/10550-ldml-window-help-links
docs(developer): add help site links
2024-03-26 11:37:28 +11:00
Steven R. Loomis
d6e080dd0d feat(developer): implement comma in modifiers 🙀
- improve modifier parsing
- test cases for keys and layr

For: feat(developer) ldml: comma in modifiers #11040
2024-03-25 18:49:13 -05:00
Joshua A. Horton
6df89af9d5 docs(developer/compilers): makes test fixture comment more precise 2024-03-26 06:48:31 +07:00
Joshua A. Horton
78a3704607 fix(developer/compilers): entry additions to internal Trie nodes 2024-03-26 06:04:22 +07:00
Joshua A. Horton
947bd77ebd feat(developer/compilers): adds unit test 2024-03-26 06:04:22 +07:00
Steven R. Loomis
72de9bed9f feat(developer): scaffolding for comma in modifiers 🙀
- modifiers is a list, not a single entity
- test cases

For: feat(developer) ldml: comma in modifiers #11040
2024-03-25 17:48:31 -05:00
Steven R. Loomis
56add095e6 fix(developer): error if a regex pattern matches the empty string 🙀
- add message and check if the regex matches '' (empty string) and error if so
- add test cases

Fixes: bug(core): assert with vertical pipe #11062
2024-03-25 15:18:35 -05:00
Steven R. Loomis
f2ad7d4e68 fix(common): further improvement to string/set substitution
- tran: check for \uXXXX earlier in the chain, because we emit this format further down
- add test cases for syntax chars being used in variables

Fixes: bug(core): assert when matching markers #11045
Fixes: bug(developer): escape on string substitution if syntax char #11037
2024-03-25 14:52:32 -05:00
Steven R. Loomis
f773066fa0 fix(developer): store set variables in literal form, unescape in tran
- update the tran compiler to call escapeStringForRegex() on set items being substituted into an expression
2024-03-25 12:46:55 -05:00
Steven R. Loomis
67838e60a2 fix(developer,core): fix for marker substitution in sets
- for bug(core): assert when matching markers #11045
- track raw and marker-substituted sets
2024-03-25 12:00:55 -05:00
Steven R. Loomis
18ba46d874 fix(common): fix an additional issue on illegal UnicodeSets
- similar fix to https://github.com/keymanapp/keyman/pull/9492
- again may be due to a wasm version variant
- also additional rangechecking on the input side
2024-03-25 10:26:33 -05:00
Marc Durdin
c5be180408
Merge pull request #11051 from keymanapp/fix/developer/11043-kmc-sourcemaps
fix(developer): correct path for kmc sourcemaps in sentry upload
2024-03-25 18:36:51 +11:00
Marc Durdin
69fdd697d1 refactor(developer): polish fixup function 2024-03-25 10:27:19 +07:00
Marc Durdin
2e2af5b0fa refactor(developer): tidy up the sourcemap path fixup 2024-03-25 10:23:14 +07:00
Marc Durdin
a0d99ba07f
Merge pull request #11049 from keymanapp/fix/developer/11036-capture-alt-shortcuts-in-debugger
fix(developer): capture alt shortcuts in LDML keyboard debugger
2024-03-25 14:05:56 +11:00
Marc Durdin
287a43ae91 chore(developer): try /dist path 2024-03-25 06:06:45 +07:00
Marc Durdin
2ce8dc5147 chore(developer): test alternate frame patchup 2024-03-22 13:27:53 +07:00
Marc Durdin
03491f5b7e chore(developer): use rewriteFrames integration in kmc 2024-03-22 11:55:04 +07:00
Marc Durdin
69f63d2f45 chore(developer): round two attempt to resolve sourcemaps 2024-03-22 10:36:24 +07:00
Marc Durdin
dafb3d8192 fix(developer): correct path for kmc sourcemaps in sentry upload
Fixes #11043 (hopefully).
2024-03-22 09:02:36 +07:00
Marc Durdin
b8291ec187 fix(developer): capture alt shortcuts in LDML keyboard debugger
Fixes #11036.

Also removes unused function ShortcutDisabled from both debuggers, to
avoid confusion.
2024-03-22 08:39:30 +07:00
Marc Durdin
523e5d4efb fix(developer): catch sharing violation when saving mru
Fixes #11041.

If two TIKE processes try to save the MRU at the same time, this can
result in a sharing violation. The relevant OLE error code is not
saved as a constant in Delphi lib, so I looked it up and added it here.
2024-03-22 06:11:34 +07:00
Marc Durdin
ab8d41c008
Merge pull request #11016 from keymanapp/fix/developer/return-await-exitprocess
fix(developer): return after calling await exitProcess
2024-03-22 09:18:35 +11:00
Dr Mark C. Sinclair
f316169d51
Merge pull request #10995 from keymanapp/fix/developer/font-file-meta-is-invalid-error
fix(developer): font file meta data is invalid error
2024-03-21 11:17:40 +00:00
Dr Mark C. Sinclair
29d565727b fix(developer): added further text to @throws comment in getFontFamily() 2024-03-21 10:18:30 +00:00
Dr Mark C. Sinclair
d0b29dfedd fix(developer): added @throws comment to getFontFamily() 2024-03-21 10:13:58 +00:00
Dr Mark C. Sinclair
9da1b12630 fix(developer): add comments wrt unused message codes 2024-03-21 09:44:43 +00:00
Marc Durdin
33386746ca fix(developer): return after calling await exitProcess
Because exitProcess is async, static analysis of the function does not
show process termination, even though it returns Promise<Never>. This
can lead to compiler warnings when it gets confused about missing return
values. So have moved to always returning the value from exitProcess,
even though it will never actually return!
2024-03-17 03:45:42 +03:00
Dr Mark C. Sinclair
a51927206a fix(developer): add code coverage for ERROR_FontFileCannotBeRead due to difficulty in forcing this error 2024-03-14 10:45:02 +00:00
Dr Mark C. Sinclair
83dedaabf5 fix(developer): correct fixture names for ERROR_FontFileMetaDataIsInvalid test 2024-03-14 10:36:47 +00:00
Dr Mark C. Sinclair
b7bbd759a4 fix(developer): add ERROR_FontFileMetaDataIsInvalid error and corresponding test 2024-03-14 10:29:32 +00:00