Steven R. Loomis
5f836d72f0
Merge pull request #11059 from keymanapp/fix/core/11045-assert-marker
...
fix(core,developer): variable/marker substitution in sets and strings🙀
2024-03-28 00:11:28 -05:00
Steven R. Loomis
baeb3c80fc
fix(developer): fix an additional issue on illegal UnicodeSets
...
- update comments per review comments
- improve logic of checks around malloc
2024-03-26 17:24:56 -05:00
Steven R. Loomis
f2ad7d4e68
fix(common): further improvement to string/set substitution
...
- tran: check for \uXXXX earlier in the chain, because we emit this format further down
- add test cases for syntax chars being used in variables
Fixes: bug(core): assert when matching markers #11045
Fixes: bug(developer): escape on string substitution if syntax char #11037
2024-03-25 14:52:32 -05:00
Steven R. Loomis
f773066fa0
fix(developer): store set variables in literal form, unescape in tran
...
- update the tran compiler to call escapeStringForRegex() on set items being substituted into an expression
2024-03-25 12:46:55 -05:00
Steven R. Loomis
67838e60a2
fix(developer,core): fix for marker substitution in sets
...
- for bug(core): assert when matching markers #11045
- track raw and marker-substituted sets
2024-03-25 12:00:55 -05:00
Steven R. Loomis
18ba46d874
fix(common): fix an additional issue on illegal UnicodeSets
...
- similar fix to https://github.com/keymanapp/keyman/pull/9492
- again may be due to a wasm version variant
- also additional rangechecking on the input side
2024-03-25 10:26:33 -05:00
Marc Durdin
812e914e87
fix(developer): min Keyman version for LDML is 17.0
...
Fixes #10959 .
2024-03-11 15:15:47 -05:00
Marc Durdin
ffe43d29ef
Merge branch 'beta' into fix/developer/10942-normalize-paths-in-kmc-package
2024-03-07 18:13:43 +07:00
Marc Durdin
7d03010479
fix(developer): normalize all input paths in .kps compiler
...
Fixes #10942 .
2024-03-05 17:34:06 -06:00
Steven R. Loomis
8975a38109
chore(common): ldml update out of techpreview 🙀
...
- updates to support techpreview -> 45
Fixes : #10900
2024-03-02 22:40:38 -06:00
Marc Durdin
abd5a86196
Merge branch 'beta' into refactor/developer/10207-message-detail
2024-03-01 07:54:31 +07:00
Marc Durdin
4bb9b39ba2
refactor(developer): reorganize messages for adding details
...
Moved the ERROR_Message line above the Error_Message line for every
message in the compiler message files, as it makes the grouping clearer
once we start adding message details. For example, see the start of the
KmnCompilerMessages class.
Also wraps potentially-undefined parameters to the messages with a new
function `def`, shorthand for `CompilerMessageDef`, which converts the
parameter to '<param>' if it is undefined, which is helpful for
documentation.
2024-02-28 16:00:02 +07:00
Marc Durdin
c7afed7201
refactor(developer): split messages with callstacks into separate generator
...
Relates to #10207 .
In order to include message detail in messages, it is helpful to split
out the exception messages which have a separate parameter, so that
parameter at the same position can be the message detail.
Introduces the CompilerMessageSpecWithException function which takes an
exceptionVar parameter to achieve this differentiation.
2024-02-28 11:34:49 +07:00
Steven R. Loomis
9c2a73a290
chore(common,developer): rename unicodeSet to uset in code
...
Fixes: rename unicodeSet to uset 🙀 #10657
2024-02-27 18:15:57 -06:00
Marc Durdin
e1a8ce47e3
Merge pull request #10821 from keymanapp/fix/developer/10396-repeated-options-in-kmc
...
fix(developer): repeated options in kmc must now be fully specified
2024-02-27 16:04:50 +07:00
Marc Durdin
70a50f0f67
refactor(developer): move osk module from common-types to developer-utils
...
This module is used only by Keyman Developer compiler. It was originally
in common-types because we didn't have a shared module for Developer.
Moving it to @keymanapp/developer-utils in order to improve its
documentation.
2024-02-26 14:57:27 +07:00
Marc Durdin
7b198eb4a4
fix(developer): repeated options in kmc must now be fully specified
...
Fixes #10396 .
Instead of `--message 20ae 5006`, which is ambiguous, because 5006 could
be a filename, you must now specify the parameter option flag each time:
`--message 20ae --message 5006` (or `-m 20ae -m 5006`).
2024-02-23 13:17:11 +07:00
Steven R. Loomis
7cd2e2d4e0
fix(developer): fix for incorrectly-stateful regex
...
- take out the /g flag for regex used with .exec
For #10734
2024-02-15 15:47:41 -06:00
Steven R. Loomis
8787073c40
feat(developer): errs on \uXXXX escapes 🙀
...
- note, some older test cases had to be fixed also.
For: #10389
2024-02-13 12:26:46 -06:00
Steven R. Loomis
da4b544471
feat(developer): errs on unparseable regex 🙀
...
- also, make sure NFD-incompliant ranges get mapped to escaped chars
- also, propagate UnicodeSet errs out
For: #10389
2024-02-12 18:16:34 -06:00
Marc Durdin
44abf2c41e
Merge pull request #10651 from markcsinclair/fix/developer/ensure-project-populate-files-actually-adds-files
...
fix(developer): ensure project populate files actually adds files
2024-02-07 16:01:56 +11:00
Steven R. Loomis
5360cff8e5
Merge branch 'feat/developer/10554-sometimes-no-norm' into feat/developer/10316-range-warning
2024-02-06 16:14:54 -06:00
Steven R. Loomis
9085a4fcda
feat(developer): support normalization=disabled 🙀
...
- assume normalization is enabled
#10554
2024-02-06 16:11:20 -06:00
Steven R. Loomis
50e0b31e9e
feat(developer): support normalization=disabled 🙀
...
- fix check normalization state
#10554
2024-02-06 14:54:26 -06:00
Dr Mark C. Sinclair
29b6601018
fix(developer): ensure project populate files actually adds files and test
2024-02-06 10:39:47 +00:00
Steven R. Loomis
4b22d3a527
Apply suggestions from code review
...
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-02-05 17:17:29 -06:00
Steven R. Loomis
10940be7e0
feat(developer): hint/warn on range check 🙀
...
- analyzer
#10316
2024-02-02 15:18:08 -06:00
Steven R. Loomis
107e8e98f9
feat(developer): hint/warn on range check 🙀
...
- analyzer
#10316
2024-02-02 12:09:23 -06:00
Steven R. Loomis
d77ed9099b
feat(developer): support normalization=disabled 🙀
...
#10554
2024-01-31 23:16:51 -06:00
Steven R. Loomis
6c1447bb4b
feat(core,developer): simplify markers 🙀
...
- clean up removing multi-segment processing
2024-01-31 18:17:17 -06:00
Steven R. Loomis
32d2e6ea2c
feat(core,developer): simplify markers 🙀
...
- maybe don't need NFD table
#10317
2024-01-31 18:15:37 -06:00
Steven R. Loomis
1988c43a05
feat(common): updates to marker parsing 🙀
...
- clear the marker map at the end of remove_markers if no markers were found.
- add some suggested tests from @jahorton and @mcdurdin
For: #10317
2024-01-31 18:04:29 -06:00
Steven R. Loomis
722131dcf3
feat(developer): double markers once again 🙀
...
- add another greek double reorder. with chips.
Fixes : #10516
2024-01-31 17:47:21 -06:00
Steven R. Loomis
1cfeeed3e4
feat(developer): double markers once again 🙀
...
- fix off by one in adding denormalized glue chars
Fixes : #10516
2024-01-31 17:47:21 -06:00
Steven R. Loomis
75aa04a4ee
feat(developer): double markers once again 🙀
...
- revert comment
- reorder tests
Fixes : #10516
2024-01-31 17:47:21 -06:00
Steven R. Loomis
462cdf3f30
feat(developer): double markers once again 🙀
...
- use an 'end' marker for each NFD
Fixes : #10516
2024-01-31 17:47:21 -06:00
Marc Durdin
f546c44048
Merge pull request #10390 from keymanapp/epic/core/9999-normalization
...
epic: Keyman Core normalization 🌱
2024-01-31 10:45:51 +11:00
Steven R. Loomis
1e3ae9b8f6
feat(developer): dev side norm 🙀
...
- normalize in key.to, tran.from, tran.to
- add as an option in the strs pipeline
- also, assertCodePoints utility for asserting with escapes
For: #10317
2024-01-26 19:10:00 -06:00
Steven R. Loomis
6ca5a29675
chore(developer): ldml add tests expecting dev side norm 🙀
...
- also, change this.X to Class.X for statics
For: #10317
2024-01-26 18:06:31 -06:00
Steven R. Loomis
44d8ba7198
feat(developer): ldml marker normalization fix 🙀
...
- ts side
For: #10516
2024-01-26 14:54:15 -06:00
Marc Durdin
07d3e9981d
chore: test preserveConstEnums in common/web/types only
2024-01-24 10:55:31 +07:00
Steven R. Loomis
ea59f0d596
fix(common): ldml: fix typo in kmc error message 🙀
...
- stray dot in the pathname, it's not a regex!
2024-01-23 09:44:52 -06:00
Steven R. Loomis
52d9c48128
feat(developer): document marker algo 🙀
...
For: #10317
2024-01-22 21:51:01 -06:00
Steven R. Loomis
c3bae838ec
feat(developer): ldml marker normalization in ts 🙀
...
- use Intl.Segmenter instead.
For: #10317
2024-01-19 18:32:08 -06:00
Steven R. Loomis
f2082d79a6
feat(developer): ldml marker normalization in ts 🙀
...
- cleanup and move marker_no_index into the shared area
For: #10317
2024-01-19 18:07:51 -06:00
Steven R. Loomis
20e2d811eb
feat(developer): ldml marker normalization in ts 🙀
...
- normalize_nfd is working
For: #10317
2024-01-19 18:00:27 -06:00
Steven R. Loomis
e05549eaf9
feat(developer): ldml marker normalization in ts 🙀
...
- add_back_markers
For: #10317
2024-01-19 17:44:36 -06:00
Steven R. Loomis
2bb4747c2f
feat(developer): ldml marker normalization in ts 🙀
...
- add nfd table from ICU
For: #10317
2024-01-19 16:26:01 -06:00
Steven R. Loomis
9e9bbf8b44
feat(developer): ldml marker normalization in ts 🙀
...
- add remove_markers
For: #10317
2024-01-19 14:30:55 -06:00
Steven R. Loomis
6e2030b3b8
feat(developer): ldml marker normalization in ts 🙀
...
- intial parsing
For: #10317
2024-01-18 12:39:19 -06:00