Commit graph

33096 commits

Author SHA1 Message Date
Dr Mark C. Sinclair
f0be2acdec chore(developer): Merge branch 'master' into test/developer/kmcmplib-compiler-unit-tests-3 2024-09-12 10:45:49 +01:00
Sabine
5f0612d170 Merge branch 'feat/mac/mcompile_mac' of https://github.com/keymanapp/keyman into feat/mac/mcompile_mac 2024-09-12 11:35:33 +02:00
Dr Mark C. Sinclair
3304594741
Merge pull request #12328 from keymanapp/fix/developer/11833-index-requires-comma-between-parameters-in-kmcmplib-compiler
fix(developer): index() requires comma between parameters in kmcmplib compiler
2024-09-12 10:22:42 +01:00
Darcy Wong
84dbc1042c chore(common): Update crowdin strings for Italian 2024-09-12 15:56:22 +07:00
Dr Mark C. Sinclair
2a477c6d47 chore(developer): Merge branch 'master' into fix/developer/11833-index-requires-comma-between-parameters-in-kmcmplib-compiler 2024-09-12 09:18:03 +01:00
Eberhard Beilharz
fc32f02dc9
Merge pull request #12400 from keymanapp/chore/web/testexplorer
chore(web): allow to run unit tests in vscode test explorer
2024-09-12 14:07:55 +07:00
Eberhard Beilharz
44ba53af14
Merge pull request #12399 from keymanapp/refactor/web/12388_device-detect
refactor(web): merge `device-detect` with `web/src/engine/main` 🏗️
2024-09-12 13:50:48 +07:00
Eberhard Beilharz
757a5e8de9
Merge pull request #12397 from keymanapp/refactor/web/12387_sentry
refactor(web): move sentry-manager → `web/src/engine/sentry-manager` 🏗️
2024-09-12 13:50:26 +07:00
Eberhard Beilharz
9e15a38b02
Merge pull request #12390 from keymanapp/refactor/web/12386_eslint
refactor(web): move `common/web/eslint` → `common/tools/eslint` 🏗️
2024-09-12 13:49:58 +07:00
Eberhard Beilharz
66d815efc7
Merge pull request #12389 from keymanapp/refactor/web/12385_es-bundling
refactor(web): move `common/web/es-bundling` → `web/src/tools/es-bundling` 🏗️
2024-09-12 13:49:37 +07:00
Marc Durdin
8424cb9349
Merge branch 'master' into feat/developer/kmc-generate 2024-09-12 08:18:37 +02:00
Darcy Wong
6b0d8ddec1
Merge pull request #12393 from keymanapp/chore/common/unicode-16
chore(common): Update to Unicode 16.0
2024-09-12 11:25:07 +07:00
rc-swag
06de2b0475 feat(windows): change automatic update description 2024-09-12 14:05:05 +10:00
rc-swag
5c187db7a6 feat(windows): address review comments 2024-09-12 13:40:42 +10:00
Marc Durdin
b7810bdd2e fix(developer): check vars string usage before definition
Validation of vars was not properly checking for forward references to
string variables. This, coupled with a null vs undefined bug in
subsequent use, meant that forward reference variables were ending up
with a literal string value of 'undefined'.

This also fixes the test for visual-keyboard-compiler, where the fixture
was actually buggy and was the trigger for investigating this problem.

Fixes: #12403
Relates-to: #12395
2024-09-12 09:18:06 +07:00
Marc Durdin
e4017a8c28 fix(developer): rewrite ldml visual keyboard compiler
The visual keyboard compiler was never finished in 17.0. This rewrites
it to:

1. Use the kmxplus data rather than reading from xml directly
2. Fill in `visualkeyboard.header.kbdname`
3. Support modifiers
4. Handle encoded characters like `\u{1234}`
5. Handle string variables like `${one}`*

Additional unit tests have been added to verify the behavior of the
visual keyboard compiler in more detail.

TODO-LDML: string variables appear to have a secondary bug -- they seem
to be returning the string 'undefined'. I have disabled the related
tests and will examine this separately, and enable those tests once
fixed.

TODO-LDML: we should probably add a compiler warning + unit test for
`<layers formId="us"><layer id="base">`, because this pattern does not
make sense: when using non-touch forms, the `<layer>` element should use
`modifiers` attribute, and correspondingly, `modifiers` attribute should
_not_ be used when `formId` is `touch`.

Other fixes:

1. The LDML XML reader was relying on its input being a Node.js `Buffer`
   even though it was declared `Uint8Array`, as it implicitly used
   `Buffer.toString()` to do text conversion. (`Buffer` subclasses from
   `Uint8Array`). This breaks when using `Uint8Array` directly and means
   we had an implicit dependency on Node.js. See also #12331.
2. XML errors were not captured in the LDML XML reader. See also #12331.
3. The unused and unfinished touch-layout-compiler.ts and
   keymanweb-compiler.ts have been removed along with corresponding unit
   tests and fixtures. These are replaced by Core implementations; see
   #12291.

Fixes: #12395
2024-09-12 06:06:00 +07:00
Keyman Server
031f682a62
Merge pull request #12401 from keymanapp/auto/version-master-18.0.110
auto: increment master version to 18.0.110
2024-09-11 11:04:10 -07:00
Keyman Build Agent
870f205990 auto: increment master version to 18.0.110 2024-09-11 14:03:29 -04:00
Eberhard Beilharz
95f36acb68
chore(web): allow to run unit tests in vscode test explorer
#11746 removed the `ts-node` dependency. Unfortunately that broke running
TypeScript test files with Mocha in VSCode Test Explorer because it no
longer knows what to do with .ts files. This change adds the more modern
`tsx` package as developer dependency, which allows to use Test Explorer
again.

See https://stackoverflow.com/a/77609121.
2024-09-11 19:28:33 +02:00
Eberhard Beilharz
04c9817d26
chore(web): remove unused file
All subprojects that used `common/web/tsconfig.kmw-main-base.json`
got moved so that this file is no longer used by anyone.
2024-09-11 16:49:16 +02:00
Eberhard Beilharz
f52a1209c8
refactor(web): merge device-detect with web/src/engine/main
This change moves `web/src/engine/device-detect/` →
`web/src/engine/main/` and renames the `Device` class to `DeviceDetector`.

Fixes: #12388
2024-09-11 16:48:15 +02:00
Eberhard Beilharz
e54f822786
chore(linux): cleanup
Setting permissions is now done in the base image.
2024-09-11 16:16:18 +02:00
Darcy Wong
e62d05cff7 fix(core): Disable test_unicode check for ICU version 2024-09-11 20:56:50 +07:00
Eberhard Beilharz
e23e112e7a
chore(linux): remove temporary code for Core image 2024-09-11 15:54:20 +02:00
Eberhard Beilharz
b20d7f1eb4
refactor(web): move sentry-manager → web/src/engine/sentry-manager
Move `common/web/sentry-manager` to `web/src/engine/sentry-manager`.

Fixes: #12387
2024-09-11 15:15:01 +02:00
Eberhard Beilharz
47d63bc573
Merge branch 'refactor/web/12385_es-bundling' into refactor/web/12386_eslint 2024-09-11 14:46:47 +02:00
Eberhard Beilharz
caba09a8d4
chore(linux): attempt to fix Android build in Docker
These changes bring us one step further, but the build is still failing.
2024-09-11 14:30:22 +02:00
Eberhard Beilharz
475fd734e6
docs(android): document gradle version in minimum-versions 2024-09-11 14:29:01 +02:00
Eberhard Beilharz
367b029979
Merge pull request #12384 from keymanapp/refactor/web/12025_web-utils
refactor(web): move `common/web/utils` to `web/src/engine/common/web-utils/` 🏗️
2024-09-11 17:28:38 +07:00
Eberhard Beilharz
98c7932760
Merge pull request #12383 from keymanapp/refactor/web/12133_modelsWorkdbreakers
refactor(web): move `common/models` to `web/src/engine/predictive-text` 🏗️
2024-09-11 17:28:01 +07:00
Eberhard Beilharz
d4a049f614
refactor(web): move to web/src/tools/es-bundling
Addresses code review comments.
2024-09-11 09:44:58 +02:00
Eberhard Beilharz
c7a7ea2c51
Merge branch 'refactor/web/12025_web-utils' into refactor/web/12385_es-bundling 2024-09-11 09:28:19 +02:00
Eberhard Beilharz
d7f7ce9209
Merge branch 'refactor/web/12133_modelsWorkdbreakers' into refactor/web/12025_web-utils 2024-09-11 09:27:35 +02:00
Eberhard Beilharz
7e30dbf392
Merge remote-tracking branch 'origin/master' into refactor/web/12133_modelsWorkdbreakers 2024-09-11 09:21:59 +02:00
dependabot[bot]
094aa985b2
chore(deps): bump express from 4.19.2 to 4.20.0
Bumps [express](https://github.com/expressjs/express) from 4.19.2 to 4.20.0.
- [Release notes](https://github.com/expressjs/express/releases)
- [Changelog](https://github.com/expressjs/express/blob/master/History.md)
- [Commits](https://github.com/expressjs/express/compare/4.19.2...4.20.0)

---
updated-dependencies:
- dependency-name: express
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
2024-09-11 07:18:39 +00:00
Eberhard Beilharz
fe63af0ecc
Merge pull request #12382 from keymanapp/refactor/web/12133_modelsTemplates
refactor(web): move `model/templates` to `web/src/engine/predictive/text` 🏗️
2024-09-11 14:17:14 +07:00
Eberhard Beilharz
cc21dda3cc
Apply suggestions from code review
Co-authored-by: Marc Durdin <marc@durdin.net>
2024-09-11 09:17:01 +02:00
Darcy Wong
431c15179f
Merge pull request #12394 from keymanapp/chore/common/history-17-0-329
chore(common): Update history with 17.0.329 stable
2024-09-11 11:14:26 +07:00
sgschantz
b3651f0dfa change(mac): renamed property and cleaned up comments
Fixes: #12342
2024-09-11 11:03:47 +07:00
Darcy Wong
5f0617f166 chore(common): Update history with 17.0.329 stable 2024-09-11 10:15:11 +07:00
Darcy Wong
e966a8af3c chore(common): Download Unicode 16.0 characters 2024-09-11 09:34:57 +07:00
Darcy Wong
5bfb93e618 chore(common): Update KEYMAN_VERSION_UNICODE to 16.0.0 2024-09-11 09:33:30 +07:00
Keyman Server
66ee99e3e6
Merge pull request #12391 from keymanapp/auto/version-master-18.0.109
auto: increment master version to 18.0.109
2024-09-10 11:04:15 -07:00
Keyman Build Agent
da02b9c7ce auto: increment master version to 18.0.109 2024-09-10 14:03:41 -04:00
Eberhard Beilharz
1fe6a0370f
refactor(web): move common/web/eslintcommon/tools/eslint
Fixes: #12386
2024-09-10 19:16:52 +02:00
Eberhard Beilharz
6553bd6233
refactor(web): move common/web/es-bundlingcommon/tools/es-bundling
Fixes: #12385
2024-09-10 18:57:42 +02:00
Eberhard Beilharz
a6d2d02e61
refactor(web): move common/web/utils to web/src/engine/common/web-utils/
Fixes:#12025
2024-09-10 18:12:46 +02:00
Eberhard Beilharz
a9b9c4d016
refactor(web): move common/models to web/src/engine/predictive-text
Fixes: #12133
2024-09-10 17:45:22 +02:00
Eberhard Beilharz
91bbc250a8
refactor(web): move model/templates to web/src/engine/predictive/text
Part-of: #12133
2024-09-10 17:10:12 +02:00
Dr Mark C. Sinclair
bcead57ad5 fix(developer): change to eliminate the possibility of an extra parameter, and add matching test 2024-09-10 14:46:17 +01:00