Commit graph

33096 commits

Author SHA1 Message Date
Darcy Wong
6ba69a04ce change(android/engine): Refactor viewport injection 2021-03-01 15:25:46 +07:00
Darcy Wong
c0b103d65d
Apply suggestions from code review
Co-authored-by: Joshua Horton <joshua_horton@sil.org>
2021-03-01 14:31:46 +07:00
Darcy Wong
a249a89e9a
Merge pull request #4550 from keymanapp/chore/ios/custom-dictionary-help
chore(ios/app): Adjust help titles for installing custom dictionaries
2021-03-01 14:09:28 +07:00
Darcy Wong
3c4b783691 fix(android/engine): Destroy keyboard to free webViews when viewing help 2021-03-01 13:27:41 +07:00
Marc Durdin
1fcfefa3cf fix(developer): support for smp names 2021-03-01 16:05:17 +11:00
Marc Durdin
3f54c81461 fix(developer): touch layout osk import handling of multiple modifiers
Fixes #2740.

The definitions for several of the combined modifiers was incorrect,
which led to a mismatch when attempting to import those layers from a
visual keyboard into the touch layout editor.
2021-03-01 15:44:55 +11:00
Darcy Wong
9ce0d72267 chore(ios/app): Adjust help titles for installing custom dictionaries 2021-03-01 10:02:10 +07:00
Joshua Horton
d2278c6494
Merge pull request #4540 from keymanapp/fix/web/1125-ff-keymaps-with-mnemonics
fix(web): mnemonic keystrokes w FF keymapping
2021-03-01 08:17:01 +07:00
Marc Durdin
2f2f998da6 fix(developer): schema conformance for model package compiler
Fixes #3199.

Ensures that the model package compiler passes schema validation for
kmp.json. Three problems were corrected:

1. `followKeyboardVersion` is a source-only property; it should not be
   in deployable kmp.json.
2. `copyLocation` should have been a number not a string (in XML
   everything is a string... but JSON has more control here)
3. `fileType` is a source-only property; it also should not be in
   deployable kmp.json.

I have checked that the resulting files validate against the package
kmp.json schema version 1.1.0 defined at
https://github.com/keymanapp/api.keyman.com/blob/master/schemas/package/1.1.0/package.json.

None of these fixes should impact the use of these packages in target
apps. `followKeyboardVersion` and `fileType` are used only in the source
at package development time, and `copyLocation` is unused (and should be
eliminated from Keyman altogether in the future).
2021-03-01 10:57:49 +11:00
Marc Durdin
17c94770ef chore(windows): update test project 2021-03-01 10:34:30 +11:00
Marc Durdin
26b1d777f7 fix(developer): Improve stability of named code constants
Fixes #4423.

Using a named character constant with a store name that included
characters outside ascii could cause kmcmpdll to crash with an assertion
failure.

This fix allows store names defined in the .kmn file to use characters
outside ascii.

Note that more work needs to be done on which characters are acceptable
to use, as this is somewhat implementation-specific according to the C++
specification for `iswalpha`.

Added a test case to verify various named code constant examples.

Also removes dead code for `IsCJKUnifiedIdeograph` as this was never
used and somewhat pointless in any case.

NamedCodeConstants.cpp could stand to be rewritten using `std::map` or
equivalent. Current implementation is pretty icky.
2021-03-01 10:25:06 +11:00
Keyman Server
aaaddb597c
Merge pull request #4546 from keymanapp/auto/version-beta-14.0.249
auto: increment beta version to 14.0.249
2021-02-27 05:03:29 +11:00
Keyman Build Agent
eabc2e4f3c auto: increment beta version to 14.0.249 2021-02-26 13:02:44 -05:00
Marc Durdin
d4bf9f910e
Merge pull request #4535 from keymanapp/fix/windows/4445-upgrade-of-14-re-registered-all-tips
fix(windows): prevent re-registration of TIPs on 14.0 upgrade
2021-02-26 19:56:48 +11:00
Marc Durdin
d496d266fa
Merge pull request #4378 from keymanapp/fix/windows/4289-altgr-refresh-on-64-bit
fix(windows): Refresh settings on 64-bit apps
2021-02-26 19:55:28 +11:00
Joshua Horton
d3718cd5d0
Merge pull request #4543 from keymanapp/fix/ios/package-install-ui-glitch
fix(ios): package installer completion requires welcome dismissal
2021-02-26 14:58:51 +07:00
jahorton
a9692c0b24 fix(ios): package installer completion requires welcome dismissal 2021-02-26 14:28:46 +07:00
Joshua Horton
c7cf3d8947
Merge pull request #4427 from keymanapp/feat/common/models/mid-context-suggestions
feat(common/models): mid-context suggestions & reversions, fix(common/models): correction-search SMP issues
2021-02-26 12:11:47 +07:00
jahorton
58a214831b docs(web): enhances comments re: keymapping 2021-02-26 12:06:39 +07:00
jahorton
a232f32ea4 chore: reverts right-delete changes 2021-02-26 10:32:48 +07:00
Marc Durdin
f6734879a8
Merge pull request #4539 from keymanapp/fix/developer/4221-utf8-messages-in-lm-compiler
fix(developer): UTF-8 messages in LM compiler
2021-02-26 14:32:37 +11:00
Marc Durdin
4aced2762c
Merge pull request #4537 from keymanapp/fix/developer/4451-continue-if-sentry-not-available
fix(developer): run even if sentry unavailable
2021-02-26 14:32:31 +11:00
Marc Durdin
d342a91da0
Merge pull request #4536 from keymanapp/fix/windows/4525-handle-caps-lock-event-correctly
fix(windows): Handle Caps Lock event correctly from TIP
2021-02-26 14:32:17 +11:00
Marc Durdin
e2c79b0dfa fix(developer): UTF-8 messages in LM compiler
Fixes #4221.

When the Keyman Developer IDE calls out to the lexical model compiler,
it receives UTF-8 compiler message strings back but they are treated as
Windows-1252 strings. This fixes that.
2021-02-26 13:59:21 +11:00
jahorton
86341505eb fix(web): mnemonic keystrokes w FF keymapping. Fixes #1125 2021-02-26 09:58:27 +07:00
Marc Durdin
c8e6ddbe7b fix(developer): run even if sentry unavailable
Fixes #4451.

If sentry.dll is missing, we should continue without error reporting,
rather than crashing out.
2021-02-26 11:45:16 +11:00
Marc Durdin
d7e4e18987 fix(windows): Handle Caps Lock event correctly from TIP
Fixes #4525.

This is a regression from #4468, which inadvertently added modifier
checks for `VK_CAPITAL` and `VK_NUMLOCK`, when it should not have done
so, as the flag was then being reset when the key was released rather
than toggled.

`ProcessModifierChange` pretended that it could handle `VK_CAPITAL` and
`VK_NUMLOCK` but it would never have worked, and the other caller (the
GetMessage hook) never passed those key events through, only Shift, Ctrl
and Alt, so that's now what the TIP handler does as well.

This leaves the rest of the fix from #4468 in place as that appears
correct.

I took the opportunity to move a repeated function declaration into
keyman64.h.
2021-02-26 10:54:30 +11:00
Marc Durdin
27529287e2 fix(windows): prevent re-registration of TIPs on 14.0 upgrade
Fixes #4445.

When upgrading from 11.0, 12.0 or 13.0, Keyman needs to re-register the
TIPs so that we use the new registration model for 14.0. However, if we
do this on a 14.0 version install, we end up registering TIPs for every
single suggested language for a keyboard, which is definitely not what
we want.

This fix simply looks to see if we have a 14.0-style installation
already, as evidenced by the presence of a `Transient Language Profiles`
key, and if found, does not continue the 11to13 upgrade process.
2021-02-26 07:42:55 +11:00
Keyman Server
81d7722bf4
Merge pull request #4534 from keymanapp/auto/version-master-15.0.19
auto: increment master version to 15.0.19
2021-02-26 05:24:01 +11:00
Keyman Build Agent
ca128e5adf auto: increment master version to 15.0.19 2021-02-25 13:23:09 -05:00
Keyman Server
2dedf76df7
Merge pull request #4533 from keymanapp/auto/version-beta-14.0.248
auto: increment beta version to 14.0.248
2021-02-26 05:23:04 +11:00
Keyman Build Agent
66f8ea2c3e auto: increment beta version to 14.0.248 2021-02-25 13:22:15 -05:00
Eberhard Beilharz
310db51e7c
Merge pull request #4530 from keymanapp/fix/linux/build
fix(linux): Set help-keyman.com.sh executable
2021-02-25 11:50:20 +01:00
Darcy Wong
02f8c6fd5e
fix(common): Set help-keyman.com.sh executable
(cherry picked from commit cf758452c0)
2021-02-25 09:58:58 +01:00
Darcy Wong
f466604dd2 fix(android/app): Fix welcome.htm responsiveness 2021-02-25 15:30:36 +07:00
Joshua Horton
4794337d42
Merge pull request #4516 from keymanapp/fix/web/3910-namespaced-css-class
fix(web): removes package namespacing from kbd's CSS class
2021-02-25 15:09:25 +07:00
Joshua Horton
5041d092fe
Merge pull request #4512 from keymanapp/fix/web/4436-documentation-keyboards
fix(web): keyboard documentation patch-up
2021-02-25 15:09:17 +07:00
jahorton
fc2a17890c docs(common/models): adds comments about bug in iOS insertText 2021-02-25 14:43:35 +07:00
jahorton
8516561081 change(common/models): disables right-deletion for now 2021-02-25 14:31:11 +07:00
jahorton
28ed690fe2 chore(common/models): Merge branch 'beta' into feat/common/models/mid-context-suggestions 2021-02-25 09:16:45 +07:00
Keyman Server
5fbcd7b342
Merge pull request #4523 from keymanapp/auto/version-beta-14.0.247
auto: increment beta version to 14.0.247
2021-02-25 06:41:01 +11:00
Keyman Build Agent
dede81e2b8 auto: increment beta version to 14.0.247 2021-02-24 14:40:17 -05:00
Marc Durdin
ace167e759
Merge pull request #4522 from keymanapp/chore/common/allow-forced-version-increment
chore(common): allow forced version increment
2021-02-25 06:34:05 +11:00
Marc Durdin
000867e89b chore(common): allow forced version increment
Allows us to manually run a version increment, for example if there is
a problem with a release build such as running out of space on the
download server.
2021-02-25 06:28:32 +11:00
Keyman Server
4e0c8c5aff
Merge pull request #4521 from keymanapp/auto/version-beta-14.0.246
auto: increment beta version to 14.0.246
2021-02-25 05:02:38 +11:00
Keyman Build Agent
a4e4e24cc1 auto: increment beta version to 14.0.246 2021-02-24 13:01:48 -05:00
Joshua Horton
b56fa20c78
Merge pull request #4514 from keymanapp/fix/web/3954-hidecaret-on-focus-change
fix(web): hides touch-alias caret when keystroke causes focus change
2021-02-24 14:56:26 +07:00
jahorton
6ca508a314 fix(web): removes package namespacing from kbd's CSS class 2021-02-24 14:26:10 +07:00
jahorton
431a9fc85a fix(web): hides touch-alias caret when keystroke causes focus change 2021-02-24 13:20:54 +07:00
jahorton
ec61fa22d2 change(web): reverts incomplete tweak 2021-02-24 12:33:23 +07:00