Commit graph

5289 commits

Author SHA1 Message Date
Joshua Horton
de0eaa411b change(web): lint kmwstring web-utility
This removes the exception in #13797 for KMWString, properly including the newly-refactored code in linting as well.
2025-04-30 09:01:47 +07:00
Joshua Horton
16fb2fef49 Merge branch 'chore/web/add-string-handling-unit-tests' into refactor/web/eliminate-kmwstring-side-effects 2025-04-30 08:57:36 +07:00
Joshua Horton
7217d7cf72 feat(web): add more indexOf, lastIndexOf unit test statements
Co-authored-by: Eberhard Beilharz <eb1@sil.org>
2025-04-30 08:42:27 +07:00
Joshua Horton
4e4fbc174a Merge branch 'chore/web/replace-kmwfromcharcode' into chore/web/add-string-handling-unit-tests 2025-04-30 08:33:02 +07:00
Joshua Horton
efb14e7b2a Merge branch 'change/web/lint-web-utils' into chore/web/replace-kmwfromcharcode 2025-04-30 08:32:09 +07:00
Joshua Horton
80f95d979a change(web): lint engine/common/web-utils
Does not lint kmwstring.ts, as that has an existing rework.  A separate PR will be added as a followup to the refactor PR (#13726) to handle it.
2025-04-30 08:30:06 +07:00
Joshua Horton
efe8ed39cc Merge branch 'master' into chore/web/replace-kmwfromcharcode 2025-04-30 08:22:43 +07:00
Joshua Horton
d9bddee90e
Merge pull request #13714 from keymanapp/fix/web/web-util-unit-testing
fix(web): reconnect unit tests for low-level web utility classes/methods 🧶
2025-04-30 08:21:20 +07:00
Joshua Horton
8f04951c80 chore(web): enable web/ linting 2025-04-29 12:01:42 +07:00
Joshua Horton
d6579495f8 change(web): address recorder-tool linter errors 2025-04-29 11:54:44 +07:00
Joshua Horton
4762429e96 change(web): address app/ui linter errors 2025-04-29 11:40:19 +07:00
Joshua Horton
da138b098d change(web): address app/browser linter errors 2025-04-29 11:38:08 +07:00
Joshua Horton
241f9655f2 change(web): address app/webview linter errors 2025-04-29 11:32:35 +07:00
Joshua Horton
19021f1419 change(web): address engine/main linter errors 2025-04-29 11:30:30 +07:00
Joshua Horton
0288048340 change(web): address engine/keyboard-storage linter errors 2025-04-29 11:29:16 +07:00
Joshua Horton
7baf8d0b69 change(web): address engine/attachment linter errors 2025-04-29 11:28:28 +07:00
Joshua Horton
f839810cc0 change(web): address engine/osk/gesture-processor linter errors 2025-04-29 11:03:59 +07:00
Joshua Horton
f6134244f2 change(web): address engine/osk linter errors 2025-04-29 11:02:23 +07:00
Joshua Horton
6ba37bc61b change(web): address engine/interfaces linter errors 2025-04-29 10:57:52 +07:00
Joshua Horton
f1ca263da2 change(web): address engine/events linter errors 2025-04-29 10:57:28 +07:00
Joshua Horton
63f6216774 change(web): address engine/element-wrappers linter errors 2025-04-29 10:55:30 +07:00
Joshua Horton
db6b61e8fc change(web): address engine/js-processor linter errors 2025-04-29 10:54:37 +07:00
Joshua Horton
7b1cfe94ff change(web): address engine/dom-utils linting errors 2025-04-29 10:52:35 +07:00
Joshua Horton
e601d59b59 change(web): replace USVString with string in predictive-text engine
Fixes: #12046

It was only ever an alias (for `string`!) for its intended use, with actual `USVString` typing being unavailable in the browser.
2025-04-29 10:47:20 +07:00
Joshua Horton
43eb195ee1 fix(web): patch up detected behavior change 2025-04-29 10:19:38 +07:00
Joshua Horton
e8125898e5 Merge branch 'chore/web/add-string-handling-unit-tests' into refactor/web/eliminate-kmwstring-side-effects 2025-04-29 10:18:54 +07:00
Joshua Horton
b3633ec4d0 feat(web): add additional edge-case unit tests
Co-authored-by: Eberhard Beilharz <eberhard_beilharz@sil.org>
2025-04-29 10:12:10 +07:00
Joshua Horton
a701b97888 fix(web): add robustness for bad touch-layout fontsize specs
Fixes: #13766
Fixes: KEYMAN-WEB-QX

It seems that at some point, Developer has been compiling raw "12" values in the touch-layout JSON as a numeric 12 for the fontsize field.  This clearly happened for the inuktitut_pirurvik keyboard; we should also inspect urdu_phonetic, which has the same raw "12".

This change ensures that Web can handle this case without spewing tons of warning/error messages.  It also adds error-logging to help with diagnosis for any related issue in the future.
2025-04-28 13:25:28 +07:00
Joshua Horton
dcc9638198 docs(web): minor nit regarding AltGr emulation 2025-04-25 13:16:31 +07:00
Joshua Horton
45fb8df97d docs(web): add a Web engine keystroke lifecycle internal doc
Fixes: #12732
2025-04-25 13:13:48 +07:00
Marc Durdin
9d4214c54c chore: Merge remote-tracking branch 'origin/master' into chore/merge-beta-to-master-release-prep 2025-04-22 13:16:21 +07:00
Joshua Horton
eb7bd3adba chore(web): remove artifacts re: potential method renames 2025-04-22 11:59:16 +07:00
Joshua Horton
9993a33f1b chore(web): remove side-effect field from web-utils package.json 2025-04-22 11:52:44 +07:00
Joshua Horton
dc450cde9e chore(web): finalize removal of side-effect KMWString implementation 2025-04-22 11:40:57 +07:00
Joshua Horton
f8ea902fd9 refactor(web): refactor _kmwCharAt 2025-04-22 11:40:57 +07:00
Joshua Horton
70c1920854 refactor(web): refactor _kmwSlice, _kmwSubstr, _kmwSubstring 2025-04-22 11:40:57 +07:00
Joshua Horton
2cb6e5a191 refactor(web): refactor _kmwIndexOf, _kmwLastIndexOf 2025-04-22 11:40:57 +07:00
Joshua Horton
a53f2dcd10 chore(web): refactor _kmwCharCodeAt 2025-04-22 11:40:39 +07:00
Joshua Horton
418f3d6aec chore(web): update all Web engine uses of kmwLength, kmwCodePointToCodeUnit, kmwCodeUnitToCodePoint 2025-04-22 10:17:07 +07:00
Joshua Horton
4863e95c46 refactor(web): refactor _kmwCodePointToCodeUnit, _kmwCodeUnitToCodePoint 2025-04-22 10:17:01 +07:00
Joshua Horton
f934de23b5 refactor(web): refactor _kmwLength 2025-04-22 10:16:54 +07:00
Joshua Horton
b368f5fe6a refactor(web): refactor _kmwNextChar, _kmwPrevChar helpers 2025-04-22 10:16:47 +07:00
Joshua Horton
e5a5305946 chore(web): drop .only from test suite 2025-04-22 09:12:35 +07:00
Joshua Horton
be15fc1c3f chore(web): add unit tests for SMP-aware string-handling helper methods 2025-04-21 13:09:01 +07:00
Joshua Horton
cdda6e8ce5
Merge pull request #13646 from keymanapp/fix/web/match-osk-and-banner-font-scaling
fix(web): match banner font scaling to osk font scaling
2025-04-21 09:10:48 +07:00
Joshua Horton
5b14b858fb chore(web): replace kmwFromCharCode with its ES6 equivalent 2025-04-21 08:36:59 +07:00
Joshua Horton
ddefb79b70 fix(web): reconnect unit tests for low-level web utility classes/methods 2025-04-21 08:18:56 +07:00
Marc Durdin
4f829f5c8f chore: Merge remote-tracking branch 'origin/master' into chore/merge-beta-to-master-b18s5 2025-04-21 07:13:35 +07:00
Joshua Horton
a4164d2c0f
Merge pull request #13632 from keymanapp/change/web/set-classname-on-mobile-page-trailer
change(web): add unique classname to mobile-device page-trailer element
2025-04-10 13:21:37 +07:00
Joshua Horton
30074eafe4
docs(web): fix quote consistency within the same sentence
Co-authored-by: Eberhard Beilharz <ermshiperete@users.noreply.github.com>
2025-04-08 08:12:07 +07:00